Blocked from adding cellular support to AU tests because of dependency on routing.py |
||
Issue descriptionTrying to add cellular support to AU Test: https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/869465/ It is failing the CQ during BuildPackages on the lakitu family of devices. From benchan on bug: "The problem is that cros/network.py import routing.py from shill (via chromeos-base/shill-test-scripts package), which isn't used on lakitu"
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ccd04739e596a34a90a965667591fe4eaf58ec6a commit ccd04739e596a34a90a965667591fe4eaf58ec6a Author: Ben Chan <benchan@chromium.org> Date: Thu Jan 25 10:43:20 2018 Copying routing.py from shill-test-scripts. With the deprecation of flimflim.py from the shill-test-scripts package, there is little value to import routing.py from there. Alos, routing.py will likely be removed along with flimflam.py. By copying routing.py from shill-test-scripts into autotest, we avoid the flimflam_test_path import hack and one less dependency on shill-test-scripts. BUG= chromium:776078 BUG= chromium:805737 TEST=Run cellular_Smoke which depends on network.py. Change-Id: I26533104856f2d169151fafd68a8328c1f83e125 Reviewed-on: https://chromium-review.googlesource.com/884986 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [add] https://crrev.com/ccd04739e596a34a90a965667591fe4eaf58ec6a/client/cros/routing.py [modify] https://crrev.com/ccd04739e596a34a90a965667591fe4eaf58ec6a/client/cros/network.py
,
Jan 25 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by benchan@chromium.org
, Jan 25 2018