New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805732 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 805730



Sign in to add a comment

[Fidnit] Refactoring swarming_util.py

Project Member Reported by chanli@chromium.org, Jan 25 2018

Issue description

- Reorg functions in swarming_util.py to more appropriate modules.
- Move swarming_util.py to service/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3902129793e1f8060e3b9ab4f81b71d68c4fe40c

commit 3902129793e1f8060e3b9ab4f81b71d68c4fe40c
Author: Chan <chanli@chromium.org>
Date: Thu Feb 01 05:38:58 2018

[Findit] Move gtest related logic to gtest.py (1/2)

This CL will move gtest related logic in swarming_util.py to gtest.py.

Bug:  805732 
Change-Id: I9e63aa02f4b37c1eec2101f473525fae4e9751a1
Reviewed-on: https://chromium-review.googlesource.com/889419
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[delete] https://crrev.com/d5e83d77d4aeb0f051bba0a2149187519077571a/appengine/findit/waterfall/test/data/shard3
[delete] https://crrev.com/d5e83d77d4aeb0f051bba0a2149187519077571a/appengine/findit/waterfall/test/data/shard2
[delete] https://crrev.com/d5e83d77d4aeb0f051bba0a2149187519077571a/appengine/findit/waterfall/test/data/shard2_isolated
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
[add] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/test_results.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/try_job.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/waterfall/swarming_util.py
[add] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/test/test_results_test.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/test/gtest_test.py
[delete] https://crrev.com/d5e83d77d4aeb0f051bba0a2149187519077571a/appengine/findit/waterfall/test/data/shard2_url
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/test_failure/extract_test_signal.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
[delete] https://crrev.com/d5e83d77d4aeb0f051bba0a2149187519077571a/appengine/findit/waterfall/test/data/shard3_isolated
[delete] https://crrev.com/d5e83d77d4aeb0f051bba0a2149187519077571a/appengine/findit/waterfall/test/data/expected_collect_results
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/test_failure/test/ci_test_failure_test.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/gtest.py
[delete] https://crrev.com/d5e83d77d4aeb0f051bba0a2149187519077571a/appengine/findit/waterfall/test/data/shard3_url
[modify] https://crrev.com/3902129793e1f8060e3b9ab4f81b71d68c4fe40c/appengine/findit/services/test_failure/test/extract_test_signal_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852

commit 75aa8fc6a59697b3a6a2f6c54bf81d260beb5852
Author: Chan <chanli@chromium.org>
Date: Mon Feb 05 19:21:24 2018

[Findit] Move swarming related logic only for flake analyzer to a separate module.

And moving OnConnectionFailed to monitoring module.

Bug:  805732 
Change-Id: I540333308cceac3638ade56dd2bb5ef1bfd53c95
Reviewed-on: https://chromium-review.googlesource.com/884578
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/flake/test/flake_analysis_util_test.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/flake/test/next_build_number_pipeline_test.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/flake/trigger_flake_swarming_task_service_pipeline.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/services/monitoring.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/flake/flake_analysis_util.py
[modify] https://crrev.com/75aa8fc6a59697b3a6a2f6c54bf81d260beb5852/appengine/findit/waterfall/flake/test/trigger_flake_swarming_task_service_pipeline_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5

commit c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5
Author: Chan <chanli@chromium.org>
Date: Thu Mar 08 20:41:14 2018

[Findit] Refactor waterfall/swarming_util.py (1/4)

Extract shared logic of sending http requests among services (swarming, isolate, test_results).

Bug:  805732 
Change-Id: I9a070b529e0d4b6ae11f9cd3e085011c6e081140
Reviewed-on: https://chromium-review.googlesource.com/941991
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/services/swarmbot_util.py
[modify] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
[add] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/common/http_client_util.py
[modify] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/services/test/swarmbot_util_test.py
[add] https://crrev.com/c7e44dcb31a3927fc2c36ba8ed2df508a2754dd5/appengine/findit/common/test/http_client_util_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/71dbdc931685b5c250f0588f8a4a8d4e6242621f

commit 71dbdc931685b5c250f0588f8a4a8d4e6242621f
Author: Chan <chanli@chromium.org>
Date: Fri Mar 09 22:23:24 2018

[Findit] Refactor waterfall/swarming_util.py (2/4)

Refactor out swarming related logic.

infra_api_clients/swarming_util.py has util logic to communicate with swarm server.
services/swarming.py has Special business logic for Findit about swarming tasks.


Bug:  805732 
Change-Id: Ic4b2b7bb43e3451022f31dd3bd6c2dbe4e53aff5
Reviewed-on: https://chromium-review.googlesource.com/941560
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/test/trigger_base_swarming_task_pipeline_test.py
[rename] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/test/http_client_util_test.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/swarming_util.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/test/gtest_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/constants.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/test/swarming_test.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/test/swarming_bot_counts_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/test/swarmbot_util_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/flake/step_mapper.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/flake_failure/run_swarming_util.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/test/build_util_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/test_failure/test/ci_test_failure_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/build_util.py
[delete] https://crrev.com/b74411c6b2a6dd66cc0648e6ead794ceaee8e5ab/appengine/findit/services/test_results_constants.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/swarming_util.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/test/swarming_util_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/swarmbot_util.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/test/swarming_task_data_test.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/swarming_bot_counts.py
[rename] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/swarming_task_request.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/flake_failure/test/run_swarming_util_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/test_failure/extract_test_signal.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/test_results.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/flake/test/step_mapper_test.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/swarming.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/test/__init__.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
[rename] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/http_client_util.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/__init__.py
[rename] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/test/swarming_task_request_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/services/gtest.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py
[add] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/infra_api_clients/swarming/swarming_task_data.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/flake/test/flake_analysis_util_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/71dbdc931685b5c250f0588f8a4a8d4e6242621f/appengine/findit/waterfall/flake/flake_analysis_util.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/77240d86cee9c0f9cf193a04758e11b7eb359d12

commit 77240d86cee9c0f9cf193a04758e11b7eb359d12
Author: Chan <chanli@chromium.org>
Date: Tue Mar 13 00:27:00 2018

[Findit] Refactor waterfall/swarming_util.py (3/4)

Refactor out isolate related logic.

infra_api_clients/isolate_util.py has util logic to download files from isolate server.

Bug:  805732 
Change-Id: I1c2291bf11145b488ad625a5f247c307922b2a2a
Reviewed-on: https://chromium-review.googlesource.com/942381
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/waterfall/swarming_util.py
[add] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/services/isolate.py
[add] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/infra_api_clients/isolate/test/__init__.py
[modify] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/services/test_results.py
[add] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/services/test/isolate_test.py
[modify] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/services/test/test_results_test.py
[add] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/infra_api_clients/isolate/__init__.py
[modify] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/libs/cache_decorator.py
[add] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/infra_api_clients/isolate/test/isolate_util_test.py
[add] https://crrev.com/77240d86cee9c0f9cf193a04758e11b7eb359d12/appengine/findit/infra_api_clients/isolate/isolate_util.py

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/54a149ffa9dafc83558f302ac70dcfa92d7fdc73

commit 54a149ffa9dafc83558f302ac70dcfa92d7fdc73
Author: Chan <chanli@chromium.org>
Date: Tue Mar 13 21:32:53 2018

[Findit] Refactor waterfall/swarming_util.py (4/4)

Move logic that uses multiple services to a separated service module and remove the residue of waterfall/swarming_util.py

Bug:  805732 
Change-Id: Iac9b91512374e0b47157f1dcb3578134a9ae4c6f
Reviewed-on: https://chromium-review.googlesource.com/942372
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[delete] https://crrev.com/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759/appengine/findit/waterfall/test/data/shard1
[delete] https://crrev.com/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759/appengine/findit/waterfall/test/data/shard1_url
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/flake/test/step_mapper_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
[delete] https://crrev.com/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759/appengine/findit/waterfall/test/data/shard1_isolated
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/flake/initialize_flake_try_job_pipeline.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/flake/step_mapper.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/try_job.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[delete] https://crrev.com/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py
[delete] https://crrev.com/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759/appengine/findit/waterfall/swarming_util.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/flake/determine_true_pass_rate_pipeline.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test/test_results_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test/gtest_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test_failure/extract_test_signal.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test_failure/test/ci_test_failure_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test_results.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/swarmed_test_util.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test/swarmed_test_util_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/flake_failure/flake_try_job.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/flake_failure/test/flake_try_job_test.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/gtest.py
[modify] https://crrev.com/54a149ffa9dafc83558f302ac70dcfa92d7fdc73/appengine/findit/services/test_failure/test/extract_test_signal_test.py

Comment 7 by chanli@chromium.org, Mar 16 2018

Status: Fixed (was: Started)

Sign in to add a comment