New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805730 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 808697
issue 805732
issue 808695
issue 808699



Sign in to add a comment

Meta bug to track remaining refactor work in Q1 2018

Project Member Reported by chanli@chromium.org, Jan 25 2018

Issue description

This is the meta bug to track remaining refactor work in Q1 2018.
 

Comment 1 by chanli@chromium.org, Jan 25 2018

Blockedon: 805732
Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Updated wrong bug, reopen.
Blockedon: 808695
Blockedon: 808697
Blockedon: 808699
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2018

Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2b8cc502a6b9fdab8923da46df5e8b7de06128b3

commit 2b8cc502a6b9fdab8923da46df5e8b7de06128b3
Author: Chan <chanli@chromium.org>
Date: Thu May 03 22:04:57 2018

[Findit] Remove the old pubsub code for try jobs.

Also prevent the old flake analyzer pipeline to trigger try jobs.
Also fix a bug and add unittests for test_try_job

Bug: 805730
Change-Id: I601787e5ebb8b2d8106ed7cfa5e32f009f06ffdc
Reviewed-on: https://chromium-review.googlesource.com/1036732
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[delete] https://crrev.com/34514117ea2ecb9c339eefbde079a3616282b12e/appengine/findit/handlers/test/try_job_push_test.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/services/test/try_job_test.py
[delete] https://crrev.com/34514117ea2ecb9c339eefbde079a3616282b12e/appengine/findit/handlers/try_job_push.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/common/waterfall/test/pubsub_callback_test.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/main.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/services/try_job.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/waterfall/flake/test/schedule_flake_try_job_pipeline_test.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/common/waterfall/pubsub_callback.py
[modify] https://crrev.com/2b8cc502a6b9fdab8923da46df5e8b7de06128b3/appengine/findit/services/test_failure/test_try_job.py

Project Member

Comment 10 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78

commit a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78
Author: Chan <chanli@chromium.org>
Date: Tue May 08 16:53:56 2018

[Findit] Remove deprecated code for swarming pubsub.

Also removed old base swarming pipelines and simplified swarming pipelines for flakes to the minimum to keep them from being in the way for other refactoring work.

Bug: 805730
Change-Id: I3a7a14b221fa4ecda2145fc18be8d99126eb252a
Reviewed-on: https://chromium-review.googlesource.com/1045494
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/services/swarming.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/handlers/test/periodic_bot_update_test.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/handlers/swarming_push.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/common/waterfall/test/pubsub_callback_test.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/handlers/flake/check_flake.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/main.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/services/test/swarming_test.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/services/test_failure/test_swarming.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/handlers/test/swarming_push_test.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/services/test_failure/test/test_swarming_test.py
[delete] https://crrev.com/6f04f191bf622ae6319af9038d9988efb5fbbf04/appengine/findit/common/waterfall/pubsub_callback.py
[modify] https://crrev.com/a2b6c83bf67461314dfd9cb6e4a9dea6e7510e78/appengine/findit/services/flake_failure/flake_swarming.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4d1a04d2036cd980f537c32b131920068e20dd29

commit 4d1a04d2036cd980f537c32b131920068e20dd29
Author: Chan <chanli@chromium.org>
Date: Wed Jun 06 19:39:26 2018

[Findit] Remove deprecated monitor_try_job_pipeline

Bug: 805730
Change-Id: Ib1c26506eb18cd5dc235abb930a684f30385d6c6
Reviewed-on: https://chromium-review.googlesource.com/1088164
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[delete] https://crrev.com/1742a752ffa122c9b214bc74073aaa63deb6e837/appengine/findit/waterfall/monitor_try_job_pipeline.py
[delete] https://crrev.com/1742a752ffa122c9b214bc74073aaa63deb6e837/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 7 2018

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cb91234801a09a91ed54acf1506190c0d7466c99

commit cb91234801a09a91ed54acf1506190c0d7466c99
Author: Chan <chanli@chromium.org>
Date: Thu Jul 12 23:22:02 2018

[Findit] Move logic of updating culprit entities to culprit_action.py

Bug: 805730
Change-Id: I41aad8fe8a0f2af46cb15e95e1f5622900908fba
Reviewed-on: https://chromium-review.googlesource.com/1115973
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/irc.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/waterfall/test/send_notification_to_irc_pipeline_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/flake_failure/culprit_util.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/gerrit.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/submit_revert_cl_pipeline.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/test/create_revert_cl_pipeline_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/constants.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/culprit_action.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/flake_failure/test/culprit_util_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/test/irc_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/test/submit_revert_cl_pipeline_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/services/test/culprit_action_test.py
[modify] https://crrev.com/cb91234801a09a91ed54acf1506190c0d7466c99/appengine/findit/pipelines/test/send_notification_for_culprit_pipeline_test.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1c93c777a05150e4abb4dde54c7f0cd3aab376e3

commit 1c93c777a05150e4abb4dde54c7f0cd3aab376e3
Author: Chan <chanli@chromium.org>
Date: Tue Jul 31 00:53:11 2018

[Findit] Refactor: move the logic of correlate suspected_cls with failures to _failure_analysis modules.

Bug: 805730
Change-Id: Ifb5b56bb96d5050bbced484a74a72bdf70840634
Reviewed-on: https://chromium-review.googlesource.com/1147084
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/compile_failure/compile_failure_analysis.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/parameters.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/compile_failure/test/compile_failure_analysis_test.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/try_job.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/1c93c777a05150e4abb4dde54c7f0cd3aab376e3/appengine/findit/services/test_failure/test_try_job.py

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3356b0c9f97af46799fee0ee04ebb98ac211040c

commit 3356b0c9f97af46799fee0ee04ebb98ac211040c
Author: Chan <chanli@chromium.org>
Date: Fri Sep 21 00:58:41 2018

[Findit] Refactor: Move logic related to step logs to step_util.py

We had functions in waterfall/build_util.py and searvices/ci_failures about getting one step log or some information from a step log.

Move those functions to services/step_util.py

Bug: 805730
Change-Id: Ic8616aca80fb9eab3c9e9be68a4c343cf0cc244d
Reviewed-on: https://chromium-review.googlesource.com/1232893
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17782}
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/compile_failure/extract_compile_signal.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/waterfall/flake/test/step_mapper_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test/ci_failure_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/compile_failure/test/extract_compile_signal_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/waterfall/flake/step_mapper.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/extract_signal.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/model/flake/flake.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/waterfall/test/build_util_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/waterfall/build_util.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test/step_util_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/pipelines/trigger_flake_analyses_pipeline.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/pipelines/test/trigger_flake_analyses_pipeline_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/model/flake/test/flake_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test_failure/test_swarming.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/try_job.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test_failure/test/test_swarming_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/step_util.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/ci_failure.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test/extract_signal_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test_failure/test/extract_test_signal_test.py
[modify] https://crrev.com/3356b0c9f97af46799fee0ee04ebb98ac211040c/appengine/findit/services/test_failure/test/test_failure_analysis_test.py

Sign in to add a comment