update_lab_tools error message poor |
||||
Issue description
Calling update_lab_tools doesn't recognize the existence of a lab tools installation. (On Trusty, at least.)
Log, just after finishing a call of setup_lab_tools /usr/local/bin:
jkop@jkop:~/shadow_cros/chromeos-admin/lab-tools$ ./update_lab_tools
update_lab_tools: use 'setup_lab_tools' for initial installation
usage: update_lab_tools [ <options> ]
Update the *already installed* lab tools.
OPTIONS:
-h Show this message and exit.
-t "test" mode. Do not 'repo sync' away local changes.
jkop@jkop:~/shadow_cros/chromeos-admin/lab-tools$
,
Jan 24 2018
I had already had them installed for a while, and used them. I tried update_lab_tools, failed, and ran setup_lab_tools (as a test for something else). Then I ran update_lab_tools again. Same result.
,
Jan 25 2018
This is actually WAI, although looking at it, it seems that the
error message is substantially deficient.
From the script:
if [[ ! -L "$0" ]]; then
echo "${COMMAND}: use 'setup_lab_tools' for initial installation" >&2
usage
exit 1
fi
The script is meant to be run from its installed location, not from
inside the repo. The reason is that it's not easy to know if the
current directory is the location of the currently installed lab
tools, or some other location, or if the lab tools are even already
installed.
,
Jan 25 2018
,
Jan 25 2018
,
Jan 25 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/1841f83f1f4074ac6dd08f3ab06c642b109d5c93 commit 1841f83f1f4074ac6dd08f3ab06c642b109d5c93 Author: Richard Barnette <jrbarnette@google.com> Date: Thu Jan 25 01:24:08 2018
,
Jan 25 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ayatane@chromium.org
, Jan 24 2018