New issue
Advanced search Search tips

Issue 805704 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extension warnings shown through WarningService and WarningBadgeService need work

Project Member Reported by rdevlin....@chromium.org, Jan 24 2018

Issue description

We have a WarningService and WarningBadgeService that display extension warnings for different circumstances.  The strings for these warnings are here:

https://chromium.googlesource.com/chromium/src/+/0366708ab215ba3c1f792371eb14abad4f66bc61/extensions/strings/extensions_strings.grd#322
(through line 346)

Inlined here for ease:

-----------

This extension is slowing down <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph>. You should disable it to restore <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph>'s performance.

This extension failed to modify a network request because the modification conflicted with another extension.

This extension failed to redirect a network request to <ph name="ATTEMPTED_REDIRECT_DESTINATION">$1<ex>http://www.google.com</ex></ph> because another extension (<ph name="EXTENSION_NAME">$2<ex>My Cool Extension</ex></ph>) redirected it to <ph name="ACTUAL_REDIRECT_DESTINATION">$3<ex>https://www.google.com</ex></ph>.

This extension failed to modify the request header "<ph name="HEADER_NAME">$1<ex>User-Agent</ex></ph>" of a network request because the modification conflicted with another extension (<ph name="EXTENSION_NAME">$2<ex>My Cool Extension</ex></ph>).

This extension failed to modify the response header "<ph name="HEADER_NAME">$1<ex>User-Agents</ex></ph>" of a network request because the modification conflicted with another extension (<ph name="EXTENSION_NAME">$2<ex>My Cool Extension</ex></ph>).

This extension failed to provide credentials to a network request because another extension (<ph name="EXTENSION_NAME">$1<ex>My Cool Extension</ex></ph>) provided different credentials.

This extension failed to name the download "<ph name="ATTEMPTED_FILENAME">$1<ex>apple.png</ex></ph>" because another extension (<ph name="EXTENSION_NAME">$2<ex>My Cool Extension</ex></ph>) determined a different filename "<ph name="ACTUAL_FILENAME">$3<ex>banana.png</ex></ph>".

This extension reloaded itself too frequently.

-----------

The UI for the error also leaves a lot to be desired.  It just adds a global error to Chrome (i.e., an item in the Chrome menu - see screenshot) that says "Extension error" and then takes the user to the chrome://extensions page (where they can see the full warning text*).

*modulo  bug 800773 

I think this UI needs some work.  For one thing, I'd like to be a little more actionable and specific in the global error - "Extension error" is very unhelpful to users.  For another, I think a lot of these are pretty inactionable by users.  (My favorite might be "This extension failed to modify a network request because the modification conflicted with another extension." - what's a user to do in that case?  We don't even say which extension it conflicted with.)

Assigning to bklmn@, who's thinking about extension UIs in general, and also +srahim@ for strings help and jawag@.
 
Menu_425.png
17.4 KB View Download

Sign in to add a comment