Extension cards don't update in MD Extensions and reset on search |
||||||
Issue descriptionChrome Version: 64.0.3282.101 OS: Chrome Extension cards don't necessarily reflect the current state of the extension. 0. Launch Chrome with --enable-features=MaterialDesignExtensions 1. Have a bunch of extensions 2. Visit chrome://extensions 3. Find an extension in the main page, let's say AwesomeExtension 4. Disable AwesomeExtension 5. Search for AwesomeExtension in the page's toolbar Expected: AwesomeExtension appears disabled Actual: AwesomeExtension appears enabled 6. Clear the search and look for the extension in the main page again Expected: AwesomeExtension appears disabled Actual: AwesomeExtension appears enabled In addition, if the page is in developer mode, the "Inspect views" label and links remain present after disabling the extension (even before filtering with Search). Finally: disabling Developer Mode doesn't remove the "Inspect views" labels and links from extension cards, it only seems to hide the extra toolbar row. Couldn't reproduce on ToT, but it's happening on my machine. Might be related to the number of extensions installed, as my machine has dozens and my ToT testing was done with a new profile. Or it was already fixed (but I didn't see any recent commits that seemed relevant from a quick search).
,
Jan 24 2018
@michaelpg: Can you reproduce on ToT? I was not able to.
,
Jan 24 2018
Oh I see you already mentioned you could not, never mind.
,
Jan 24 2018
@michaelpg: Could you check if there are any errors in your devtools? Sounds likely given the behavior you are seeing.
,
Jan 24 2018
No, the only error was a renderer-not-found error after clicking on an inspect link for a frame in a disabled extension, which is expected.
,
Jan 24 2018
I signed in to another account (with multiprofile, so it's the same session) -- and I can't reproduce in the other account. Perhaps it's related to enterprise enrollment, since it's my @google.com account that has the problem? Or just something to do with the particular apps and extensions I have?
,
Jan 24 2018
Also: Removing an extension from the main page doesn't result in the extension card being removed, even without any of the filtering steps. So the UI is more broken than I initially thought, definitely worth figuring out how to repro.
,
Jan 24 2018
(unassigning myself in case someone else can get to this sooner)
,
Jan 24 2018
@michaelpg: This bug is not very actionable without a repro. My understanding is that 1) you were able to repro only on M64 with your corp account. 2) you did not try M65 with corp account. 3) you did try M65 with other accounts and was not able to repro. 4) Did you try M64 with other accounts? > Removing an extension from the main page doesn't result in the extension card being removed Does any of the symptoms happen without the MD Extensions flag. Asknig just to rule out the possibility of the extensions backend mis-behaving on that profile.
,
Jan 24 2018
It might not be a UI issue. A listener for chrome.developerPrivate.onProfileStateChanged is not getting fired even though toggling developer mode does actually take effect. I can check for other events or APIs if there's something that would be helpful to look for.
I tried this in chrome://extensions from my corp account:
chrome.developerPrivate.onProfileStateChanged.addListener(
console.log.bind(console))
and toggling dev mode doesn't trigger any logging. It does trigger the expected event when using my non-corp account.
#9: Correct. I tried on M64 with a non-corp account and couldn't repro. I'm in Australia so not keen to test this out over Remote Desktop in different configurations, and can't do anything on-device beyond what I can do with my corp-enrolled Chromebook.
,
Jan 25 2018
Not happening after a reboot. I'll look out for it to happen again.
,
Jan 25 2018
Given this happened intermittently on only a single profile/machine, I'm tentatively lowering priority and removing it as a blocker for enabling on ToT. Michael, if you see this again, please do bump priority back up! :)
,
Feb 7 2018
Lack of repro, only happened once. Please reopen if needed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by michae...@chromium.org
, Jan 24 2018