New issue
Advanced search Search tips

Issue 805698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 805149



Sign in to add a comment

Collections: Add support for timestamp

Project Member Reported by sczs@chromium.org, Jan 24 2018

Issue description

Bottom text might have a timestamp
 

Comment 1 by sczs@chromium.org, Mar 13 2018

NextAction: 2018-03-20
Status: Started (was: Assigned)

Comment 2 by cmasso@google.com, Mar 15 2018

NextAction: 2018-03-28
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db28cd76143af87ec2e2d3878548926885637827

commit db28cd76143af87ec2e2d3878548926885637827
Author: sczs <sczs@chromium.org>
Date: Thu Mar 15 19:32:29 2018

[ios] Adds subtitle timestamp to Recent Tabs session headers.

- Adds a subtitle label to table_view_text_header_footer_item
- Sets this label as a timpestamp for RecentTabs sessions headers.

Screenshot:
https://drive.google.com/open?id=1yamLSxBoFXm0la14ZLVxsEqMMcbFu6BC

Bug:  805698 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2318b02df397d603285034a642fd75c7efb20953
Reviewed-on: https://chromium-review.googlesource.com/963674
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543472}
[modify] https://crrev.com/db28cd76143af87ec2e2d3878548926885637827/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/db28cd76143af87ec2e2d3878548926885637827/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.h
[modify] https://crrev.com/db28cd76143af87ec2e2d3878548926885637827/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.mm

Comment 4 by sczs@chromium.org, Mar 15 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-28

Sign in to add a comment