Modern Media Controls: Everything is in the overflow menu when Chrome first opened on Android |
|||
Issue descriptionRepro steps: 1) On Android, enable the UseModernMediaControls flag. 2) Go to m.youtube.com and go to a video. 3) Close Chrome. 4) Reopen Chrome (which still has the video tab open). 5) Tap on the video to play. Expected Result: Controls look normal Actual Result: Everything is in the overflow menu
,
Jan 25 2018
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdbfdc276f4734d1c17926303620d758480c48ff commit fdbfdc276f4734d1c17926303620d758480c48ff Author: Tommy Steimel <steimel@chromium.org> Date: Tue Jan 30 16:05:22 2018 Use correct size when calculating overflow menu for new media controls This CL makes use of the size_ member of the MediaControlsImpl when updating the overflow menu for modern media controls. This fixes a bug where a video of normal size will have all controls in the overflow menu because it thinks the size is 0x0. Bug: 805690 Change-Id: I11dc8f991696d4771f517d6cca585b3e293bb57a Reviewed-on: https://chromium-review.googlesource.com/886656 Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532897} [modify] https://crrev.com/fdbfdc276f4734d1c17926303620d758480c48ff/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
,
Jan 30 2018
,
Feb 1 2018
looks good, thanks
,
Feb 1 2018
Verified fix with latest Chrome app on Android One(M) |
|||
►
Sign in to add a comment |
|||
Comment 1 by steimel@chromium.org
, Jan 24 2018