-[Tab wasHidden] is called when tab is called in Tab switcher |
|||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): ToT iOS Version: All Device: All Steps to reproduce: 1.) Open a Tab 2.) Tap on Tab Switcher icon 3.) Close that Tab Observed behavior: -[Tab wasHidden] is called on step 2 and 3. Expected behavior: -[Tab wasHidden] should only be called on step 2.
,
Mar 27 2018
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08e6dbe85a31d9283d6f2829535f02fac124a7c4 commit 08e6dbe85a31d9283d6f2829535f02fac124a7c4 Author: Eugene But <eugenebut@google.com> Date: Wed Mar 28 17:03:14 2018 Prevent extra WasShow/WasHidden WebStateObserver callbacks. Extra WasShow callback made DownloadManagerCoordinator to present extra DownloadManagerViewController. Closing second controlled caused a crash. Bug: 805653 ,824758 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4697c7599e1870ebe20248cf3193e764d061202d Reviewed-on: https://chromium-review.googlesource.com/982511 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#546530} [modify] https://crrev.com/08e6dbe85a31d9283d6f2829535f02fac124a7c4/ios/chrome/browser/ui/download/download_manager_coordinator.mm [modify] https://crrev.com/08e6dbe85a31d9283d6f2829535f02fac124a7c4/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/08e6dbe85a31d9283d6f2829535f02fac124a7c4/ios/web/web_state/web_state_impl_unittest.mm
,
Mar 28 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by huangml@chromium.org
, Jan 25 2018Status: Assigned (was: Untriaged)