New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805645 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

New Tab Page: Retheme fully scrolled fake omnibox

Project Member Reported by justincohen@chromium.org, Jan 24 2018

Issue description

Retheme fully scrolled fake omnibox
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75

commit 5edde00d098bc0d30e832a2dc9bbf6e928bb4b75
Author: Justin Cohen <justincohen@google.com>
Date: Tue Mar 06 16:49:10 2018

[ios] Update layout for NTP header view.

- Makes the search hint label shrink on scroll progress.
- Updates locations for doodle and fakebox.
- Updates fonts and colors for fakebox and most visited.

Bug:  805645 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0c865f454370c7b73e51fa3efa21d13a06b04f3b
Reviewed-on: https://chromium-review.googlesource.com/943981
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541124}
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_cell.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_constants.h
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_constants.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/resources/BUILD.gn
[add] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/resources/ntp_search_icon.imageset/Contents.json
[add] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/resources/ntp_search_icon.imageset/ntp_search_icon.png
[add] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/resources/ntp_search_icon.imageset/ntp_search_icon@2x.png
[add] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/content_suggestions/resources/ntp_search_icon.imageset/ntp_search_icon@3x.png
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.h
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/ntp/new_tab_page_header_constants.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/ntp/ntp_header_view_adapter.h
[modify] https://crrev.com/5edde00d098bc0d30e832a2dc9bbf6e928bb4b75/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm

Status: Assigned (was: Started)
Back to assigned, this now depends on the location bar theme updates.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fa33db85ec93a61e1d64ea95296742e86ee418d

commit 6fa33db85ec93a61e1d64ea95296742e86ee418d
Author: Justin Cohen <justincohen@google.com>
Date: Mon Mar 12 16:49:54 2018

[ios] Revert new doodle height changes.

Per feedback from dev and design, this makes the doodle too small.  Ignoring
new spec and reverting to old spec.

Bug:  805645 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic8b01e028ef504f4d03760e67d89808fe95ed9f4
Reviewed-on: https://chromium-review.googlesource.com/957916
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542509}
[modify] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm

Status: Fixed (was: Assigned)

Sign in to add a comment