New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

New Tab Page: Retheme toolbar for phone regular size class

Project Member Reported by justincohen@chromium.org, Jan 24 2018

Issue description

Integrate new top adapative toolbar as fake toolbar on ntp.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf903c2d2886b3ecc72bbfa9773492087502e3d0

commit cf903c2d2886b3ecc72bbfa9773492087502e3d0
Author: Justin Cohen <justincohen@google.com>
Date: Fri Feb 02 15:43:29 2018

[ios] Use adapative primary toolbar in phone NTP.

Instead of using the old NewTabPageHeaderView and NewTabPageToolbarController,
use a new ContentSuggestionsHeaderView and embed a PrimaryToolbarViewController.

Creates a temporary NTPHeaderViewAdapter protocol allow the NTP UI to switch
back and forth between each header view.

Bug:  805640 ,  805639 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifb2be48ae38528543b2f8b9a108eec0453e9ddbf
Reviewed-on: https://chromium-review.googlesource.com/894147
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534058}
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[add] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.h
[add] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.h
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h
[add] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/ntp/ntp_header_view_adapter.h
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/cf903c2d2886b3ecc72bbfa9773492087502e3d0/ios/chrome/browser/ui/util/named_guide.mm

Status: Fixed (was: Started)

Sign in to add a comment