New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805636 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

New Tab Page: Update ui for most visited

Project Member Reported by justincohen@chromium.org, Jan 24 2018

Issue description

grey rounded background, small favicons, updated fonts and colors
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a99a5ff597a5c3b63f1b68ba14518c6c602adc43

commit a99a5ff597a5c3b63f1b68ba14518c6c602adc43
Author: Justin Cohen <justincohen@google.com>
Date: Wed Feb 21 16:23:30 2018

[ios] Add mock fakebox images and sizes.

While waiting for final spec, add temporary fakebox views and scroll widths.

Bug:  805636 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iecd3ea922cdde2ceb8f047298e11bb3e03520775
Reviewed-on: https://chromium-review.googlesource.com/927162
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538126}
[modify] https://crrev.com/a99a5ff597a5c3b63f1b68ba14518c6c602adc43/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/a99a5ff597a5c3b63f1b68ba14518c6c602adc43/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d

commit 7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d
Author: Justin Cohen <justincohen@google.com>
Date: Wed Feb 28 13:41:05 2018

[ios] Update most visited tile style for refresh.

Adds new tile background image and reading list circle.

Bug:  805636 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I46dfca56ea4ebdb682ee688aa5b1b8aa88bf4f73
Reviewed-on: https://chromium-review.googlesource.com/936084
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539813}
[modify] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[add] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_cell.h
[add] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_cell.mm
[modify] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.h
[modify] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.mm
[modify] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
[add] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_constants.h
[add] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_constants.mm
[modify] https://crrev.com/7a78a7bc5fc3dba0ddfd11c045627ca80f05db7d/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb2392d5a2163822acf9ec662719f1b5b5b0caba

commit fb2392d5a2163822acf9ec662719f1b5b5b0caba
Author: Justin Cohen <justincohen@google.com>
Date: Mon Mar 12 16:33:22 2018

[ios] Tighten up most visited spacing for ui refresh.

Bug:  805636 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I38c1003c7bf4935bbc1071efad166fb113ba471b
Reviewed-on: https://chromium-review.googlesource.com/957915
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542504}
[modify] https://crrev.com/fb2392d5a2163822acf9ec662719f1b5b5b0caba/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
[modify] https://crrev.com/fb2392d5a2163822acf9ec662719f1b5b5b0caba/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/fb2392d5a2163822acf9ec662719f1b5b5b0caba/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment