New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 805635 link

Starred by 2 users
Status: Fixed
Owner:
justincohen@chromium.org
Closed: Mar 2018
Cc:
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

New Tab Page: Replace last 4 most visited with static button

Project Member Reported by justincohen@chromium.org, Jan 24 2018 
Add bookmarks, reading list, recent tabs, history

reading list should include count

add click metrics for 4 new buttons, plus make sure there are corresponding metrics for ntp based bookmarks / open tabs for comparison.

Comment 1 by justincohen@chromium.org, Jan 24 2018

Summary: New Tab Page: Replace last 4 most visited with static button (was: New Tab Page: Replace last 4 most visited with static buttons medium)

Comment 2 by justincohen@chromium.org, Feb 14 2018

NextAction: 2018-02-28
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d

commit c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d
Author: Justin Cohen <justincohen@google.com>
Date: Thu Feb 15 18:03:32 2018

[ios] Wire up NTP most visited action items.

Reduces the NTP most visited list to 4 URL buttons, and adds 4 action buttons
that correspond to bookmarks, reading list, recent tabs and history.  The theme
updates are for a future CL, but this does enforce a 4-across view, even for
small device views.

Bug:  805635 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I41693fedee1a963d392d3e2bb53bb9125c9d4adb
Reviewed-on: https://chromium-review.googlesource.com/917004
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537066}
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[add] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.h
[add] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.mm
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/mediator_util.h
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/mediator_util.mm
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.h
[modify] https://crrev.com/c2e2e0dfac7c8155ce6d77afc295f9fa4e75c99d/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm

Comment 4 by justincohen@chromium.org, Feb 23 2018

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97d07a7851d3738f115778a34641bcbb336810e

commit e97d07a7851d3738f115778a34641bcbb336810e
Author: Justin Cohen <justincohen@google.com>
Date: Fri Feb 23 18:52:00 2018

[ios] Add new most visited action icons.

Bug:  805635 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I151911fab9a5e9e53531f52453b6c481fe901eaa
Reviewed-on: https://chromium-review.googlesource.com/934586
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538837}
[modify] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[modify] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.mm
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/BUILD.gn
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_bookmarks_icon.imageset/Contents.json
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_bookmarks_icon.imageset/ntp_bookmarks_icon.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_bookmarks_icon.imageset/ntp_bookmarks_icon@2x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_bookmarks_icon.imageset/ntp_bookmarks_icon@3x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_history_icon.imageset/Contents.json
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_history_icon.imageset/ntp_history_icon.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_history_icon.imageset/ntp_history_icon@2x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_history_icon.imageset/ntp_history_icon@3x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_most_visited_tile.imageset/Contents.json
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_most_visited_tile.imageset/ntp_most_visited_tile.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_most_visited_tile.imageset/ntp_most_visited_tile@2x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_most_visited_tile.imageset/ntp_most_visited_tile@3x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_readinglist_icon.imageset/Contents.json
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_readinglist_icon.imageset/ntp_readinglist_icon.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_readinglist_icon.imageset/ntp_readinglist_icon@2x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_readinglist_icon.imageset/ntp_readinglist_icon@3x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_recent_icon.imageset/Contents.json
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_recent_icon.imageset/ntp_recent_icon.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_recent_icon.imageset/ntp_recent_icon@2x.png
[add] https://crrev.com/e97d07a7851d3738f115778a34641bcbb336810e/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_recent_icon.imageset/ntp_recent_icon@3x.png

Comment 6 by monor...@bugs.chromium.org, Feb 28 2018 

The NextAction date has arrived: 2018-02-28

Comment 7 by cmasso@google.com, Feb 28 2018

NextAction: 2018-03-14

Comment 8 by justincohen@chromium.org, Mar 1 2018

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d3a59bd6a41cb192be7ff0a866343173a190b25

commit 2d3a59bd6a41cb192be7ff0a866343173a190b25
Author: Justin Cohen <justincohen@google.com>
Date: Thu Mar 01 22:57:44 2018

Add metrics to most visited action items.

Also restores missing metric on pre-ui-refresh NTP, and adds action items to
first user action recorder.

Bug:  805635 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I75581d1e7fbee2b80fc7cbbea3ac82f4e5dbb64f
Reviewed-on: https://chromium-review.googlesource.com/941361
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540325}
[modify] https://crrev.com/2d3a59bd6a41cb192be7ff0a866343173a190b25/ios/chrome/browser/metrics/first_user_action_recorder.cc
[modify] https://crrev.com/2d3a59bd6a41cb192be7ff0a866343173a190b25/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm
[modify] https://crrev.com/2d3a59bd6a41cb192be7ff0a866343173a190b25/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/2d3a59bd6a41cb192be7ff0a866343173a190b25/tools/metrics/actions/actions.xml

Comment 10 by monor...@bugs.chromium.org, Mar 14 2018 

The NextAction date has arrived: 2018-03-14

Comment 11 by cmasso@google.com, Mar 14 2018

NextAction: ----
►

Sign in to add a comment