ExternalProviderImplChromeOSTest.PriorityCompleted in unit_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of joedow@google.com ExternalProviderImplChromeOSTest.PriorityCompleted in unit_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
,
Jan 24 2018
The failures seem to be related to ImageSanitizer so I suspect this CL is related. I'm not confident enough to back the change out though so I'm assigning for follow-up / confirmation. We've seen this flake a few times so we can disable the test if it occurs too frequently (and we don't have a fix identified).
,
Jan 24 2018
Adding the suspected CL :P https://chromium-review.googlesource.com/c/chromium/src/+/870744
,
Jan 24 2018
I started looking into it. It's flaky because that test waits for one extension to be installed when 2 are. If it exits before the 2nd extension has finished installing the ImageSanitizer is still around. I'll see if I can change the test to ensure if waits for both extension install.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8323f73440723532ffd64876634a51f44c95442 commit e8323f73440723532ffd64876634a51f44c95442 Author: Jay Civelli <jcivelli@google.com> Date: Wed Jan 24 23:01:25 2018 Fix memory leak in ExternalProviderImplChromeOSTest. My recent CL https://chromium-review.googlesource.com/c/chromium/src/+/870744 caused a leak in ExternalProviderImplChromeOSTest as the test shuts down with some extension installation pending. Make sure we wait for all extensions to be installed before we exit the test. Bug: 805591 Change-Id: I89c1187d9e32ce0ab859689286c6283b0316d602 Reviewed-on: https://chromium-review.googlesource.com/884270 Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#531731} [modify] https://crrev.com/e8323f73440723532ffd64876634a51f44c95442/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc
,
Jan 24 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by joedow@chromium.org
, Jan 24 2018