make sure we set up HitTestAggregator correctly in non-viz |
|||||
Issue descriptionCurrently, HitTestAggregator is owned by RootCompositorFrameSinkImpl, which would only work for the viz display compositor (OOP-D) case. In non-viz, we use DirectLayerTreeFrameSink, and it calls to create a CompositorFrameSinkSupport with |is_root| equal to true through HostFrameSinkManager. HitTestAggregator should be owned by root CompositorFrameSinkSupport.
,
Feb 6 2018
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb45434b309793c6aa7dafacc207b2239ccb7323 commit eb45434b309793c6aa7dafacc207b2239ccb7323 Author: Ria Jiang <riajiang@chromium.org> Date: Tue Feb 06 20:18:45 2018 Pass use_viz_hit_test to DirectLayerTreeFrameSink and set up hit-test. Pass in features::IsVizHitTestingEnabled() value when creating a DirectLayerTreeFrameSink and set up Viz hit-test in DLTFS when it is enabled. Bug: 805581 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iec2e2c81444fda85a5d1f99824527360ae22ac5c Reviewed-on: https://chromium-review.googlesource.com/901945 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#534771} [modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc [modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h [modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc [modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/ui/compositor/test/in_process_context_factory.cc
,
Feb 6 2018
,
Feb 6 2018
,
Feb 7 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 2 2018