New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805581 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 672311
issue 810128



Sign in to add a comment

make sure we set up HitTestAggregator correctly in non-viz

Project Member Reported by riajiang@chromium.org, Jan 24 2018

Issue description

Currently, HitTestAggregator is owned by RootCompositorFrameSinkImpl,
which would only work for the viz display compositor (OOP-D) case. In
non-viz, we use DirectLayerTreeFrameSink, and it calls to create a
CompositorFrameSinkSupport with |is_root| equal to true through
HostFrameSinkManager. HitTestAggregator should be owned by root CompositorFrameSinkSupport.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5685d4cddd5a7e36bb837a483169a88971163208

commit 5685d4cddd5a7e36bb837a483169a88971163208
Author: Ria Jiang <riajiang@chromium.org>
Date: Fri Feb 02 23:00:20 2018

Change HitTestAggregator to be owned by root CFSSupport.

Currently, HitTestAggregator is owned by RootCompositorFrameSinkImpl,
which would only work for the viz display compositor (OOP-D) case. In
non-viz, we use DirectLayerTreeFrameSink, and it calls to create a
CompositorFrameSinkSupport with |is_root| equal to true through
HostFrameSinkManager.

1. This changes CompositorFrameSinkSupport to own the HitTestAggregator
when it is a root CFSS, and pass its FrameSinkId to the HTA.
2. Change FrameSinkManagerImpl to be a HitTestAggregatorDelegate.
3. Update DirectLayerTreeFrameSink to activate HitTestAggregator::
Aggregate().

Bug:  805581 
Test: viz_unittests
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0d3d93405dc99e7a5a6edb8f0587c5d0d24ffad7
Reviewed-on: https://chromium-review.googlesource.com/884324
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534186}
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/host/host_frame_sink_manager_unittest.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/hit_test/hit_test_aggregator_delegate.h
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/ui/message_center/BUILD.gn
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/ui/message_center/test/run_all_unittests.cc
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/ui/views/BUILD.gn
[modify] https://crrev.com/5685d4cddd5a7e36bb837a483169a88971163208/ui/views/views_perftests.cc

Comment 2 by kenrb@chromium.org, Feb 6 2018

Blocking: 780279
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb45434b309793c6aa7dafacc207b2239ccb7323

commit eb45434b309793c6aa7dafacc207b2239ccb7323
Author: Ria Jiang <riajiang@chromium.org>
Date: Tue Feb 06 20:18:45 2018

Pass use_viz_hit_test to DirectLayerTreeFrameSink and set up hit-test.

Pass in features::IsVizHitTestingEnabled() value when creating a
DirectLayerTreeFrameSink and set up Viz hit-test in DLTFS when it is
enabled.

Bug:  805581 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iec2e2c81444fda85a5d1f99824527360ae22ac5c
Reviewed-on: https://chromium-review.googlesource.com/901945
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534771}
[modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/eb45434b309793c6aa7dafacc207b2239ccb7323/ui/compositor/test/in_process_context_factory.cc

Status: Fixed (was: Started)

Comment 5 by kenrb@chromium.org, Feb 6 2018

Blocking: -780279

Comment 6 by kenrb@chromium.org, Feb 7 2018

Blocking: 810128

Sign in to add a comment