New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805578 link

Starred by 3 users

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Build failure with clang due to wtl IFileDialogEvents unnecessary qualifying names

Reported by lti...@gmail.com, Jan 24 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.70 Safari/537.36

Steps to reproduce the problem:
Building Brave browser on top of Chromium >= C64 for Windows fails due to some apparently unneeded  "IFileDialogEvents::" qualifying names, that are breaking the compilation when using clang 6.0.0.

What is the expected behavior?
Build failure.

What went wrong?
It seems that clang would require now doing some changes in the Windows Template Library, as commented on the uptream issue: https://sourceforge.net/p/wtl/discussion/374433/thread/65ba8a84/

That was fixed at wtl just by removing those unnecessary extra qualifying names:
https://sourceforge.net/p/wtl/git/ci/5958e401f601cf10e7a01a34f0f51e6eadb134a5/

Did this work before? Yes It was building fine on Chromium < C64

Does this work in other browsers? Yes

Chrome version: 64.0.3282.119  Channel: beta
OS Version: 
Flash Version:
 
wtl_build_failure.txt
48.4 KB View Download
Cc: manoranj...@chromium.org
Components: Build
Labels: Needs-Triage-M64
As this issue is Build related, adding appropriate component and CC'ing manoranjanr@ for further help in triaging this issue.

Thanks..
Labels: TE-NeedsTriageFromMTV
Cc: abdulsyed@chromium.org
Labels: -Hotlist-Interop

Sign in to add a comment