Issue metadata
Sign in to add a comment
|
Build failure with clang due to wtl IFileDialogEvents unnecessary qualifying names
Reported by
lti...@gmail.com,
Jan 24 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.70 Safari/537.36 Steps to reproduce the problem: Building Brave browser on top of Chromium >= C64 for Windows fails due to some apparently unneeded "IFileDialogEvents::" qualifying names, that are breaking the compilation when using clang 6.0.0. What is the expected behavior? Build failure. What went wrong? It seems that clang would require now doing some changes in the Windows Template Library, as commented on the uptream issue: https://sourceforge.net/p/wtl/discussion/374433/thread/65ba8a84/ That was fixed at wtl just by removing those unnecessary extra qualifying names: https://sourceforge.net/p/wtl/git/ci/5958e401f601cf10e7a01a34f0f51e6eadb134a5/ Did this work before? Yes It was building fine on Chromium < C64 Does this work in other browsers? Yes Chrome version: 64.0.3282.119 Channel: beta OS Version: Flash Version:
,
Jan 25 2018
As this issue is Build related, adding appropriate component and CC'ing manoranjanr@ for further help in triaging this issue. Thanks..
,
Jan 29 2018
,
Jan 29 2018
,
Sep 9
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lti...@gmail.com
, Jan 24 2018