Issue metadata
Sign in to add a comment
|
Chrome crashed when user block running external application |
||||||||||||||||||||||
Issue descriptionApp Version: 65.0.3312.0 canary iOS Version: 11.2.5, 11.1.1 Device: iPhone Steps to reproduce: 1. Launch Google Chrome 2. Open any url that prompt to open an external application (this one for example: https://jsbin.com/kayosoderi/) 3. try to trigger that multiple times in less than a minute 4. prompt will appear to either allow or block running the app 5. tap block Observed results: App is Crashed. Expected results: App Shouldn't be crashing. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes
,
Jan 24 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2ccc066e10dd9131a8cf5fa376ece456bbb480e commit b2ccc066e10dd9131a8cf5fa376ece456bbb480e Author: Mohammad Refaat <mrefaat@chromium.org> Date: Wed Jan 24 20:16:12 2018 Fix Chrome crash when user block a specific external application Applaunchertabhelper's RequestToLaunchApp doesn't retain urls before prompting. Adding Retaining to the URLs. Bug: 805577 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c0cb8b236997126534bc3fc0d16a90e4504cc47 Reviewed-on: https://chromium-review.googlesource.com/884304 Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#531659} [modify] https://crrev.com/b2ccc066e10dd9131a8cf5fa376ece456bbb480e/ios/chrome/browser/app_launcher/app_launcher_tab_helper.mm
,
Jan 26 2018
,
Jan 27 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 9 2018
Please merge this as soon as possible.
,
Feb 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 12 2018
No crashes seen after tapping on Block dialog from iOS. Verified on M66.0.3345.0 canay Device: iPhoneX, iPhone8, iPhone7Plus iOS: 11.3, 11.2.5, 10.3.3
,
Feb 14 2018
No need to merge. 55 didn't have the change that introduced the crash. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mrefaat@chromium.org
, Jan 24 2018