ContextCacheControllerTest.CheckSkiaResourcePurgeAPI in viz_unittests failing on multiple builders |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of torne@google.com ContextCacheControllerTest.CheckSkiaResourcePurgeAPI in viz_unittests failing on multiple builders Builders failed on: - Lollipop Tablet Tester: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester - Marshmallow Tablet Tester: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester
,
Jan 24 2018
Thanks! Will do some more testing before relanding.
,
Jan 24 2018
FYI, here's a Flaky build: https://ci.chromium.org/buildbot/chromium.android/Lollipop%20Tablet%20Tester/11656 Looks like the API doesn't always clear as expected... maybe needs a Skia flush after (or in the function)? Will look into this.
,
Jan 24 2018
See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ContextCacheControllerTest.CheckSkiaResourcePurgeAPI&testType=viz_unittests [ FAILED ] ContextCacheControllerTest.CheckSkiaResourcePurgeAPI [ RUN ] ContextCacheControllerTest.CheckSkiaResourcePurgeAPI ../../components/viz/common/gpu/context_cache_controller_unittest.cc:157: Failure Expected equality of these values: gr_context->getResourceCachePurgeableBytes() Which is: 160000 0u Which is: 0 [ FAILED ] ContextCacheControllerTest.CheckSkiaResourcePurgeAPI (7 ms)
,
Feb 13 2018
Will look at this when I have time, but re-landing isn't currently a priority.
,
Feb 13 2018
Issue 805473 has been merged into this issue.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcce1f33cfcd611e7b3da481db53710b12e49dcb commit bcce1f33cfcd611e7b3da481db53710b12e49dcb Author: Eric Karl <ericrk@chromium.org> Date: Tue Jul 03 23:25:55 2018 Only purge unlocked Skia resources when CC goes idle This avoids clearing some longer-lived Skia caches, hopefully avoiding an UMA latency regression we experienced when the idle clearing was initially added. This re-land uses a more direct Skia API, hopefully avoiding the flakiness seen in issue 805575. Note for sheriffs: We expect a small regression in measured memory. This is intentional, and comes with an improvement to input latency. This regression shouldn't have a large impact on real-world scenarios, as we are preventing the clearing of a cache that will be immediately re-created on any page raster. TBR=brettw@chromium.org for test-only DEPS change (already ran by bsalomon@ in previous patch, this is re-land+updates) Bug: 664181, 805575 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id4c9a091a543c31f928e0214558695de81a30e9d Reviewed-on: https://chromium-review.googlesource.com/1123169 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#572391} [modify] https://crrev.com/bcce1f33cfcd611e7b3da481db53710b12e49dcb/components/viz/common/DEPS [modify] https://crrev.com/bcce1f33cfcd611e7b3da481db53710b12e49dcb/components/viz/common/gpu/context_cache_controller.cc [modify] https://crrev.com/bcce1f33cfcd611e7b3da481db53710b12e49dcb/components/viz/common/gpu/context_cache_controller_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by torne@chromium.org
, Jan 24 2018Status: Assigned (was: Available)