New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805543 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Jul 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 751807
issue 805076
issue 832995
issue 833882
issue 841080
issue 841618
issue 848146
issue 849917
issue 849931
issue 850811
issue 850818
issue 852184
issue monorail:3948

Blocking:
issue 806056
issue 808149



Sign in to add a comment

Plan for Cloud Endpoints v1 turn down

Project Member Reported by no...@chromium.org, Jan 24 2018

Issue description

Cloud Endpoints v1 will be turned down on Aug 2nd 2018. We need to provide service owners in ChoPs with options how to resolve this, with tradeoffs.
 

Comment 1 by no...@chromium.org, Jan 24 2018

Labels: -Type-Bug -Pri-3 Pri-1 Type-Task

Comment 2 by no...@chromium.org, Jan 24 2018

we have two options: switch to Cloud Endpoints v2 and use webapp2 adapter.

the more we thinkg about this problem, the more dependencies on the discovery service we find. The webapp2 adapter does not support discovery service. It didn't support it from the start because we were piggy-backing on endpoints's discovery doc. The workflow was and still is:
1) in python, build a client dynamically based on the discovery doc returned by endpoints v1
2) modify client's base URL to remove _ah to use webapp2-adapter's URLs
3) use the client

this workflow will stop working one endpoints v1 is down.

This won't affect buildbot-buildbucket integration though. I've committed buildbucket's discovery doc in the repo a while ago and buildbot masters load it from the file system.

Comment 3 by no...@chromium.org, Jan 24 2018

Cc: estaab@chromium.org

Comment 5 by mar...@chromium.org, Jan 25 2018

Blocking: 806056
Blocking: 808149
Blockedon: 751807

Comment 8 by no...@chromium.org, Apr 17 2018

Owner: smut@chromium.org

Comment 9 by no...@chromium.org, Apr 17 2018

Blockedon: 833882

Comment 10 by no...@chromium.org, Apr 17 2018

Blockedon: 832995
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/e861b770359a8f9b765be3acb8a810fb887d1aec

commit e861b770359a8f9b765be3acb8a810fb887d1aec
Author: smut <smut@google.com>
Date: Wed Apr 18 00:37:58 2018

[Machine Provider] Add webapp2 routes for all APIs

Bug:  805543 
Change-Id: I2482543d18489794acc607ee8284a0d92e46ae37
Reviewed-on: https://chromium-review.googlesource.com/1016026
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/e861b770359a8f9b765be3acb8a810fb887d1aec/appengine/machine_provider/handlers_endpoints.py

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/a804cab3da1a8005e407cc0644c745b302a58876

commit a804cab3da1a8005e407cc0644c745b302a58876
Author: smut <smut@google.com>
Date: Wed Apr 18 14:52:59 2018

[Machine Provider] Switch to webapp2 api routes

Bug:  805543 
Change-Id: I9c992848c62516e86c34e179dca79cd67c3c6e7f
Reviewed-on: https://chromium-review.googlesource.com/1016126
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/a804cab3da1a8005e407cc0644c745b302a58876/appengine/components/components/machine_provider/utils.py

Project Member

Comment 13 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/a6fe7d95acbdd4f248fb48d4e2b7919da643425a

commit a6fe7d95acbdd4f248fb48d4e2b7919da643425a
Author: smut <smut@google.com>
Date: Fri May 04 21:28:09 2018

[GCE Backend] Serve discovery document over webapp2 routes

endpoints_webapp2.api_routes installs just the service's handlers.
endpoints_webapp2.api_server also installs discovery handlers.

Bug:  805543 
Change-Id: I63a3db5d52228dec94aeba6395a37560c9e76eca
Reviewed-on: https://chromium-review.googlesource.com/1043359
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/a6fe7d95acbdd4f248fb48d4e2b7919da643425a/appengine/gce-backend/handlers_endpoints.py

Project Member

Comment 15 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/6dae36f300c8ecb360db57430502cb48ccc3b303

commit 6dae36f300c8ecb360db57430502cb48ccc3b303
Author: smut <smut@google.com>
Date: Sat May 05 01:44:49 2018

[webapp2 adapter] Fix discovery routes broken by e89326a4

Bug:  805543 
Change-Id: Ia1dc8f653d99dea2176ddf9bc77862a28509ca73
Reviewed-on: https://chromium-review.googlesource.com/1045840
Commit-Queue: smut <smut@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/6dae36f300c8ecb360db57430502cb48ccc3b303/appengine/components/components/endpoints_webapp2.py
[modify] https://crrev.com/6dae36f300c8ecb360db57430502cb48ccc3b303/appengine/components/components/endpoints_webapp2_test.py

Project Member

Comment 16 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/d87d8e11029359d280ed0726954dafc0987c701f

commit d87d8e11029359d280ed0726954dafc0987c701f
Author: smut <smut@google.com>
Date: Sat May 05 01:50:49 2018

[Swarming] Serve discovery document over webapp2 routes

endpoints_webapp2.api_routes installs just the service's handlers.
endpoints_webapp2.api_server also installs discovery handlers.

Bug:  805543 
Change-Id: I17257e79cc976ee3b0cfdb2ae06012ba1550374b
Reviewed-on: https://chromium-review.googlesource.com/1045252
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/d87d8e11029359d280ed0726954dafc0987c701f/appengine/swarming/handlers_endpoints.py
[modify] https://crrev.com/d87d8e11029359d280ed0726954dafc0987c701f/appengine/swarming/handlers_test.py

Project Member

Comment 17 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/add20df8cf783f4374180e6d04a37b07dd405a37

commit add20df8cf783f4374180e6d04a37b07dd405a37
Author: smut <smut@google.com>
Date: Sat May 05 02:04:16 2018

[Machine Provider] Convert agent to use webapp2 routes

Bug:  805543 
Change-Id: I8889bbe48113f18371ba6ab37c6576f58cbf2786
Reviewed-on: https://chromium-review.googlesource.com/1043386
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/add20df8cf783f4374180e6d04a37b07dd405a37/mp/cmd/mpagent/utils.go

Project Member

Comment 18 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/bff57363d28d9ae87548f94aba58581a9de36234

commit bff57363d28d9ae87548f94aba58581a9de36234
Author: smut <smut@google.com>
Date: Sat May 05 02:32:39 2018

[webapp2 adapter] Move into its own subdirectory

Bug:  805543 
Change-Id: Ifb60aa3d371c33a361aeb95d988002965a010570
Reviewed-on: https://chromium-review.googlesource.com/1045726
Commit-Queue: smut <smut@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/OWNERS
[add] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/OWNERS
[add] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/README.md
[add] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/__init__.py
[rename] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/adapter.py
[rename] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/adapter_test.py
[rename] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/discovery.py
[rename] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/discovery_test.py
[add] https://crrev.com/bff57363d28d9ae87548f94aba58581a9de36234/appengine/components/components/endpoints_webapp2/test_support

Comment 19 by s...@google.com, May 9 2018

Blockedon: 841080

Comment 20 by s...@google.com, May 9 2018

Blockedon: 841618
Project Member

Comment 21 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/4729b244b71f8f14c8369b7694dc46479b3c6350

commit 4729b244b71f8f14c8369b7694dc46479b3c6350
Author: smut <smut@google.com>
Date: Thu May 17 22:44:52 2018

[config] If "host" header is missing, fall back on "Host"

Apiary converts header names to lowercase for Cloud Endpoints requests
but the endpoints webapp2 adapter doesn't. The header name as originally
described in rfc7230 is "Host", so falling back on that name should be
safe and there should be no need to expect any other case.

Bug:  805543 
Change-Id: Ie14146ed37645eb1dd329235db0a9bbda2402437
Reviewed-on: https://chromium-review.googlesource.com/1056348
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/4729b244b71f8f14c8369b7694dc46479b3c6350/appengine/components/components/config/endpoint.py

Project Member

Comment 22 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/44f72403460e1767092c7d69c2212ddd8e9cb090

commit 44f72403460e1767092c7d69c2212ddd8e9cb090
Author: smut <smut@google.com>
Date: Wed May 23 00:34:28 2018

[Isolate] Serve discovery document over webapp2 routes

endpoints_webapp2.api_routes installs just the service's handlers.
endpoints_webapp2.api_server also installs discovery handlers.

Bug:  805543 
Change-Id: I00b557ce9b4d7ec288b67a4b24fc311cc4bd278d
Reviewed-on: https://chromium-review.googlesource.com/1069827
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/44f72403460e1767092c7d69c2212ddd8e9cb090/appengine/isolate/handlers_endpoints_v1.py

Project Member

Comment 23 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5ff76f416296b5e2bca6e5c87646209eb338cbfa

commit 5ff76f416296b5e2bca6e5c87646209eb338cbfa
Author: smut <smut@google.com>
Date: Thu May 24 21:28:24 2018

Remove ts_mon_test

Bug:  805543 
Change-Id: Ibe0791befcf2bf6a3c91398ed5230542ae86e614
Reviewed-on: https://chromium-review.googlesource.com/1070858
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: smut <smut@google.com>

[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/test/__init__.py
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/README.md
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/.expect_tests.cfg
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/testing_utils
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/app.yaml
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/gae_ts_mon
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/.coveragerc
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/cron.yaml
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/main.py
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/test/main_test.py
[delete] https://crrev.com/dc87ed1cfe5dd419ca87314d10119c50a1682f2d/appengine/ts_mon_test/.expect_tests_pretest.py

Project Member

Comment 27 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f824e29af84c0b9cbc936f8dc343bda51687f910

commit f824e29af84c0b9cbc936f8dc343bda51687f910
Author: smut <smut@google.com>
Date: Fri May 25 00:15:14 2018

[cr-buildbucket] Add api explorer support at /api

Bug:  805543 
Change-Id: I93fa4f98ba882a76a297c6e05dfb6520f9853c3e
Reviewed-on: https://chromium-review.googlesource.com/1072903
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/f824e29af84c0b9cbc936f8dc343bda51687f910/appengine/cr-buildbucket/handlers.py

Project Member

Comment 28 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b0787fd1821656bb2a882c069ac5664736183fe6

commit b0787fd1821656bb2a882c069ac5664736183fe6
Author: smut <smut@google.com>
Date: Tue May 29 22:04:16 2018

[cr-buildbucket] Remove unused Webapp2ApiTest

Bug:  805543 
Change-Id: Iee08f4da4377fb8602fccc27229b8c80e997af1b
Reviewed-on: https://chromium-review.googlesource.com/1074334
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/b0787fd1821656bb2a882c069ac5664736183fe6/appengine/cr-buildbucket/test/api_test.py

Project Member

Comment 29 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/740ed2e9e957370b9bc0d33226928e12c44cbed7

commit 740ed2e9e957370b9bc0d33226928e12c44cbed7
Author: smut <smut@google.com>
Date: Tue May 29 23:15:36 2018

[Machine Provider] Revert "Convert agent to use webapp2 routes"

This reverts commit add20df8cf783f4374180e6d04a37b07dd405a37.

Reason for revert:
webapp2 routes no longer have a separate URL.

Bug:  805543 
Change-Id: Id4c274a9331ebb9a40634564bd29fa0401420b97
Reviewed-on: https://chromium-review.googlesource.com/1076810
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/740ed2e9e957370b9bc0d33226928e12c44cbed7/mp/cmd/mpagent/utils.go

Project Member

Comment 31 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/904e2551418996f62753bff664cec68908c12076

commit 904e2551418996f62753bff664cec68908c12076
Author: smut <smut@google.com>
Date: Tue May 29 23:20:51 2018

[webapp2 adapter] Remove unused Webapp2EndpointsTestCase

Bug:  805543 
Change-Id: I65b4bac2589a1a9b534aeb5ad5c09d7b61d230d4
Reviewed-on: https://chromium-review.googlesource.com/1074335
Commit-Queue: smut <smut@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/904e2551418996f62753bff664cec68908c12076/appengine/components/test_support/test_case.py

Project Member

Comment 32 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/800272cc6a8812bbb4915ee050d9ae14a7a1edb8

commit 800272cc6a8812bbb4915ee050d9ae14a7a1edb8
Author: Nodir Turakulov <nodir@google.com>
Date: Tue May 29 23:22:31 2018

[buildbucket] Simplify API tests

https://chromium-review.googlesource.com/c/infra/infra/+/1074334
removed Webapp2ApiTest, but didn't remove the now unnecessary layer of
indirection. This CL does that.

Bug:  805543 
Change-Id: I66aaf9b045de180803b5c7db4ae3f2d06052af10
Reviewed-on: https://chromium-review.googlesource.com/1077499
Reviewed-by: smut <smut@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/800272cc6a8812bbb4915ee050d9ae14a7a1edb8/appengine/cr-buildbucket/test/api_test.py

Project Member

Comment 33 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/7d6364efc124261d923de76a860bbb92da5acbe3

commit 7d6364efc124261d923de76a860bbb92da5acbe3
Author: smut <smut@google.com>
Date: Wed May 30 01:54:30 2018

[Isolate] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: I6727a41afe829c227ab66ce150c536e8cda5205c
Reviewed-on: https://chromium-review.googlesource.com/1077655
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/7d6364efc124261d923de76a860bbb92da5acbe3/appengine/isolate/app.yaml
[modify] https://crrev.com/7d6364efc124261d923de76a860bbb92da5acbe3/appengine/isolate/main_frontend.py

Project Member

Comment 34 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/be1c966d04e9a9eddb6a62bbf768cd84ca829c85

commit be1c966d04e9a9eddb6a62bbf768cd84ca829c85
Author: smut <smut@google.com>
Date: Wed May 30 23:30:01 2018

[Findit] Update Isolate clients to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: I3bee8a6ffae9708e79f8be74d7f0a334f576a99c
Reviewed-on: https://chromium-review.googlesource.com/1079713
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/be1c966d04e9a9eddb6a62bbf768cd84ca829c85/appengine/findit/infra_api_clients/isolate/isolate_util.py

Project Member

Comment 35 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/da01e76c0e9729fef35344c98cd923847ce07820

commit da01e76c0e9729fef35344c98cd923847ce07820
Author: smut <smut@google.com>
Date: Thu May 31 00:10:26 2018

[Isolate] Update client to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: Ia68ca2ff86a89e0ad7e6ccf44d991e0ada861226
Reviewed-on: https://chromium-review.googlesource.com/1080152
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/da01e76c0e9729fef35344c98cd923847ce07820/client/isolate_storage.py
[modify] https://crrev.com/da01e76c0e9729fef35344c98cd923847ce07820/client/tests/isolateserver_mock.py
[modify] https://crrev.com/da01e76c0e9729fef35344c98cd923847ce07820/client/tests/isolateserver_test.py

Project Member

Comment 36 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/ee8ee5a8cc91b2361e86308324934e6be7db5dc7

commit ee8ee5a8cc91b2361e86308324934e6be7db5dc7
Author: smut <smut@google.com>
Date: Thu May 31 00:12:46 2018

[Swarming] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: I557ec2b3f25155a9e8e00ed1626747ea9022df47
Reviewed-on: https://chromium-review.googlesource.com/1077673
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/ee8ee5a8cc91b2361e86308324934e6be7db5dc7/appengine/swarming/app.yaml
[modify] https://crrev.com/ee8ee5a8cc91b2361e86308324934e6be7db5dc7/appengine/swarming/main.py

Project Member

Comment 37 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f26275fb0a0211e94a3cd8099a3b2de2d6d43dc0

commit f26275fb0a0211e94a3cd8099a3b2de2d6d43dc0
Author: smut <smut@google.com>
Date: Thu May 31 01:03:59 2018

[Isolate] Update client to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: I286de3b75d14ad051b4c96722f77607bb2eebf01
Reviewed-on: https://chromium-review.googlesource.com/1080231
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/f26275fb0a0211e94a3cd8099a3b2de2d6d43dc0/common/isolatedclient/isolatedclient.go
[modify] https://crrev.com/f26275fb0a0211e94a3cd8099a3b2de2d6d43dc0/common/isolatedclient/isolatedclient_test.go
[modify] https://crrev.com/f26275fb0a0211e94a3cd8099a3b2de2d6d43dc0/common/isolatedclient/isolatedfake/isolatedfake.go

Comment 38 by s...@google.com, May 31 2018

Blockedon: 848146
Project Member

Comment 39 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7ba61969ccbe1f9679661555f72ca947da508a70

commit 7ba61969ccbe1f9679661555f72ca947da508a70
Author: smut <smut@google.com>
Date: Thu May 31 23:02:11 2018

Update Swarming clients to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: I31dd19ac690015b0209e0c6bcee8eb94c60f5098
Reviewed-on: https://chromium-review.googlesource.com/1080338
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/appengine/findit/services/swarmbot_util.py
[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/go/src/infra/tools/led/clients.go
[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/go/src/infra/tricium/appengine/common/swarming.go
[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/appengine/findit/infra_api_clients/swarming/swarming_util.py
[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/go/src/infra/tools/led/cmd_get_builder.go
[modify] https://crrev.com/7ba61969ccbe1f9679661555f72ca947da508a70/appengine/findit/infra_api_clients/swarming/test/swarming_util_test.py

Project Member

Comment 40 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/ff3b103d75408d3bf2573f95693040ea90b156f7

commit ff3b103d75408d3bf2573f95693040ea90b156f7
Author: smut <smut@google.com>
Date: Thu May 31 23:15:10 2018

Project Member

Comment 41 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/0355ec5caef0132e1052e3fd4ec90845290488a9

commit 0355ec5caef0132e1052e3fd4ec90845290488a9
Author: smut <smut@google.com>
Date: Fri Jun 01 21:20:36 2018

[Swarming] Update clients to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: Ie0b724eba37515aed324c9489280d1386e9f7232
Reviewed-on: https://chromium-review.googlesource.com/1080332
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/botlist/bot-list-summary.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/botlist/bot-list.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/botlist/bot-mass-delete.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/botpage/bot-page.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/common/swarming-app.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/index/swarming-index.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/tasklist/task-list.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/tasklist/task-mass-cancel.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/taskpage/task-disambiguation.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/taskpage/task-page-data.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/appengine/swarming/ui/res/imp/taskpage/task-page.html
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/client/swarming.py
[modify] https://crrev.com/0355ec5caef0132e1052e3fd4ec90845290488a9/client/tests/swarming_test.py

Project Member

Comment 42 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/361cd111f1505e26eba4a1f7265cb093aaf38caa

commit 361cd111f1505e26eba4a1f7265cb093aaf38caa
Author: smut <smut@google.com>
Date: Fri Jun 01 21:53:08 2018

[buildbucket] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: I9695114794592a637c6ed8a03650c6b9a07d19f5
Reviewed-on: https://chromium-review.googlesource.com/1081941
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/361cd111f1505e26eba4a1f7265cb093aaf38caa/appengine/cr-buildbucket/app.yaml
[modify] https://crrev.com/361cd111f1505e26eba4a1f7265cb093aaf38caa/appengine/cr-buildbucket/main.py

Project Member

Comment 43 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/88087bad47fb55e5e783ef678faddf6174a29a13

commit 88087bad47fb55e5e783ef678faddf6174a29a13
Author: smut <smut@google.com>
Date: Fri Jun 01 22:32:42 2018

[led] Roll to 7ba61969ccbe1f9679661555f72ca947da508a70

Relevant changes:
7ba61969c Update Swarming clients to hit /_ah/api instead of /api
4d67b77ab [led] Allow `led get-swarm` to read tasks with isolated recipes.

Bug:  805543 
Change-Id: Iffad3818591a61572d347af95b7072e0811619af
Reviewed-on: https://chromium-review.googlesource.com/1083619
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/88087bad47fb55e5e783ef678faddf6174a29a13/cipd_manifest.txt

Project Member

Comment 44 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/0b54c7d56a08e7c6ac534222a11a9a7bd285d577

commit 0b54c7d56a08e7c6ac534222a11a9a7bd285d577
Author: smut <smut@google.com>
Date: Fri Jun 01 22:46:01 2018

Project Member

Comment 45 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/da2a91494ed11b9597c54c5e9da8562bd3d24d6d

commit da2a91494ed11b9597c54c5e9da8562bd3d24d6d
Author: smut <smut@google.com>
Date: Fri Jun 01 23:09:39 2018

[Buildbucket] Update client to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: Ifbceeb599890665fc4be698a10416348bc7bb550
Reviewed-on: https://chromium-review.googlesource.com/1083751
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/da2a91494ed11b9597c54c5e9da8562bd3d24d6d/scripts/master/buildbucket/client.py

Project Member

Comment 47 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/5ffb5ff1e381c62c7ff710d3719e09457fc4e6e3

commit 5ffb5ff1e381c62c7ff710d3719e09457fc4e6e3
Author: smut <smut@google.com>
Date: Sat Jun 02 00:31:01 2018

Update Buildbucket clients to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: I106376cb675b0134974f05ec90b4d40459ca31ae
Reviewed-on: https://chromium-review.googlesource.com/1083553
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/5ffb5ff1e381c62c7ff710d3719e09457fc4e6e3/buildbucket/client/cmd/buildbucket/base_command.go
[modify] https://crrev.com/5ffb5ff1e381c62c7ff710d3719e09457fc4e6e3/milo/buildsource/buildbot/buildstore/buildbucket.go
[modify] https://crrev.com/5ffb5ff1e381c62c7ff710d3719e09457fc4e6e3/milo/buildsource/buildbucket/common.go

Project Member

Comment 48 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/2d92ca945b664b7cc438eef33849dcee48484cea

commit 2d92ca945b664b7cc438eef33849dcee48484cea
Author: smut <smut@google.com>
Date: Sat Jun 02 00:35:21 2018

[Swarming] Update client to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

Bug:  805543 
Change-Id: I0a8f6a5d3f691826a1d9336a047bec61efaeceaf
Reviewed-on: https://chromium-review.googlesource.com/1081655
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/2d92ca945b664b7cc438eef33849dcee48484cea/client/cmd/swarming/common.go
[modify] https://crrev.com/2d92ca945b664b7cc438eef33849dcee48484cea/client/cmd/swarming/request_show.go

Project Member

Comment 49 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e3b5feb7c0e08045eba3e4a387f405f4bede2a

commit 02e3b5feb7c0e08045eba3e4a387f405f4bede2a
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 02 01:38:12 2018

Roll src/third_party/depot_tools 621fe6f..88087ba (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/621fe6f..88087ba


git log 621fe6f..88087ba --date=short --no-merges --format='%ad %ae %s'
2018-06-01 smut@google.com [led] Roll to 7ba61969ccbe1f9679661555f72ca947da508a70


Created with:
  gclient setdep -r src/third_party/depot_tools@88087ba

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:805543 
TBR=agable@chromium.org

Change-Id: I093649f6bc092095cc6ab74ecc0e671063cdc63a
Reviewed-on: https://chromium-review.googlesource.com/1083693
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563904}
[modify] https://crrev.com/02e3b5feb7c0e08045eba3e4a387f405f4bede2a/DEPS

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 2 2018

Project Member

Comment 51 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2523e0e15a3fc6473db1017c714c0fcccd59519e

commit 2523e0e15a3fc6473db1017c714c0fcccd59519e
Author: smut <smut@google.com>
Date: Sat Jun 02 02:07:01 2018

Roll client-py to 281c390193ec8c02e60279f8dac1b86ac52fa4be

Changes:
281c390 [Swarming] Update clients to hit /_ah/api instead of /api
1659133 [Isolate] Update client to hit /_ah/api instead of /api
e3a8501 Fix crash when running isolateserver download.py with --cache.
49f9f8d Reapply "[client] First local_caching improvement"
1f835c7 [client] Add --wait-for-capacity
c724359 Update stale URLs to github
77d9378 [client] reduce cipd version cache size

Bug:  805543 
Change-Id: If9c1b837b2941e3c0175eca2c577e6b4706fbdb4
Reviewed-on: https://chromium-review.googlesource.com/1083946
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#563914}
[modify] https://crrev.com/2523e0e15a3fc6473db1017c714c0fcccd59519e/DEPS

Project Member

Comment 52 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/503438477e842d30d6e019720700d7853915f2e3

commit 503438477e842d30d6e019720700d7853915f2e3
Author: smut <smut@google.com>
Date: Mon Jun 04 22:14:49 2018

[Isolate] Update clients to hit /_ah/api instead of /api

The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path.

https://chromium.googlesource.com/infra/infra revision:
d8ec646a9503426a5018cf5bc251abe4a842357f

https://chromium.googlesource.com/infra/luci/luci-go revision:
928030a644473add1ca1bd044d13f48fee569c1a

linux64/isolate.sha1:
https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-trusty-64/12546

mac64/isolate.sha1:
https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-mac-10.13-64/4878

windows64/isolate.exe.sha1:
https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-win-64/12934

Bug:  805543 
Change-Id: I1e15f69908a8c7c7a2300d3e37b0e53607613cbc
Reviewed-on: https://skia-review.googlesource.com/131701
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Auto-Submit: smut <smut@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

[modify] https://crrev.com/503438477e842d30d6e019720700d7853915f2e3/infra/bots/tools/luci-go/win64/isolate.exe.sha1
[modify] https://crrev.com/503438477e842d30d6e019720700d7853915f2e3/infra/bots/tools/luci-go/mac64/isolate.sha1
[modify] https://crrev.com/503438477e842d30d6e019720700d7853915f2e3/infra/bots/tools/luci-go/linux64/isolate.sha1

Project Member

Comment 53 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff07663eeec4e622dc11f95619e26e654370535

commit eff07663eeec4e622dc11f95619e26e654370535
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 05 01:04:37 2018

Roll src/third_party/skia 1589154..5034384 (1 commits)

https://skia.googlesource.com/skia.git/+log/1589154..5034384


git log 1589154..5034384 --date=short --no-merges --format='%ad %ae %s'
2018-06-04 smut@google.com [Isolate] Update clients to hit /_ah/api instead of /api


Created with:
  gclient setdep -r src/third_party/skia@5034384

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:805543 
TBR=halcanary@chromium.org

Change-Id: Ia2ac715be890368e6cc85ce3048dfe78df28efc5
Reviewed-on: https://chromium-review.googlesource.com/1086327
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564322}
[modify] https://crrev.com/eff07663eeec4e622dc11f95619e26e654370535/DEPS

Comment 54 by s...@google.com, Jun 6 2018

Blockedon: 849917

Comment 55 by s...@google.com, Jun 6 2018

Blockedon: 849931
Project Member

Comment 56 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f0fd4d4c4f642ee062580933af2c3b9a21ef452e

commit f0fd4d4c4f642ee062580933af2c3b9a21ef452e
Author: smut <smut@google.com>
Date: Wed Jun 06 23:14:53 2018

Roll luci-go to 2d92ca945b664b7cc438eef33849dcee48484cea

Changes:
2d92ca94 [Swarming] Update client to hit /_ah/api instead of /api
5ffb5ff1 Update Buildbucket clients to hit /_ah/api instead of /api
b93923db stringset: switch Set to a concrete type
16aa1a54 [logdog] Remove dispatchThreshold
9883c80d [appengine] Make GetRPCTransport respect per-request context and deadlines.
318be9c1 [milo] stop warning that undefined faviconURL is not valid.
2933a617 [cipd] Never overwrite published files in GS.
7d10327c [milo] Fix search page QoL bugs
521b5fb3 [milo] Remove "fix datastore" cron job.
a2686393 [luci-notify] require luci-notify.cfg
e8e20691 archiver: unexport ItemBundle and ShardItems
1bd1967d archiver: move tar archiver from cmd/isolate
b0580dda archiver: rename Item to PendingItem
7057582a [luci-notify] Log build id in pubsub handler
a2bb9574 [rpcexplorer] Add support for field masks
6db112c5 [scheduler] Move config protos to 'scheduler.config' proto package.
a9d76f7b Add myself to OWNERS
c0a1daed milo: detect and show recipe when recipe bundle is used.
5fbd65f9 Fix luci-go after updating dependencies.
753b186a isolate: Remove ArchiveOptions reference from TarringArchiver
32e861db Remove WATCHLISTS as it is no longer used by anyone.

Bug:  805543 
Change-Id: I3f45c1ca3637db641cdee574991cf3f6d3cbde89
Reviewed-on: https://chromium-review.googlesource.com/1089889
Commit-Queue: smut <smut@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f0fd4d4c4f642ee062580933af2c3b9a21ef452e/DEPS
[modify] https://crrev.com/f0fd4d4c4f642ee062580933af2c3b9a21ef452e/go/src/infra/tools/led/isolate.go

Project Member

Comment 57 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/63d382efaa6079846a74a1abbca22e28ca196622

commit 63d382efaa6079846a74a1abbca22e28ca196622
Author: smut <smut@google.com>
Date: Wed Jun 06 23:44:54 2018

Project Member

Comment 58 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/c7e24cf854b70abe6090edfe223be93cb6433d67

commit c7e24cf854b70abe6090edfe223be93cb6433d67
Author: smut <smut@google.com>
Date: Thu Jun 07 00:02:27 2018

Project Member

Comment 59 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/52c73bdb719445ecb98db0442e64b4eaa86ae148

commit 52c73bdb719445ecb98db0442e64b4eaa86ae148
Author: smut <smut@google.com>
Date: Thu Jun 07 00:14:24 2018

Project Member

Comment 60 by bugdroid1@chromium.org, Jun 7 2018

Project Member

Comment 62 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/2bb891ae32138026f1762af2cd1fa8d000dbe648

commit 2bb891ae32138026f1762af2cd1fa8d000dbe648
Author: smut <smut@google.com>
Date: Thu Jun 07 23:20:50 2018

[luci-config] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: I1144f51a1b2a40fc7d2b5332908610b7a73fbed8
Reviewed-on: https://chromium-review.googlesource.com/1091288
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/2bb891ae32138026f1762af2cd1fa8d000dbe648/appengine/config_service/app.yaml
[modify] https://crrev.com/2bb891ae32138026f1762af2cd1fa8d000dbe648/appengine/config_service/main.py

Project Member

Comment 63 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/51a81c91117d18822b60a2fe3d7ed798e5de9b54

commit 51a81c91117d18822b60a2fe3d7ed798e5de9b54
Author: smut <smut@google.com>
Date: Thu Jun 07 23:45:25 2018

Project Member

Comment 64 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/81876e84a8dd0e09c809e88d0d4943e081fcd6bf

commit 81876e84a8dd0e09c809e88d0d4943e081fcd6bf
Author: smut <smut@google.com>
Date: Thu Jun 07 23:56:15 2018

Project Member

Comment 65 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/97a2a39d2b1eb88b2f928fab4e58b576da10adab

commit 97a2a39d2b1eb88b2f928fab4e58b576da10adab
Author: smut <smut@google.com>
Date: Fri Jun 08 00:08:25 2018

Project Member

Comment 66 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/5126f72872645fd1e2cfedf049f35a87cb65f2eb

commit 5126f72872645fd1e2cfedf049f35a87cb65f2eb
Author: smut <smut@google.com>
Date: Fri Jun 08 00:24:08 2018

[luci-config] Revert "Use webapp2 adapter at /_ah/api"

This reverts commit 2bb891ae32138026f1762af2cd1fa8d000dbe648.

Reason for revert:
New verion 404s and has subtle discovery doc differences.

Bug:  805543 
Change-Id: I967b22ef30216ee37750b44f009e9b95c881bbae
Reviewed-on: https://chromium-review.googlesource.com/1092091
Reviewed-by: smut <smut@google.com>

[modify] https://crrev.com/5126f72872645fd1e2cfedf049f35a87cb65f2eb/appengine/config_service/app.yaml
[modify] https://crrev.com/5126f72872645fd1e2cfedf049f35a87cb65f2eb/appengine/config_service/main.py

Project Member

Comment 67 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/166ed99440b40c2dfa075aeec68019517f899c19

commit 166ed99440b40c2dfa075aeec68019517f899c19
Author: smut <smut@google.com>
Date: Fri Jun 08 00:45:58 2018

[Auth Service] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: Ie1beb3326624d24ffe86334318e807a93b79a602
Reviewed-on: https://chromium-review.googlesource.com/1091877
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/166ed99440b40c2dfa075aeec68019517f899c19/appengine/auth_service/app.yaml
[modify] https://crrev.com/166ed99440b40c2dfa075aeec68019517f899c19/appengine/auth_service/main_frontend.py

Comment 68 by s...@google.com, Jun 8 2018

Blockedon: 850811

Comment 69 by s...@google.com, Jun 8 2018

Blockedon: 850818
Project Member

Comment 70 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9e7fbddf8c45f4c6825de3adf60f1ac9b4649157

commit 9e7fbddf8c45f4c6825de3adf60f1ac9b4649157
Author: smut <smut@google.com>
Date: Tue Jun 12 23:40:53 2018

Roll luci-py to 958909169695ea18d2c7a93d2bdc2a9801b13bc6

Changes:
95890916 [webapp2 adapter] Return a wsgiapplication, make /_ah/api default
f588059a Add Karma tests for WebComponents swarming-index
fdb781fb [prpc] Warn about invalid headers
2e6d24a0 Make Swarming UI handle multiple TaskSlices

Bug:  805543 
Change-Id: I117d8825edd7fa98018cbcbddd20c7801b6468c4
Reviewed-on: https://chromium-review.googlesource.com/1091805
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/9e7fbddf8c45f4c6825de3adf60f1ac9b4649157/appengine/cr-buildbucket/handlers.py
[modify] https://crrev.com/9e7fbddf8c45f4c6825de3adf60f1ac9b4649157/DEPS
[modify] https://crrev.com/9e7fbddf8c45f4c6825de3adf60f1ac9b4649157/appengine/cr-buildbucket/main.py

Comment 71 by s...@google.com, Jun 12 2018

Blockedon: 852184
Project Member

Comment 72 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/453f416ecde62cbdf8626c7302dc28f9e2d9311d

commit 453f416ecde62cbdf8626c7302dc28f9e2d9311d
Author: smut <smut@google.com>
Date: Wed Jun 13 00:19:04 2018

Remove chrome_infra_stats

Bug:  805543 
Change-Id: Id0e9edd406c455bd61bdd2af9b25ff29ddc1f6e1
Reviewed-on: https://chromium-review.googlesource.com/1098301
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: smut <smut@google.com>

[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/test/views_test.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.expect_tests_pretest.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/main.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/models.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/css/bootstrap.min.css
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/appengine_config.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/js/controllers.js
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/README.md
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/step_list.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/pipeline
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.coveragerc
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/masters.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/step_records.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/app.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/cloudstorage
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/css/bootstrap.css
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/testing_utils
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/controller.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/test/__init__.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/stats-backend.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/queue.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/index.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.expect_tests.cfg
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/app.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/base.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/stats_api.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/cron.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/views.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/js/d3.min.js

Project Member

Comment 73 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/453f416ecde62cbdf8626c7302dc28f9e2d9311d

commit 453f416ecde62cbdf8626c7302dc28f9e2d9311d
Author: smut <smut@google.com>
Date: Wed Jun 13 00:19:04 2018

Remove chrome_infra_stats

Bug:  805543 
Change-Id: Id0e9edd406c455bd61bdd2af9b25ff29ddc1f6e1
Reviewed-on: https://chromium-review.googlesource.com/1098301
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: smut <smut@google.com>

[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/test/views_test.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.expect_tests_pretest.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/main.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/models.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/css/bootstrap.min.css
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/appengine_config.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/js/controllers.js
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/README.md
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/step_list.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/pipeline
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.coveragerc
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/masters.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/step_records.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/app.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/cloudstorage
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/css/bootstrap.css
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/testing_utils
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/controller.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/test/__init__.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/stats-backend.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/queue.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/index.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.expect_tests.cfg
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/app.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/base.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/stats_api.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/cron.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/views.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/js/d3.min.js

Project Member

Comment 74 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/453f416ecde62cbdf8626c7302dc28f9e2d9311d

commit 453f416ecde62cbdf8626c7302dc28f9e2d9311d
Author: smut <smut@google.com>
Date: Wed Jun 13 00:19:04 2018

Remove chrome_infra_stats

Bug:  805543 
Change-Id: Id0e9edd406c455bd61bdd2af9b25ff29ddc1f6e1
Reviewed-on: https://chromium-review.googlesource.com/1098301
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: smut <smut@google.com>

[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/test/views_test.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.expect_tests_pretest.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/main.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/models.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/css/bootstrap.min.css
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/appengine_config.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/js/controllers.js
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/README.md
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/step_list.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/pipeline
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.coveragerc
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/masters.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/step_records.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/app.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/cloudstorage
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/css/bootstrap.css
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/testing_utils
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/controller.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/test/__init__.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/stats-backend.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/queue.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/index.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/.expect_tests.cfg
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/app.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/templates/base.html
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/stats_api.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/cron.yaml
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/views.py
[delete] https://crrev.com/120e4bcf22f7f422fa77b87812dba7d17df49062/appengine/chrome_infra_stats/js/d3.min.js

Project Member

Comment 75 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/5e2e936cd7c0e7cf8869623106a5ae646f7006b8

commit 5e2e936cd7c0e7cf8869623106a5ae646f7006b8
Author: smut <smut@google.com>
Date: Wed Jun 13 08:00:50 2018

Project Member

Comment 76 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/e48e4f01df2aa1010684269af7d9e114c447c285

commit e48e4f01df2aa1010684269af7d9e114c447c285
Author: smut <smut@google.com>
Date: Wed Jun 13 08:00:51 2018

Roll client-py to 281c390193ec8c02e60279f8dac1b86ac52fa4be

Changes:
281c390 [Swarming] Update clients to hit /_ah/api instead of /api
1659133 [Isolate] Update client to hit /_ah/api instead of /api
e3a8501 Fix crash when running isolateserver download.py with --cache.
49f9f8d Reapply "[client] First local_caching improvement"
1f835c7 [client] Add --wait-for-capacity
c724359 Update stale URLs to github
77d9378 [client] reduce cipd version cache size

BUG= 805543 
CQ-DEPEND=CL:*635990

Change-Id: I6504559431e41e4eae9196f64b033b656ca27773
Reviewed-on: https://chromium-review.googlesource.com/1087512
Commit-Ready: smut <smut@google.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/e48e4f01df2aa1010684269af7d9e114c447c285/full.xml

Project Member

Comment 77 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/df1b22e7b65dde2f12cb78ca7a50fda73c681c1a

commit df1b22e7b65dde2f12cb78ca7a50fda73c681c1a
Author: smut <smut@google.com>
Date: Wed Jun 13 21:37:30 2018

Project Member

Comment 78 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/d2d291fdf518586ab756d81dd6d53b7c4d696186

commit d2d291fdf518586ab756d81dd6d53b7c4d696186
Author: smut <smut@google.com>
Date: Wed Jun 13 21:38:47 2018

[webapp2 adapter] Use status_int instead of deprecated status_code

Bug:  805543 
Change-Id: I088eeddb21fc3fe2823c35c77d5339c30a8929fc
Reviewed-on: https://chromium-review.googlesource.com/1098461
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/d2d291fdf518586ab756d81dd6d53b7c4d696186/appengine/components/components/endpoints_webapp2/adapter.py

Project Member

Comment 79 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3852091670f20f1a744257bda8760733b6eef71e

commit 3852091670f20f1a744257bda8760733b6eef71e
Author: smut <smut@google.com>
Date: Wed Jun 13 21:51:38 2018

Roll luci-py to d2d291fdf518586ab756d81dd6d53b7c4d696186

Changes:
d2d291fd [webapp2 adapter] Use status_int instead of deprecated status_code
47a31fdb [swarming] Add link in README for internal release
615e5f50 [swarming] fix test only regression from b4c7e829abfe3ac26
b4c7e829 [client] Refactor the caches to stop using context manager
1468930e Send spec_name tags to event mon metrics
579883b9 [swarming] Actually apply pool based TaskTemplates.
78083f59 Add more karma tests for Swarming UI
133226a4 [webapp2 adapter] Normalize names by removing all non-alphanumerics
166ed994 [Auth Service] Use webapp2 adapter at /_ah/api
5126f728 [luci-config] Revert "Use webapp2 adapter at /_ah/api"
462e3849 [luci-config] Add pointer to ui/README.md in README.md
2bb891ae [luci-config] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: I5508803cd0e5b2509991a303144a89ab2c52ac29
Reviewed-on: https://chromium-review.googlesource.com/1099970
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/3852091670f20f1a744257bda8760733b6eef71e/DEPS

Project Member

Comment 81 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/53ec85576afd1992f73c615f84250dcd52865022

commit 53ec85576afd1992f73c615f84250dcd52865022
Author: smut <smut@google.com>
Date: Wed Jun 13 22:15:10 2018

Project Member

Comment 83 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/53f495d67db13fdc338a2ce9d70dd3ba8365c711

commit 53f495d67db13fdc338a2ce9d70dd3ba8365c711
Author: smut <smut@google.com>
Date: Fri Jun 15 00:02:31 2018

[webapp2 adapter] Support custom regex for path parameters

Bug:  805543 
Change-Id: I639592ec78342ae07b6de70776f3e59ace919394
Reviewed-on: https://chromium-review.googlesource.com/1102005
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/53f495d67db13fdc338a2ce9d70dd3ba8365c711/appengine/components/components/endpoints_webapp2/adapter.py

Project Member

Comment 84 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a5f305fbd665af7f0f8155c398c112ed2de8217c

commit a5f305fbd665af7f0f8155c398c112ed2de8217c
Author: smut <smut@google.com>
Date: Tue Jun 19 22:14:40 2018

[cipd] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: Ieb59814d4abb665cc19a79ee40a7fa4267ed4420
Reviewed-on: https://chromium-review.googlesource.com/1098234
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/a5f305fbd665af7f0f8155c398c112ed2de8217c/appengine/chrome_infra_packages/main.py
[modify] https://crrev.com/a5f305fbd665af7f0f8155c398c112ed2de8217c/appengine/chrome_infra_packages/app.yaml

Project Member

Comment 85 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/25d0e0659502ccf7f6c9cffb8b78a908fc7b41a9

commit 25d0e0659502ccf7f6c9cffb8b78a908fc7b41a9
Author: smut <smut@google.com>
Date: Tue Jun 19 22:20:12 2018

Project Member

Comment 86 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/1ccf471d76217a0cb154e60deac623f53c17b0f5

commit 1ccf471d76217a0cb154e60deac623f53c17b0f5
Author: smut <smut@google.com>
Date: Tue Jun 19 23:05:42 2018

Project Member

Comment 87 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/0c15d4c61f827c2f2ade9098bd8c40244ed242f5

commit 0c15d4c61f827c2f2ade9098bd8c40244ed242f5
Author: smut <smut@google.com>
Date: Wed Jun 20 00:07:42 2018

Project Member

Comment 90 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9c24bac8cc9ce450b43cf16761199bd29d02b27a

commit 9c24bac8cc9ce450b43cf16761199bd29d02b27a
Author: smut <smut@google.com>
Date: Fri Jun 22 00:14:32 2018

Roll luci-py to 0bd62b8e8f94b069bdd2144f8f98a9ebe3b106af

Changes:
0bd62b8e [test_support] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: Ic26ff7efb3b8f4cac5374d894d8e91abaf548c66
Reviewed-on: https://chromium-review.googlesource.com/1111003
Reviewed-by: smut <smut@google.com>

[modify] https://crrev.com/9c24bac8cc9ce450b43cf16761199bd29d02b27a/DEPS

Project Member

Comment 91 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/44e6699fae2321b5efaeda2ad65caf32c11a82ef

commit 44e6699fae2321b5efaeda2ad65caf32c11a82ef
Author: smut <smut@google.com>
Date: Sat Jun 23 00:07:18 2018

Comment 92 by s...@google.com, Jun 23 2018

Blockedon: monorail:3948
Project Member

Comment 94 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a6adfcf6f77cdcda0d237d57388d24b8d46a08aa

commit a6adfcf6f77cdcda0d237d57388d24b8d46a08aa
Author: smut <smut@google.com>
Date: Wed Jul 04 00:10:36 2018

[Monorail] Avoid API path conflict.

This reverts commit 39a50186749d3e822815dd6ca3af55d33b402a2e.

Reason for revert:
Database upgrade is complete. This change is a prerequisite to
retrying the Endpoints webapp2 adapter.

Bug:  805543 
Change-Id: Idd40c2bc40313754cf27941c8b47b1e2e64df417
Reviewed-on: https://chromium-review.googlesource.com/1125275
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/a6adfcf6f77cdcda0d237d57388d24b8d46a08aa/appengine/monorail/services/api_svc_v1.py

Project Member

Comment 95 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d82c2b9429ff30a01e74bb4a649cff18ba77e7f7

commit d82c2b9429ff30a01e74bb4a649cff18ba77e7f7
Author: smut <smut@google.com>
Date: Mon Jul 09 21:16:40 2018

[Monorail] Use webapp2 adapter at /_ah/api

This reverts commit 49f2efd1769517e744542c2c416f862c5140f986.

Reason for revert:
Group sync cron job has been fixed to work with the adapter.

Bug:  805543 
Change-Id: I8712f363cf7854c7915c53e0419a2e6f4e123bc3
Reviewed-on: https://chromium-review.googlesource.com/1125407
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/d82c2b9429ff30a01e74bb4a649cff18ba77e7f7/appengine/monorail/module-latency-insensitive.yaml
[modify] https://crrev.com/d82c2b9429ff30a01e74bb4a649cff18ba77e7f7/appengine/monorail/monorailapp.py
[modify] https://crrev.com/d82c2b9429ff30a01e74bb4a649cff18ba77e7f7/appengine/monorail/app.yaml

Project Member

Comment 96 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fb511f961bfdc694e28dc2d6a159aa6615e7b0df

commit fb511f961bfdc694e28dc2d6a159aa6615e7b0df
Author: smut <smut@google.com>
Date: Tue Jul 10 21:55:54 2018

[cr-rev] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: I731c8296191843e391055d528e18a5270f6fdb12
Reviewed-on: https://chromium-review.googlesource.com/1121337
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: smut <smut@google.com>

[add] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/test_support
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/launch-backend.yaml
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/scan-backend.yaml
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/bulk-load-backend.yaml
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/appengine_module/cr_rev/cr_rev_api.py
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/appengine_module/cr_rev/test/views_test.py
[add] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/components
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/appengine_module/cr_rev/test/cr_rev_api_test.py
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/app.yaml
[add] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/.expect_tests.cfg
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/appengine_module/cr_rev/app.py
[modify] https://crrev.com/fb511f961bfdc694e28dc2d6a159aa6615e7b0df/appengine/cr_rev/appengine_module/cr_rev/views.py

Project Member

Comment 97 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/8099fe96a66e8994c97da7a6ece955f7d3212c89

commit 8099fe96a66e8994c97da7a6ece955f7d3212c89
Author: smut <smut@google.com>
Date: Thu Jul 12 21:38:33 2018

[endpoints_smoke_test] Use webapp2 adapter at /_ah/api

Bug:  805543 
Change-Id: I58dca542da8b7b61f603791faaa1ec72fb0912e7
Reviewed-on: https://chromium-review.googlesource.com/1134403
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/8099fe96a66e8994c97da7a6ece955f7d3212c89/appengine/components/tests/test_endpoints_app/app.yaml
[modify] https://crrev.com/8099fe96a66e8994c97da7a6ece955f7d3212c89/appengine/components/tests/test_endpoints_app/main.py

Project Member

Comment 98 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e

commit 4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e
Author: smut <smut@google.com>
Date: Wed Jul 18 22:45:40 2018

[gae_ts_mon] Use luci test_support instead of infra testing_utils

test_support.test_case.TestCase is roughly the same as
testing_utils.testing.AppengineTestCase. The latter has some additional
features, but they're all unused by gae_ts_mon tests.

More importantly, test_support.test_case.EndpointsTestCase, which used to be
roughly the same as testing_utils.testing.EndpointsTestCase, has been updated
to use the Endpoints webapp2 adapter. Rather than copy/pasting that change
into testing_utils, just update tests to use test_support.

Bug:  805543 
Change-Id: I31b21911bad8f0b162f43010827de0fcddb5d592
Reviewed-on: https://chromium-review.googlesource.com/1117852
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

[add] https://crrev.com/4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e/appengine_module/gae_ts_mon/test/test_support
[modify] https://crrev.com/4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e/appengine_module/gae_ts_mon/test/config_test.py
[add] https://crrev.com/4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e/appengine_module/gae_ts_mon/test/.expect_tests.cfg
[modify] https://crrev.com/4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e/appengine_module/gae_ts_mon/test/handlers_test.py
[modify] https://crrev.com/4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e/appengine_module/gae_ts_mon/test/__init__.py
[modify] https://crrev.com/4ad9264f78b563ed20ebf74d2ce739df6c9a1d6e/appengine_module/gae_ts_mon/test/shared_test.py

Status: Fixed (was: Started)

Sign in to add a comment