New issue
Advanced search Search tips

Issue 805541 link

Starred by 1 user
Status: Assigned
Owner:
charliea@chromium.org
Cc:
eyaich@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

tools/perf PRESUBMIT should block commits that try disabling whole benchmarks with wrong syntax

Project Member Reported by nedngu...@google.com, Jan 24 2018 
I found out that if a commit does:
 crbug.com/805520  [ Mac_10.11 ] system_health.common_desktop [ Skip ]

The PRESUBMIT will not complain. However, this doesn't do anything either. The correct syntax is:

 crbug.com/805520  [ Mac_10.11 ] system_health.common_desktop/* [ Skip ]


We should make sure tools/perf PRESUBMIT can block this type of wrong disabling.

Comment 1 by charliea@chromium.org, Jan 26 2018 

I'll tackle this when I sweep back around to look at the disabling work.

Comment 2 by charliea@chromium.org, Feb 7 2018

Labels: Hotlist-GoodFirstBug
Status: Assigned (was: Untriaged)
►

Sign in to add a comment