Create a new IncognitoView with new styling |
|||||||||
Issue descriptionRename the existing view to IncognitoViewLegacy. Create a new view with styling that matches the new mocks.
,
Jan 24 2018
,
Jan 25 2018
,
Jan 26 2018
,
Jan 27 2018
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc56ddab912ea28964c0f0ad8748ca27456dc93e commit fc56ddab912ea28964c0f0ad8748ca27456dc93e Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Feb 06 18:16:10 2018 [ios] Updates the incognito ui to use a UIStackView. UIStackView automatically positions views in a vertical column, which allows us to remove a number of positioning constraints. This also makes it possible to change individual pieces of the incognito ui without needing to modify any constraints. BUG= 805521 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib746a91202946235e6de3c20f88947d8e85ee49b Reviewed-on: https://chromium-review.googlesource.com/900182 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534722} [modify] https://crrev.com/fc56ddab912ea28964c0f0ad8748ca27456dc93e/ios/chrome/browser/ui/ntp/incognito_view.mm
,
Apr 5 2018
,
Apr 9 2018
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
,
Jun 11 2018
How is this one going? It seems to be the largest task in the Incognito user story and it's not assigned.
,
Jun 14 2018
Screenshots attached for what will be in the first CL.
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/775a587aec242961b4046f728a1afb9f570b1855 commit 775a587aec242961b4046f728a1afb9f570b1855 Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Jun 15 14:26:57 2018 [ios] Updates styling for the IncognitoView. Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=805521#c11 BUG= 805521 , 805522 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iee04f09c04a95a58368ee8cd9b51448729b437aa Reviewed-on: https://chromium-review.googlesource.com/1101218 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567637} [modify] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/incognito_view.mm [modify] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/BUILD.gn [modify] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/incognito_icon.imageset/incognito_icon.png [modify] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/incognito_icon.imageset/incognito_icon@2x.png [modify] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/incognito_icon.imageset/incognito_icon@3x.png [add] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/Contents.json [add] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/incognito_legacy_icon.png [add] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/incognito_legacy_icon@2x.png [add] https://crrev.com/775a587aec242961b4046f728a1afb9f570b1855/ios/chrome/browser/ui/ntp/resources/incognito_legacy_icon.imageset/incognito_legacy_icon@3x.png
,
Jun 15 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rohitrao@chromium.org
, Jan 24 2018