Remove ImageDataBuffer constructor from unsigned char * |
||
Issue descriptionImageDataBuffer has two constructors from unsigned char * and SkPixmap. We already migrated to use SkPixmap in Blink code, but there are two external calls to the constructor from unsigned char * in the following modules: src/third_party/WebKit/Source/core/inspector/InspectorAuditsAgent.cpp src/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp We should change these call sites to directly pass SkPixmap to the constructor. Then we can simplify ImageDataBuffer and remove the extra constructor along with the respective flags (uses_pixmap, ...).
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8ebe4bd32356265981a14069469dc9bfe675494 commit a8ebe4bd32356265981a14069469dc9bfe675494 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Mon Mar 05 18:21:42 2018 Remove ImageDataBuffer constructor from "unsigned char *" This CL removes ImageDataBuffer ctor from uchar* and replaces the call sites with ctor from SkPixmap. Bug:805512 TBR=junov@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia32a15c14c44160ed205359909034f50adf0cf6e Reviewed-on: https://chromium-review.googlesource.com/946854 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540872} [modify] https://crrev.com/a8ebe4bd32356265981a14069469dc9bfe675494/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/audits/get-encoded-response-expected.txt [modify] https://crrev.com/a8ebe4bd32356265981a14069469dc9bfe675494/third_party/WebKit/Source/core/inspector/InspectorAuditsAgent.cpp [modify] https://crrev.com/a8ebe4bd32356265981a14069469dc9bfe675494/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp [modify] https://crrev.com/a8ebe4bd32356265981a14069469dc9bfe675494/third_party/WebKit/Source/platform/graphics/ImageDataBuffer.cpp [modify] https://crrev.com/a8ebe4bd32356265981a14069469dc9bfe675494/third_party/WebKit/Source/platform/graphics/ImageDataBuffer.h
,
Mar 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by zakerinasab@chromium.org
, Mar 2 2018