Reposition the tablet findbar |
||||||
Issue descriptionMove the findbar to overlap more with the toolbar, to match new mocks.
,
Apr 5 2018
,
Jul 10
,
Jul 10
,
Jul 10
The exact positioning is still in flux -- Pete indicated that he was rethinking where to position the bar, so please check with him.
,
Jul 11
Gauthier, lets do the same amount of toolbar overlap as the menus do. As for the horizontal positioning ... per offline discussion this morning, lets pin it to the trailing screen's edge and offset it by the same amount as the overflow menu.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270 commit 59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Jul 13 13:44:37 2018 [iOS] Adjust FindBar position for UI Refresh This CL changes the position of the FindBar to follow the design of UI Refresh. Bug: 805508 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5938fa23fac401f65d1324f06f73087388f66a80 Reviewed-on: https://chromium-review.googlesource.com/1134767 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#574899} [modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/find_bar/BUILD.gn [modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm [modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/find_bar/find_bar_view.mm
,
Jul 13
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cmasso@google.com
, Feb 28 2018