New issue
Advanced search Search tips

Issue 805508 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Reposition the tablet findbar

Project Member Reported by rohitrao@chromium.org, Jan 24 2018

Issue description

Move the findbar to overlap more with the toolbar, to match new mocks.
 

Comment 1 by cmasso@google.com, Feb 28 2018

Labels: -Q1 Q2

Comment 2 by cmasso@google.com, Apr 5 2018

Labels: Pri-1
Labels: Proj-UIRefresh
Labels: M-69
Cc: pschaffner@chromium.org rohitrao@chromium.org
Owner: gambard@chromium.org
The exact positioning is still in flux -- Pete indicated that he was rethinking where to position the bar, so please check with him.
Gauthier, lets do the same amount of toolbar overlap as the menus do. As for the horizontal positioning ... per offline discussion this morning, lets pin it to the trailing screen's edge and offset it by the same amount as the overflow menu.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270

commit 59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jul 13 13:44:37 2018

[iOS] Adjust FindBar position for UI Refresh

This CL changes the position of the FindBar to follow the design of
UI Refresh.

Bug:  805508 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5938fa23fac401f65d1324f06f73087388f66a80
Reviewed-on: https://chromium-review.googlesource.com/1134767
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574899}
[modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/find_bar/BUILD.gn
[modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
[modify] https://crrev.com/59dcdf12a0c35bab1b1a76bf2eb36af14d6d7270/ios/chrome/browser/ui/find_bar/find_bar_view.mm

Status: Fixed (was: Assigned)

Sign in to add a comment