Chrome sync disclosure should use Chrome icon, not G |
||||||||
Issue descriptionThe first disclosure on the "You're signed in screen" should use the Chrome logo, not the Google logo, per spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZTZGi1Py7-ME/files/MCHjCAqFlpRi5qn3lNzwdrYMwMSJbxAVNpw The second disclosure should still use Google logo.
,
Jan 27 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/theme/google_chrome/+/4b84c410ede53f77e980b5ae6a04951587780c69 commit 4b84c410ede53f77e980b5ae6a04951587780c69 Author: Alexander Alekseev <alemate@google.com> Date: Sat Jan 27 09:14:35 2018
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69f0b0d21dc6a3d97bfa4cb059193db99cb00051 commit 69f0b0d21dc6a3d97bfa4cb059193db99cb00051 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Jan 27 15:23:26 2018 Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. This CL limits Sync settings screen to Google Chrome build and adds Chrome logo to it. BUG= 805507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 Reviewed-on: https://chromium-review.googlesource.com/889916 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#532221} [modify] https://crrev.com/69f0b0d21dc6a3d97bfa4cb059193db99cb00051/chrome/app/theme/chrome_unscaled_resources.grd [modify] https://crrev.com/69f0b0d21dc6a3d97bfa4cb059193db99cb00051/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/69f0b0d21dc6a3d97bfa4cb059193db99cb00051/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/69f0b0d21dc6a3d97bfa4cb059193db99cb00051/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
,
Jan 27 2018
,
Jan 27 2018
Requesting merge for both changes.
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b3e943e31414bd5a90774db5f98bd038c94cda8 commit 1b3e943e31414bd5a90774db5f98bd038c94cda8 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Sat Jan 27 16:04:22 2018 Revert "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen." This reverts commit 69f0b0d21dc6a3d97bfa4cb059193db99cb00051. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 532221 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY5ZjBiMGQyMWRjNmEzZDk3YmZhNGNiMDU5MTkzZGI5OWNiMDAwNTEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/44876 Original change's description: > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. > > > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo > to it. > > BUG= 805507 > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 > Reviewed-on: https://chromium-review.googlesource.com/889916 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532221} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG= 805507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If84b7f7f1159d8e5ee525ef0bf7104f867fb933b Reviewed-on: https://chromium-review.googlesource.com/890539 Cr-Commit-Position: refs/heads/master@{#532224} [modify] https://crrev.com/1b3e943e31414bd5a90774db5f98bd038c94cda8/chrome/app/theme/chrome_unscaled_resources.grd [modify] https://crrev.com/1b3e943e31414bd5a90774db5f98bd038c94cda8/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/1b3e943e31414bd5a90774db5f98bd038c94cda8/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/1b3e943e31414bd5a90774db5f98bd038c94cda8/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
,
Jan 28 2018
This bug requires manual review: There is .grd file changes and we are only 36 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 29 2018
Is this really ready to merge? It looks like one CL got reverted. FWIW, the grd change here does not appear to change strings, so I think it is ok to merge if we are really ready to merge here.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d79797fb8e103e4816291ef835447c1a72f8fe8d commit d79797fb8e103e4816291ef835447c1a72f8fe8d Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Jan 29 21:42:28 2018 Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen." This is a reland of 69f0b0d21dc6a3d97bfa4cb059193db99cb00051. (Relanding to pick up resource file change.) Original change's description: > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. > > > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo > to it. > > BUG= 805507 > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 > Reviewed-on: https://chromium-review.googlesource.com/889916 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532221} TBR=oshima@chromium.org Bug: 805507 Change-Id: I153d86a34bf73a7b02f9a844fbc137d658897944 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/891562 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#532599} [modify] https://crrev.com/d79797fb8e103e4816291ef835447c1a72f8fe8d/chrome/app/theme/chrome_unscaled_resources.grd [modify] https://crrev.com/d79797fb8e103e4816291ef835447c1a72f8fe8d/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/d79797fb8e103e4816291ef835447c1a72f8fe8d/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/d79797fb8e103e4816291ef835447c1a72f8fe8d/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0486f4ab194bc23a8404e71702cc118c27e19c14 commit 0486f4ab194bc23a8404e71702cc118c27e19c14 Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Jan 29 22:18:54 2018 Revert "Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen."" This reverts commit d79797fb8e103e4816291ef835447c1a72f8fe8d. Reason for revert: compile failure on Chrome OS, see failure: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/44972 Original change's description: > Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen." > > This is a reland of 69f0b0d21dc6a3d97bfa4cb059193db99cb00051. > (Relanding to pick up resource file change.) > > Original change's description: > > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. > > > > > > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo > > to it. > > > > BUG= 805507 > > > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 > > Reviewed-on: https://chromium-review.googlesource.com/889916 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532221} > > TBR=oshima@chromium.org > > Bug: 805507 > Change-Id: I153d86a34bf73a7b02f9a844fbc137d658897944 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/891562 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532599} TBR=oshima@chromium.org,alemate@chromium.org Change-Id: Icfae88c24e16ccc29b6f3522b451f3c55f20e1e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/891811 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#532617} [modify] https://crrev.com/0486f4ab194bc23a8404e71702cc118c27e19c14/chrome/app/theme/chrome_unscaled_resources.grd [modify] https://crrev.com/0486f4ab194bc23a8404e71702cc118c27e19c14/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/0486f4ab194bc23a8404e71702cc118c27e19c14/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/0486f4ab194bc23a8404e71702cc118c27e19c14/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
,
Jan 29 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/fca13d4abbafa77c85bb529711d6fab8947df24e commit fca13d4abbafa77c85bb529711d6fab8947df24e Author: Alexander Alekseev <alemate@google.com> Date: Mon Jan 29 22:39:29 2018
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e86cbaede20554aeb9b061c58ccfb4b6283e248 commit 1e86cbaede20554aeb9b061c58ccfb4b6283e248 Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Jan 30 01:10:33 2018 Roll out another logo. TBR=oshima@chromium.org Bug: 805507 Change-Id: I47c6ee4996c0adf1bb2a1646af1c41a20a43db37 Reviewed-on: https://chromium-review.googlesource.com/892047 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#532711} [modify] https://crrev.com/1e86cbaede20554aeb9b061c58ccfb4b6283e248/DEPS
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f21ddbca744f7a50c404be13bac1871b502b3120 commit f21ddbca744f7a50c404be13bac1871b502b3120 Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Jan 30 04:40:39 2018 Reland "Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen."" This is a reland of d79797fb8e103e4816291ef835447c1a72f8fe8d. Relanding after DEPS have been updated. TBR=oshima@chromium.org Original change's description: > Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen." > > This is a reland of 69f0b0d21dc6a3d97bfa4cb059193db99cb00051. > (Relanding to pick up resource file change.) > > Original change's description: > > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. > > > > > > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo > > to it. > > > > BUG= 805507 > > > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 > > Reviewed-on: https://chromium-review.googlesource.com/889916 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532221} > > TBR=oshima@chromium.org > > Bug: 805507 > Change-Id: I153d86a34bf73a7b02f9a844fbc137d658897944 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/891562 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532599} Bug: 805507 Change-Id: Iaa8e7a4d45d38683a3c06346ddaa53a349ab6a91 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/892360 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#532755} [modify] https://crrev.com/f21ddbca744f7a50c404be13bac1871b502b3120/chrome/app/theme/chrome_unscaled_resources.grd [modify] https://crrev.com/f21ddbca744f7a50c404be13bac1871b502b3120/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/f21ddbca744f7a50c404be13bac1871b502b3120/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/f21ddbca744f7a50c404be13bac1871b502b3120/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
,
Jan 30 2018
Requesting merge for both original CLs and DEPS changes.
,
Jan 31 2018
This bug requires manual review: There is .grd file changes and we are only 33 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 31 2018
,
Feb 1 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/8c054de56f4a3ac7518b014a6c3348981eb07e89 commit 8c054de56f4a3ac7518b014a6c3348981eb07e89 Author: Alexander Alekseev <alemate@google.com> Date: Thu Feb 01 00:45:11 2018
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c25ac4ae63b9e9f1aca1d4e7a441757c9ac22f67 commit c25ac4ae63b9e9f1aca1d4e7a441757c9ac22f67 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Feb 01 00:53:03 2018 Reland "Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen."" This is a reland of d79797fb8e103e4816291ef835447c1a72f8fe8d. Relanding after DEPS have been updated. TBR=alemate@chromium.org, oshima@chromium.org Original change's description: > Reland "Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen." > > This is a reland of 69f0b0d21dc6a3d97bfa4cb059193db99cb00051. > (Relanding to pick up resource file change.) > > Original change's description: > > Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen. > > > > > > This CL limits Sync settings screen to Google Chrome build and adds Chrome logo > > to it. > > > > BUG= 805507 > > > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > > Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03 > > Reviewed-on: https://chromium-review.googlesource.com/889916 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532221} > > TBR=oshima@chromium.org > > Bug: 805507 > Change-Id: I153d86a34bf73a7b02f9a844fbc137d658897944 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/891562 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532599} (cherry picked from commit f21ddbca744f7a50c404be13bac1871b502b3120) Bug: 805507 Change-Id: Iaa8e7a4d45d38683a3c06346ddaa53a349ab6a91 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/892360 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532755} Reviewed-on: https://chromium-review.googlesource.com/896795 Cr-Commit-Position: refs/branch-heads/3325@{#221} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/c25ac4ae63b9e9f1aca1d4e7a441757c9ac22f67/chrome/app/theme/chrome_unscaled_resources.grd [modify] https://crrev.com/c25ac4ae63b9e9f1aca1d4e7a441757c9ac22f67/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/c25ac4ae63b9e9f1aca1d4e7a441757c9ac22f67/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/c25ac4ae63b9e9f1aca1d4e7a441757c9ac22f67/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by alemate@chromium.org
, Jan 26 2018