Sync disclosure screens should not have back buttons |
|||||
Issue descriptionThe "You're signed in" and "Sync settings" screens should not have back buttons, as there's no reasonable place to take the user at this point. "Next" button and "Save and continue" button should go to next screen in OOBE: a) ARC++ Opt-In if available b) else Profile pic selection if new crOS users c) else exit to user session
,
Jan 24 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d903c69641cf667d208e654b69a3d2054adc9bb1 commit d903c69641cf667d208e654b69a3d2054adc9bb1 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Jan 24 22:47:28 2018 Chrome OS: Sync settings screen should not have "Back" button. Remove "Back" button after UI review. Bug: 805505 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I95e343cd0e0626e39b2b8b3919ca5a773f25a2dc Reviewed-on: https://chromium-review.googlesource.com/884436 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#531726} [modify] https://crrev.com/d903c69641cf667d208e654b69a3d2054adc9bb1/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/d903c69641cf667d208e654b69a3d2054adc9bb1/chrome/browser/resources/chromeos/login/sync_consent.js
,
Jan 25 2018
,
Jan 26 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e499c30f43b0517bd6e228af393c73cab373216 commit 6e499c30f43b0517bd6e228af393c73cab373216 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Jan 26 18:15:48 2018 Chrome OS: Sync settings screen should not have "Back" button. Remove "Back" button after UI review. TBR=alemate@chromium.org (cherry picked from commit d903c69641cf667d208e654b69a3d2054adc9bb1) Bug: 805505 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I95e343cd0e0626e39b2b8b3919ca5a773f25a2dc Reviewed-on: https://chromium-review.googlesource.com/884436 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531726} Reviewed-on: https://chromium-review.googlesource.com/888539 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#117} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/6e499c30f43b0517bd6e228af393c73cab373216/chrome/browser/resources/chromeos/login/sync_consent.html [modify] https://crrev.com/6e499c30f43b0517bd6e228af393c73cab373216/chrome/browser/resources/chromeos/login/sync_consent.js |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by albuque...@gmail.com
, Jan 24 2018