New issue
Advanced search Search tips

Issue 805504 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Update findbar styling to match new mocks

Project Member Reported by rohitrao@chromium.org, Jan 24 2018

Issue description

Update the findbar text field and next/previous buttons.  Remove the separator between the text field and buttons.  Switch to a translucent background.
 

Comment 1 by cmasso@google.com, Feb 28 2018

Labels: -Q1 Q2

Comment 2 by cmasso@google.com, Apr 5 2018

Labels: Pri-1
Labels: Proj-UIRefresh
Labels: M-69
Cc: rohitrao@chromium.org
Owner: gambard@chromium.org
The background is no longer translucent, but the other items in this bug are still valid.
Cc: gambard@chromium.org
 Issue 805506  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28440e9ca7cf86d59e8484ec7cf0010b873fbf62

commit 28440e9ca7cf86d59e8484ec7cf0010b873fbf62
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jul 11 12:40:34 2018

[iOS] Prepare FindInPage new UI

This CL prepares FindInPage to have its UI updated for UI refresh.
A new protocol for both UI elements and a new shared constants file are
added. The old UIView is renamed to LegacyFindBarView.

Bug:  805504 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic732a11c38b8b068d59138d9073f988a2b206843
Reviewed-on: https://chromium-review.googlesource.com/1131951
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574132}
[modify] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/BUILD.gn
[add] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/find_bar_constants.h
[add] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/find_bar_constants.mm
[modify] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
[add] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/find_bar_ui_element.h
[modify] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/find_bar_view.h
[modify] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/find_bar_view.mm
[modify] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm
[add] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/legacy_find_bar_view.h
[add] https://crrev.com/28440e9ca7cf86d59e8484ec7cf0010b873fbf62/ios/chrome/browser/ui/find_bar/legacy_find_bar_view.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81f3e175814bb20d103aa178a71272c2cd422193

commit 81f3e175814bb20d103aa178a71272c2cd422193
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jul 12 13:41:04 2018

[iOS] Create FindInPage UI for UI Refresh

This CL creates the FindInPage UI to be used with UI Refresh.

Bug:  805504 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib6f5adcfde4560a589fed323a717b02c4566621d
Reviewed-on: https://chromium-review.googlesource.com/1133160
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574551}
[modify] https://crrev.com/81f3e175814bb20d103aa178a71272c2cd422193/ios/chrome/browser/ui/find_bar/BUILD.gn
[modify] https://crrev.com/81f3e175814bb20d103aa178a71272c2cd422193/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
[modify] https://crrev.com/81f3e175814bb20d103aa178a71272c2cd422193/ios/chrome/browser/ui/find_bar/find_bar_ui_element.h
[modify] https://crrev.com/81f3e175814bb20d103aa178a71272c2cd422193/ios/chrome/browser/ui/find_bar/find_bar_view.h
[modify] https://crrev.com/81f3e175814bb20d103aa178a71272c2cd422193/ios/chrome/browser/ui/find_bar/find_bar_view.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on chrome canary version 69.0.3494.0 on iPhone 8 plus, iPhone 6s plus and iPad Pro with iOS 11.4.1, 12 beta 3.  New UI of Findbar looks good.

Screen Shots : 

iPad - https://drive.google.com/file/d/1AOxzTevskMS7QkjRrrKs08kV64dwcro6/view?usp=sharing

iPhone - https://drive.google.com/file/d/1k7wu7HswYGzq1xpWVMh71naLlaWpUWZ0/view?usp=sharing


Sign in to add a comment