New issue
Advanced search Search tips

Issue 805500 link

Starred by 3 users
Status: Assigned
Owner:
steimel@chromium.org
Cc:
m...@chromium.org
mlamouri@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Figure out why tab strip model was generating invalid indices

Project Member Reported by steimel@chromium.org, Jan 24 2018 
There were crashes on Mac due to the tab strip model generating invalid tab indices in WillContextMenuMuteSites. The bug was fixed by adding a null check in IsSiteMuted, but we want to investigate further to find out why invalid indices were being generated in the first place.

Crash bug: crbug.com/797647
Null-check fix: crrev.com/c/848245

Comment 1 by sky@chromium.org, Jan 24 2018 

Is the menu caching indices that are used async? For example, the menu is about to show so the code figures out some indices. The menu is then shown and behind the scenes the tab closes, and then the code tries to use cached indices that are now bogus.

Comment 2 by kkaluri@chromium.org, Nov 23

Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
►

Sign in to add a comment