Long press on "Welcome!" should not select text |
||||
Issue descriptionWhen accessing touch accessible OOBE options with long press on "Welcome!" , the Welcome text should not be selectable. Additionally, the Welcome text should announce itself as a button to Chromevox.
,
Feb 7 2018
,
Feb 7 2018
Are you sure the Welcome text should announce itself as a button, considering that it * only supports long tap (so it might be unexpected that click does not work) * it is not displayed as a button in UI - the long press functionality would be no less discoverable using screen reader than looking at the UI Though, the Advanced settings dialog doesn't seem to be reachable by keyboard - we might want to fix that.
,
Feb 7 2018
Everything in the advanced settings dialog is already keyboard accessible via keyboard shortcuts, so we're good in that regard. I'm okay not announcing as button as long as the text isn't selectable.
,
Feb 7 2018
OK, sounds good
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b3970a2d688a88ab06dd8967acfd7eb90c6a28b commit 2b3970a2d688a88ab06dd8967acfd7eb90c6a28b Author: Toni Barzic <tbarzic@google.com> Date: Thu Feb 08 01:25:22 2018 Add icon to OOBE advanced options dialog Also, makes "Welcome!" text in welcome dialog not selectable. BUG=797021, 805492 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id8ac18d8a49c923fb0bd79a5f081c963ab4c0ae7 Reviewed-on: https://chromium-review.googlesource.com/907728 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#535236} [modify] https://crrev.com/2b3970a2d688a88ab06dd8967acfd7eb90c6a28b/chrome/browser/resources/chromeos/login/oobe_welcome.css [modify] https://crrev.com/2b3970a2d688a88ab06dd8967acfd7eb90c6a28b/chrome/browser/resources/chromeos/login/oobe_welcome.html [modify] https://crrev.com/2b3970a2d688a88ab06dd8967acfd7eb90c6a28b/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02b6463f6646db325aa62883383e7f83122eabb9 commit 02b6463f6646db325aa62883383e7f83122eabb9 Author: Toni Barzic <tbarzic@google.com> Date: Wed Feb 14 02:32:29 2018 Add icon to OOBE advanced options dialog Also, makes "Welcome!" text in welcome dialog not selectable. BUG=797021, 805492 TBR=tbarzic@google.com (cherry picked from commit 2b3970a2d688a88ab06dd8967acfd7eb90c6a28b) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id8ac18d8a49c923fb0bd79a5f081c963ab4c0ae7 Reviewed-on: https://chromium-review.googlesource.com/907728 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#535236} Reviewed-on: https://chromium-review.googlesource.com/917539 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#459} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/02b6463f6646db325aa62883383e7f83122eabb9/chrome/browser/resources/chromeos/login/oobe_welcome.css [modify] https://crrev.com/02b6463f6646db325aa62883383e7f83122eabb9/chrome/browser/resources/chromeos/login/oobe_welcome.html [modify] https://crrev.com/02b6463f6646db325aa62883383e7f83122eabb9/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
,
Feb 14 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zalcorn@chromium.org
, Feb 7 2018Labels: -Pri-2 Pri-1
Owner: tbarzic@chromium.org