New issue
Advanced search Search tips

Issue 805490 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

a11y: Advanced options line-items should declare as buttons

Project Member Reported by zalcorn@chromium.org, Jan 24 2018

Issue description

On the "Advanced options" screen in OOBE, each line item should identify itself as a button so that Chromevox users know it can be clicked.
 

Comment 1 Deleted

Comment 2 Deleted

Labels: -M-65 ReleaseBlock-Stable M-66
Per a11y policy, this is must-have for M66.
New screenshot is attached.
Screenshot from 2018-02-28 14:43:52.png
32.0 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31e8f4d061c3f1d7dd1b3baea9b4be8a1d5f81be

commit 31e8f4d061c3f1d7dd1b3baea9b4be8a1d5f81be
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Mar 01 05:18:14 2018

Chrome OS OOBE: Improve a11y in Advanced options screen.

This CL adds native <button> elements to make screen more accessible.


Bug:  805490 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6ef14545ac7ef6484afe83c3e58166c2c3aea6fc
Reviewed-on: https://chromium-review.googlesource.com/941509
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540060}
[modify] https://crrev.com/31e8f4d061c3f1d7dd1b3baea9b4be8a1d5f81be/chrome/browser/resources/chromeos/login/oobe_welcome.css
[modify] https://crrev.com/31e8f4d061c3f1d7dd1b3baea9b4be8a1d5f81be/chrome/browser/resources/chromeos/login/oobe_welcome.html

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment