Issue metadata
Sign in to add a comment
|
Impossible bootstrap GN
Reported by
juanka85...@gmail.com,
Jan 24 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36 Steps to reproduce the problem: 1. Bootstrap GN 2. See it 3. What is the expected behavior? Bootstrap gn What went wrong? https://p.teknik.io/Simple/ldQIb Did this work before? Yes 60.0.3329.1 Chrome version: 63.0.3239.108 Channel: canary OS Version: 66.0.3330.0 Flash Version:
,
Jan 24 2018
i'll abort this commit locally
,
Jan 24 2018
i've reverted it and i got a new bug https://p.teknik.io/O286j
,
Jan 24 2018
,
Jan 24 2018
The first issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/884423 But I cannot reproduce the second issue -- after that patch, "gn gen" works fine with the args in your link.
,
Jan 24 2018
failed with the original commit with your patch https://p.teknik.io/wW1jV
,
Jan 24 2018
my systemlibs https://p.teknik.io/8GjH3
,
Jan 24 2018
libwebp 0.6.1
,
Jan 24 2018
NEW TEST my revert + your patch + google webp
,
Jan 24 2018
WORKED GOOGLE WEBP
,
Jan 24 2018
i'll make a last test,
google webp yes
your commit yes
revert "bad commit" no
,
Jan 24 2018
I'm able to reproduce the issue when I unbundle libwebp
,
Jan 24 2018
The libwebp unbundle should work after https://chromium-review.googlesource.com/c/chromium/src/+/884942 Please give it a try
,
Jan 24 2018
test results
,
Jan 24 2018
worked
,
Jan 24 2018
first issue its fixed after https://chromium-review.googlesource.com/c/chromium/src/+/884423 and revert https://chromium.googlesource.com/chromium/src/+/cb4f92cc31ff0e1e598b8e023a40a0409a766a60 webp works after https://chromium-review.googlesource.com/c/chromium/src/+/884942
,
Jan 24 2018
It should work without reverting https://chromium.googlesource.com/chromium/src/+/cb4f92cc31ff0e1e598b8e023a40a0409a766a60 Could you try applying the 2 patches, deleting everything in your out dir, and building again?
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ff7ecf6cd6a9154fad981e083fac96813be5b39 commit 6ff7ecf6cd6a9154fad981e083fac96813be5b39 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Jan 25 00:08:13 2018 Fix libwebp unbundle BUG= 805488 R=thestig Change-Id: I577bf4f5682cffced4f7424768545cc467ad6416 Reviewed-on: https://chromium-review.googlesource.com/884942 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531753} [modify] https://crrev.com/6ff7ecf6cd6a9154fad981e083fac96813be5b39/build/linux/unbundle/libwebp.gn
,
Jan 25 2018
no, it didnt work without revert this commit :( my scheme remove work folder rextract tarball redownload clang work
,
Jan 25 2018
Could you attach the build log
,
Jan 25 2018
,
Jan 25 2018
Not sure why you don't have gtest-internal.h. I see it when I extract the tarball: thomasanderson@thomasanderson:~/dev/chromium_66.0.3330.0$ find . -name gtest-internal.h ./third_party/mesa/src/src/gtest/include/gtest/internal/gtest-internal.h ./third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h ./third_party/swiftshader/third_party/LLVM/utils/unittest/googletest/include/gtest/internal/gtest-internal.h ./third_party/llvm/utils/unittest/googletest/include/gtest/internal/gtest-internal.h ./third_party/libvpx/source/libvpx/third_party/googletest/src/include/gtest/internal/gtest-internal.h ./third_party/boringssl/src/third_party/googletest/include/gtest/internal/gtest-internal.h ./third_party/libaom/source/libaom/third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h ./third_party/vulkan-validation-layers/src/tests/gtest-1.7.0/include/gtest/internal/gtest-internal.h
,
Jan 25 2018
Ok, another cl: https://chromium-review.googlesource.com/c/chromium/src/+/885006 Could you apply this 3rd CL to verify it fixes the issue
,
Jan 25 2018
worked thanks
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b186aa6f4104fe333e4d73b88e06e33abf536bb commit 0b186aa6f4104fe333e4d73b88e06e33abf536bb Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Jan 25 03:04:40 2018 Fix gn bootstrap BUG= 805488 R=dpranke Change-Id: I8a6daa7bbce3fec4eabdeae9b2e7adf7f732813b Reviewed-on: https://chromium-review.googlesource.com/885006 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531798} [modify] https://crrev.com/0b186aa6f4104fe333e4d73b88e06e33abf536bb/tools/gn/bootstrap/bootstrap.py
,
Jan 26 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by juanka85...@gmail.com
, Jan 24 2018