New issue
Advanced search Search tips

Issue 805488 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Impossible bootstrap GN

Reported by juanka85...@gmail.com, Jan 24 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
1. Bootstrap GN
2. See it
3. 

What is the expected behavior?
Bootstrap gn

What went wrong?
https://p.teknik.io/Simple/ldQIb

Did this work before? Yes 60.0.3329.1

Chrome version: 63.0.3239.108  Channel: canary
OS Version: 66.0.3330.0
Flash Version:
 
i'll abort this commit locally  
i've reverted it
and  
i got a new bug

https://p.teknik.io/O286j
Components: -Internals>Installer Tools
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
The first issue should be fixed after
https://chromium-review.googlesource.com/c/chromium/src/+/884423

But I cannot reproduce the second issue -- after that patch, "gn gen" works fine with the args in your link.
failed   with  the original commit

with your patch  https://p.teknik.io/wW1jV

Comment 7 Deleted

my systemlibs
https://p.teknik.io/8GjH3
libwebp 0.6.1
NEW TEST

my  revert + your patch + google webp



WORKED


GOOGLE WEBP


i'll make a last test, 

google webp yes

your commit yes

revert "bad commit" no
    
I'm able to reproduce the issue when I unbundle libwebp
The libwebp unbundle should work after https://chromium-review.googlesource.com/c/chromium/src/+/884942
Please give it a try
test results
analysis.ods
12.9 KB Download
worked
It should work without reverting https://chromium.googlesource.com/chromium/src/+/cb4f92cc31ff0e1e598b8e023a40a0409a766a60

Could you try applying the 2 patches, deleting everything in your out dir, and building again?
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff7ecf6cd6a9154fad981e083fac96813be5b39

commit 6ff7ecf6cd6a9154fad981e083fac96813be5b39
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jan 25 00:08:13 2018

Fix libwebp unbundle

BUG= 805488 
R=thestig

Change-Id: I577bf4f5682cffced4f7424768545cc467ad6416
Reviewed-on: https://chromium-review.googlesource.com/884942
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531753}
[modify] https://crrev.com/6ff7ecf6cd6a9154fad981e083fac96813be5b39/build/linux/unbundle/libwebp.gn

no,  it didnt work without revert this commit :(  

my scheme
remove work folder

rextract tarball
redownload clang
work
Could you attach the build log
Not sure why you don't have gtest-internal.h.  I see it when I extract the tarball:

thomasanderson@thomasanderson:~/dev/chromium_66.0.3330.0$ find . -name gtest-internal.h
./third_party/mesa/src/src/gtest/include/gtest/internal/gtest-internal.h
./third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h
./third_party/swiftshader/third_party/LLVM/utils/unittest/googletest/include/gtest/internal/gtest-internal.h
./third_party/llvm/utils/unittest/googletest/include/gtest/internal/gtest-internal.h
./third_party/libvpx/source/libvpx/third_party/googletest/src/include/gtest/internal/gtest-internal.h
./third_party/boringssl/src/third_party/googletest/include/gtest/internal/gtest-internal.h
./third_party/libaom/source/libaom/third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h
./third_party/vulkan-validation-layers/src/tests/gtest-1.7.0/include/gtest/internal/gtest-internal.h
Ok, another cl:
https://chromium-review.googlesource.com/c/chromium/src/+/885006

Could you apply this 3rd CL to verify it fixes the issue
worked
thanks
Project Member

Comment 26 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b186aa6f4104fe333e4d73b88e06e33abf536bb

commit 0b186aa6f4104fe333e4d73b88e06e33abf536bb
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jan 25 03:04:40 2018

Fix gn bootstrap

BUG= 805488 
R=dpranke

Change-Id: I8a6daa7bbce3fec4eabdeae9b2e7adf7f732813b
Reviewed-on: https://chromium-review.googlesource.com/885006
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531798}
[modify] https://crrev.com/0b186aa6f4104fe333e4d73b88e06e33abf536bb/tools/gn/bootstrap/bootstrap.py

Status: Fixed (was: Assigned)

Sign in to add a comment