Move ownership of the profile_directory to the possible-browsers |
||||
Issue descriptionThis is needed so that profile directory setup can be accomplished by the respective possible_browser *before* actually creating the browser_backend.
,
Jan 25 2018
As part of this, and since they are often used together, e.g. to clear caches, I'm going to move both the browser_directory and profile_directory to the possible-browsers. I'll also take the chance to reorganize and make more uniform the list of args passed to each browser_backend so they always receive args in the following order: - platform_backend, browser_options, browser_directory, profile_directory, [... platform specific args ...]
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/8d63750dfb6f6734aaa66a95f553faa0bc93b703 commit 8d63750dfb6f6734aaa66a95f553faa0bc93b703 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Thu Jan 25 15:13:19 2018 [Telemetry] Migrate Android browser and profile directories These will now be determined by the possible browser, and available on the browser backend as read-only properties. Bug: chromium:805486 Change-Id: Ib764bd1871746d80e543fd628c1be9399870d8b4 Reviewed-on: https://chromium-review.googlesource.com/886781 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/8d63750dfb6f6734aaa66a95f553faa0bc93b703/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py [modify] https://crrev.com/8d63750dfb6f6734aaa66a95f553faa0bc93b703/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/ccee7969d28e16ae40ddfdb61fa97ddd1711a906 commit ccee7969d28e16ae40ddfdb61fa97ddd1711a906 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Fri Jan 26 10:08:15 2018 [Telemetry] Migrate CrOS browser and profile directories These will now be determined by the possible browser, and available on the browser backend as read-only properties. Bug: chromium:805486 Change-Id: I91638911b1b43f28138f090566eac64bd666d174 Reviewed-on: https://chromium-review.googlesource.com/886705 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/ccee7969d28e16ae40ddfdb61fa97ddd1711a906/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py [modify] https://crrev.com/ccee7969d28e16ae40ddfdb61fa97ddd1711a906/telemetry/telemetry/internal/backends/chrome/cros_browser_finder_unittest.py [modify] https://crrev.com/ccee7969d28e16ae40ddfdb61fa97ddd1711a906/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a1d8025b8ed848dc7b6b9155193e51266440bfde commit a1d8025b8ed848dc7b6b9155193e51266440bfde Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Wed Jan 31 09:44:35 2018 [Telemetry] Move profile setup on desktop to its possible browser This CL moves the ownership of the profile_directory to the PossibleDesktopBrowser, which just hands down the value to the DesktopBrowserBackend. The lifetime of the profile directory will now be managed by the SetUp-/CleanUpEnvironment of the possible browser. Bug: chromium:805486 Change-Id: Ifd9499b00601608283cfed134ebda7be46b59cd4 Reviewed-on: https://chromium-review.googlesource.com/886481 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/a1d8025b8ed848dc7b6b9155193e51266440bfde/telemetry/telemetry/internal/browser/possible_browser.py [modify] https://crrev.com/a1d8025b8ed848dc7b6b9155193e51266440bfde/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py [modify] https://crrev.com/a1d8025b8ed848dc7b6b9155193e51266440bfde/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/f384e378fd537075dd9bbd70096bfdefc94e0216 commit f384e378fd537075dd9bbd70096bfdefc94e0216 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Wed Jan 31 15:05:56 2018 [Telemetry] Move last bit of desktop startup args to possible browser Now that the profile directory is owned by the possible browser we can move there too, for the desktop case, the last few bits of startup args computation. Bug: chromium:805486 Bug: chromium:787834 Change-Id: I75203e9dc3a4a1b4a517697306ff2561b0297f04 Reviewed-on: https://chromium-review.googlesource.com/894326 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/f384e378fd537075dd9bbd70096bfdefc94e0216/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py [modify] https://crrev.com/f384e378fd537075dd9bbd70096bfdefc94e0216/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/b1069a4b3a679a7268dafaf8d89c8013e2de7c72 commit b1069a4b3a679a7268dafaf8d89c8013e2de7c72 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Mon Feb 05 16:57:18 2018 [Telemetry] Move browser and profile directories to base chrome backend As the interface is now uniform for all of desktop, cros, and android, access to the browser and profile directories can now be handled by the base ChromeBrowserBackend class. Also tidy up the args for all backends to be consistent and follow the order: platform_backend, browser_options, browser_directory, profile_directory, [... platform specific args ...]. Take the change to move the check of "no exceptions to load when extensions are not supported" to the base class. Bug: chromium:805486 Change-Id: Ic76c8c8566d542f8a7f8a2eb9ab9b5d92807cfa4 Reviewed-on: https://chromium-review.googlesource.com/895444 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/b1069a4b3a679a7268dafaf8d89c8013e2de7c72/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py [modify] https://crrev.com/b1069a4b3a679a7268dafaf8d89c8013e2de7c72/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py [modify] https://crrev.com/b1069a4b3a679a7268dafaf8d89c8013e2de7c72/telemetry/telemetry/internal/backends/browser_backend.py [modify] https://crrev.com/b1069a4b3a679a7268dafaf8d89c8013e2de7c72/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py [modify] https://crrev.com/b1069a4b3a679a7268dafaf8d89c8013e2de7c72/telemetry/telemetry/internal/backends/browser_backend_unittest.py [modify] https://crrev.com/b1069a4b3a679a7268dafaf8d89c8013e2de7c72/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
,
Feb 14 2018
This was also completed.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jan 24 2018