New issue
Advanced search Search tips

Issue 805462 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Edit as HTML should not automatically close editor on blur

Reported by jidanni@gmail.com, Jan 24 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36

Steps to reproduce the problem:
Inspect element > Edit as HTML:
Cannot switch to any other X window without automatically closing editing session

What is the expected behavior?
What if we have to switch to another window to tell an employee a phone number etc.?

What went wrong?
Our Edit HTML session is automatically closed and our changes saved, even if we hadn't finished yet.

Did this work before? N/A 

Chrome version: 63.0.3239.84  Channel: n/a
OS Version: 
Flash Version:
 
Labels: Needs-Triage-M63

Comment 2 by l...@chromium.org, Jan 31 2018

Cc: l...@chromium.org
 Issue 805468  has been merged into this issue.

Comment 3 by l...@chromium.org, Jan 31 2018

Cc: -l...@chromium.org
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: DevTools: Edit as HTML should not automatically close editor on blur (was: inspect element > Edit as HTML > Cannot switch to any other X window without automatically closing editing session)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/528c2aa1224b4ead1b88358cce6599bf29e62de2

commit 528c2aa1224b4ead1b88358cce6599bf29e62de2
Author: Erik Luo <luoe@chromium.org>
Date: Sat Jun 16 00:52:54 2018

DevTools: do not hide HTML editor when switching windows

This CL makes the edit-as-html editor remain open on "blur"
when there is no relatedTarget. This allows switching windows
without closing the editor.

Screenshot: https://imgur.com/a/FT4GxFM

Bug:  805462 
Change-Id: I46f0660f7e25a34bc75be79e179f7666f5a50525
Reviewed-on: https://chromium-review.googlesource.com/1101828
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567845}
[add] https://crrev.com/528c2aa1224b4ead1b88358cce6599bf29e62de2/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/blur-while-edit-as-html-expected.txt
[add] https://crrev.com/528c2aa1224b4ead1b88358cce6599bf29e62de2/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/blur-while-edit-as-html.js
[modify] https://crrev.com/528c2aa1224b4ead1b88358cce6599bf29e62de2/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/switch-panels-while-editing-as-html-expected.txt
[modify] https://crrev.com/528c2aa1224b4ead1b88358cce6599bf29e62de2/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/switch-panels-while-editing-as-html.js
[modify] https://crrev.com/528c2aa1224b4ead1b88358cce6599bf29e62de2/third_party/blink/renderer/devtools/front_end/elements/ElementsTreeElement.js

Comment 5 by l...@chromium.org, Jun 16 2018

Status: Fixed (was: Assigned)

Sign in to add a comment