New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 805442 link

Starred by 1 user
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
penghuang@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

vr_testapp crashes on launch

Project Member Reported by vollick@chromium.org, Jan 24 2018 
The stack trace:
[0124/101525.672283:FATAL:scoped_refptr.h(208)] Check failed: ptr_. 
#0 0x7f6a0c578b9d base::debug::StackTrace::StackTrace()
#1 0x7f6a0c576fdc base::debug::StackTrace::StackTrace()
#2 0x7f6a0c5fdf2a logging::LogMessage::~LogMessage()
#3 0x7f6a0af683f2 scoped_refptr<>::operator->()
#4 0x7f6a0af923c5 base::internal::CallbackBase::polymorphic_invoke()
#5 0x7f6a0af92010 _ZNKR4base17RepeatingCallbackIFvRKN3gfx20PresentationFeedbackEEE3RunES4_
#6 0x7f6a0af93f2a gl::GLSurfacePresentationHelper::CheckPendingFrames()
#7 0x7f6a0af93977 gl::GLSurfacePresentationHelper::PostSwapBuffers()
#8 0x7f6a0afcacf8 gl::NativeViewGLSurfaceEGL::SwapBuffers()
#9 0x0000005b1675 vr::GlRenderer::RenderFrame()

Bisecting shows that this is the CL that introduced the behavior
https://chromium-review.googlesource.com/c/chromium/src/+/870851

It looks like the issue is a missing nullity check when issuing the frame callbacks.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19aa5b252b13ce54c7d18e90e802935faee7aa31

commit 19aa5b252b13ce54c7d18e90e802935faee7aa31
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Jan 24 16:31:43 2018

[vr] Pass a non-null frame callback in the test app

This is now required or we will crash on launch.

Bug:  805442 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib980954a59514fa95869bdc5f0e526fd1bec4001
Reviewed-on: https://chromium-review.googlesource.com/883744
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531553}
[modify] https://crrev.com/19aa5b252b13ce54c7d18e90e802935faee7aa31/chrome/browser/vr/testapp/gl_renderer.cc

Comment 2 by vollick@chromium.org, Jan 24 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, Feb 8 2018

Labels: M-66 Test-Auto
►

Sign in to add a comment