New issue
Advanced search Search tips

Issue 805423 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 805421



Sign in to add a comment

Manual fallback for saving fails if input type changes

Project Member Reported by battre@chromium.org, Jan 24 2018

Issue description

In the following case of JavaScript we fail to offer the manual fallback for saving.

<input type="text" name="admin_psw" id="admin_psw" placeholder="Enter your admin password to confirm">
<input type="submit">

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
<script>$(function(){
    $('#admin_psw').on('input', function(){
        this.type = this.value.length ? 'password' : 'text';
    });
});</script>

https://jsfiddle.net/66afpv7w/

(taken from crbug.com/783755)
 

Comment 1 by battre@chromium.org, Jan 24 2018

Cc: kolos@chromium.org

Comment 2 by kolos@chromium.org, Jan 29 2018

Dominic: what Chrome version did you use? It works for me in 66.0.3335.0 (the icon appears when needed). 

As I understand, your change (IsPasswordFieldForAutofill) fixed it.

Comment 3 by battre@chromium.org, Jan 29 2018

Status: Fixed (was: Available)
Nice, I can confirm that this works with canary.

Sign in to add a comment