Regression: Unnecessary 'More options' overlay stays open after importing password.
Reported by
db...@etouch.net,
Jan 24 2018
|
||||||
Issue descriptionChrome Version: 64.0.3282.119 Revision 5e944b2d79bce5f96dc35a05a76b03d65a6e9a0a-refs/branch-heads/3282@{#589}(32/64 bit) OS: Windows (7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.3), Linux (14.04 LTS). Precondition: Enabled Password export and Password import flags from the chrome://flags What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://settings/passwords page. (2) Click on 'More actions' and then select 'Import' option. (3) Import password and observe. Actual: Unnecessary 'More options' overlay stays open after importing password. Expected: 'More options' overlay should not stays after importing password. This is a regression issue, broken in 'M64' and providing the bisect using per-revision bisect Good Build: 64.0.3268.0(Revision: 516148) Bad Build: 64.0.3269.0(Revision: 516552) You are probably looking for a change made after 516248(known good), but no later than 516249(first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1588705ebeb353d9be5a29e169ea724742ceebdc..a2a5b471a29fdd1f1beafb8d580539f18365364d Suspect: https://chromium.googlesource.com/chromium/src/+/a2a5b471a29fdd1f1beafb8d580539f18365364d Note: Issue is also seen on M65 Dev(#65.0.3322.3) and M66 Canary(#66.0.3329.0)
,
Jan 24 2018
http://crrev/516249 has changed how the buttons are offered. The bug does not apply to the current UI. The feature is behind a flag in M64, therefore no need to merge a fix.
,
Jan 24 2018
The previous comment referred to M64. Wrt to the issue in M65, it has been fixed for M66. http://crrev/518220 is the fix.
,
Jan 24 2018
I was wrong. http://crrev/518220 did not fix the Import button. Submitting a fix now
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/028e18b8891949f75d8c1fa66a5628b253a65719 commit 028e18b8891949f75d8c1fa66a5628b253a65719 Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Jan 24 19:37:18 2018 [Password Manager] Fix 'more options' menu staying open after selecting 'Import' Bug: 805373 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I68d348a2ba7a20c457df833baa514457ae10816f Reviewed-on: https://chromium-review.googlesource.com/883445 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#531645} [modify] https://crrev.com/028e18b8891949f75d8c1fa66a5628b253a65719/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
,
Jan 24 2018
,
Jan 25 2018
Just to Update: Rechecked above issue and it is fixed on Windows (7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.3) and Linux (14.04 LTS) using Latest Canary Build #66.0.3331.0 Kindly review attached screencast. Thank you.
,
Feb 2 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by db...@etouch.net
, Jan 24 2018