New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 805357 link

Starred by 5 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Jan 2018
Cc:
ajha@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to get WiFi password overlay after entering wrong password

Project Member Reported by kebalaji@chromium.org, Jan 24 2018 
Chrome Version: 66.0.3329.0/10336.0.0 dev channel Candy, Peppy & Cyan
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In connect to Network overlay, give any wrong password nearer to the correct password and connect
(2)Observe, only bad password notification is seen after sometime but password overlay is not seen. when trying to click on the WiFi name, again connecting is seen

Expected: Password overlay should be seen along with bad password notification
Actual: Only bad password notification is seen after sometime but password overlay is not seen. when trying to click on the WiFi name, again connecting is seen.
Again need to powerwash the device if we enter wrong password.

This is a Regression issue as same is working fine on 65.0.3322.0/10315.0.0 dev 

NOTE: Issue is not seen on Linux and Windows.

@stevenjb: Please confirm the issue

As it's blocking connecting marking it as dev blocker.
ActualWifiConnecting.mp4
7.9 MB View Download
ExpectedWifiConnecting.mp4
9.1 MB View Download

Comment 1 by kebalaji@chromium.org, Jan 24 2018

Cc: alemate@chromium.org

Comment 2 by steve...@chromium.org, Jan 24 2018

Labels: -M-66 M-65
Status: Started (was: Assigned)
This is an unexpected side effect of https://chromium-review.googlesource.com/875002

Investigating.

Comment 3 by steve...@chromium.org, Jan 25 2018

Cc: steve...@chromium.org
 Issue 794386  has been merged into this issue.

Comment 4 by steve...@chromium.org, Jan 25 2018 

Issue 792726 has been merged into this issue.

Comment 5 by bhthompson@google.com, Jan 29 2018 

Any update on this?

If this regression is worse than the bug the CL in question was trying to fix, should we revert?

We were hoping to do a dev tomorrow and this currently would block that.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 30 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/683176b44b98dc3e63c0868e2fd85dabffed6b8d

commit 683176b44b98dc3e63c0868e2fd85dabffed6b8d
Author: Bernie Thompson <bhthompson@chromium.org>
Date: Tue Jan 30 03:45:18 2018

Revert "NetworkConnectionHandler::ConnectToNetwork: support immediate succeed"

BUG= 805357 

This reverts commit 29fa3fcb5e65ac3985d2093bc11f372081ced1e0.

Change-Id: Idf3230b4244cfd324ab9fb6422416e4d7c1e8721
Reviewed-on: https://chromium-review.googlesource.com/892398
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#166}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chrome/browser/ui/ash/auto_connect_notifier_unittest.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/components/tether/wifi_hotspot_disconnector_impl_unittest.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/network/auto_connect_handler_unittest.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/network/network_connect.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/network/network_connection_handler.h
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/chromeos/network/network_connection_handler_impl_unittest.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/extensions/common/api/networking_private.idl
[modify] https://crrev.com/683176b44b98dc3e63c0868e2fd85dabffed6b8d/extensions/shell/browser/shell_network_controller_chromeos.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e34de0d47fea18a8ee420b199f538f3be29b2dd

commit 8e34de0d47fea18a8ee420b199f538f3be29b2dd
Author: Bernie Thompson <bhthompson@chromium.org>
Date: Tue Jan 30 03:45:32 2018

Revert "Fix network config UI"

BUG= 805357 

This reverts commit 4a5646ee3ab8887eddef734ef87ed808d9d3793f.

Change-Id: I64bac73cd00352391eaa6dd07b931abc2cf9c0e7
Reviewed-on: https://chromium-review.googlesource.com/892560
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#167}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/8e34de0d47fea18a8ee420b199f538f3be29b2dd/chrome/browser/chromeos/net/shill_error.cc
[modify] https://crrev.com/8e34de0d47fea18a8ee420b199f538f3be29b2dd/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/8e34de0d47fea18a8ee420b199f538f3be29b2dd/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/8e34de0d47fea18a8ee420b199f538f3be29b2dd/chromeos/network/network_configuration_handler.cc
[modify] https://crrev.com/8e34de0d47fea18a8ee420b199f538f3be29b2dd/chromeos/network/network_configuration_handler.h
[modify] https://crrev.com/8e34de0d47fea18a8ee420b199f538f3be29b2dd/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/8e34de0d47fea18a8ee420b199f538f3be29b2dd/ui/webui/resources/cr_components/chromeos/network/network_config.js

Comment 8 by kebalaji@chromium.org, Jan 30 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3325.35
Issue is working fine on latest M65- 65.0.3325.35/10323.9.0 dev channel Daisy,Kip,Reks.

Thanks!

Comment 9 by steve...@chromium.org, Jan 30 2018

Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
A powerwash should not have been needed, a reboot should suffice, marking this RBB  instead and un-reverting so I can move forward with the fixes.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b61d0baacc84c17ae74583694020cdf20d62000

commit 7b61d0baacc84c17ae74583694020cdf20d62000
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 30 17:30:05 2018

Revert "Revert "NetworkConnectionHandler::ConnectToNetwork: support immediate succeed""

This reverts commit 683176b44b98dc3e63c0868e2fd85dabffed6b8d.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "NetworkConnectionHandler::ConnectToNetwork: support immediate succeed"
> 
> BUG= 805357 
> 
> This reverts commit 29fa3fcb5e65ac3985d2093bc11f372081ced1e0.
> 
> Change-Id: Idf3230b4244cfd324ab9fb6422416e4d7c1e8721
> Reviewed-on: https://chromium-review.googlesource.com/892398
> Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3325@{#166}
> Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

TBR=stevenjb@chromium.org,tbarzic@chromium.org,bhthompson@chromium.org,rdevlin.cronin@chromium.org,hidehiko@chromium.org

Change-Id: I556935c9d5ebe407b6c2e777a86f1b7a3c12ff77
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  805357 
Reviewed-on: https://chromium-review.googlesource.com/893699
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#172}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chrome/browser/ui/ash/auto_connect_notifier_unittest.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/components/tether/wifi_hotspot_disconnector_impl_unittest.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/network/auto_connect_handler_unittest.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/network/network_connect.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/network/network_connection_handler.h
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/chromeos/network/network_connection_handler_impl_unittest.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/extensions/common/api/networking_private.idl
[modify] https://crrev.com/7b61d0baacc84c17ae74583694020cdf20d62000/extensions/shell/browser/shell_network_controller_chromeos.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6889e929b2af432c31601a5652fd0473e58c3cb

commit e6889e929b2af432c31601a5652fd0473e58c3cb
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 30 20:20:32 2018

Settings/OOBE: Network: Handle connect failures in UI

An unintended side effect of:
https://chromium-review.googlesource.com/875002

is that NetworkingPrivateDelegate::HandleConnectFailed no longer
behaves as expected.

Instead we need to:
* Set check_error_state = true when calling ConnectToNetwork in the
  networkingPrivate implementation.
* Clear any error state when Shill properties are set to ensure that
  a connnection attempt after configuration does not fail when
  check_error_state is true.
* Move configuration handling on error to the UI that calls startConnect.

ALso:
* Show the details dialog when connected networks are selected in OOBE.


This should provide a more robust / consistent experience in both oobe
and the Settings UI.

Bug:  805357 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0030fe5f6f6d054213cec812297829996a73bcfd
Reviewed-on: https://chromium-review.googlesource.com/884846
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533005}
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/extensions/api/networking_private/networking_private_ui_delegate_chromeos.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/extensions/api/networking_private/networking_private_ui_delegate_chromeos.h
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/chromeos/network/network_configuration_handler.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/e6889e929b2af432c31601a5652fd0473e58c3cb/extensions/browser/api/networking_private/networking_private_delegate.h

Comment 12 by steve...@chromium.org, Jan 30 2018

Labels: Merge-Request-65
Merge-Request is to un-revert the original change on M-65 and merge this fix.
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb7a3399779155b008ace9708359ea4ebf62fc0

commit fcb7a3399779155b008ace9708359ea4ebf62fc0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 30 21:43:08 2018

NetworkNotifier: Show config UI on error

Bug:  805357 
Change-Id: Id3a6124a2fab1cfe40598d087aec86d82c567c70
Reviewed-on: https://chromium-review.googlesource.com/887635
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533029}
[modify] https://crrev.com/fcb7a3399779155b008ace9708359ea4ebf62fc0/chrome/browser/chromeos/net/shill_error.cc
[modify] https://crrev.com/fcb7a3399779155b008ace9708359ea4ebf62fc0/chrome/browser/chromeos/net/shill_error.h
[modify] https://crrev.com/fcb7a3399779155b008ace9708359ea4ebf62fc0/chrome/browser/ui/ash/network/network_state_notifier.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/563936b6a4d2eff832721265e5958fcaf92f4135

commit 563936b6a4d2eff832721265e5958fcaf92f4135
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 31 17:51:17 2018

Revert "Revert "Fix network config UI""

This reverts commit 8e34de0d47fea18a8ee420b199f538f3be29b2dd.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Fix network config UI"
> 
> BUG= 805357 
> 
> This reverts commit 4a5646ee3ab8887eddef734ef87ed808d9d3793f.
> 
> Change-Id: I64bac73cd00352391eaa6dd07b931abc2cf9c0e7
> Reviewed-on: https://chromium-review.googlesource.com/892560
> Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3325@{#167}
> Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}

TBR=stevenjb@chromium.org,tbarzic@chromium.org,bhthompson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  805357 
Change-Id: I8049fc0e5f1c335ce205a0e5102ef91076bfdb79
Reviewed-on: https://chromium-review.googlesource.com/894833
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#202}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/563936b6a4d2eff832721265e5958fcaf92f4135/chrome/browser/chromeos/net/shill_error.cc
[modify] https://crrev.com/563936b6a4d2eff832721265e5958fcaf92f4135/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/563936b6a4d2eff832721265e5958fcaf92f4135/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/563936b6a4d2eff832721265e5958fcaf92f4135/chromeos/network/network_configuration_handler.cc
[modify] https://crrev.com/563936b6a4d2eff832721265e5958fcaf92f4135/chromeos/network/network_configuration_handler.h
[modify] https://crrev.com/563936b6a4d2eff832721265e5958fcaf92f4135/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/563936b6a4d2eff832721265e5958fcaf92f4135/ui/webui/resources/cr_components/chromeos/network/network_config.js

Comment 15 by steve...@chromium.org, Jan 31 2018 

So, I apologize, I was confused before and a) only noticed the first revert, b) didn't notice the revert was only on the branch, so I ended up reverting only one change, on the branch. So now we are in a confusing state, but here is where we are:

ToT (66):

NetworkConnectionHandler...immediate succeed ( issue 795715 )
... a few VPN issues that *hopefully* don't conflict with anything ...
Fix network config UI ( issue 795715 ,  issue 795698 )
... a few network config CLs that hopefuly don't conflict...
Network config: Connect on password enter ( issue 804274 )
Network details dialog: Add 'loading' string ( issue 804698 )
Settings: Network proxy: fix 'allow shared proxies' visibility (issue 798553)
Network: Fix edge case causing a crash (issue 805322)
Settings/OOBE: Network: Handle connect failures in UI (this issue)
Elim unused NetworkConnect function (cleanup)
NetworkNotifier: Show config UI on error (this issue)
... 
Branch (65):

NetworkConnectionHandler...immediate succeed ( issue 795715 )
... a few VPN issues that *hopefully* don't conflict with anything ...
Fix network config UI ( issue 795715 ,  issue 795698 )
... a few network config CLs that hopefuly don't conflict...
Network config: Connect on password enter
REVERT: NetworkConnectionHandler...immediate succeed
REVERT: Fix network config UI
REVERT: REVERT: NetworkConnectionHandler...immediate succeed
REVERT: REVERT: Fix network config UI

Now, to get things back to working I will merge (in order to avoid conflicts):

Network details dialog: Add 'loading' string ( issue 804698 , merge approved)
* Settings: Network proxy: fix 'allow shared proxies' visibility (issue 798553, merge TBD)
(Network: Fix edge case causing a crash (issue 805322, merge TBD, order independent)
Settings/OOBE: Network: Handle connect failures in UI (this issue)
Elim unused NetworkConnect function (cleanup)
NetworkNotifier: Show config UI on error (this issue)
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b12b41d529bcc4664c72152ff74da3ff8a834f1d

commit b12b41d529bcc4664c72152ff74da3ff8a834f1d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 31 18:50:57 2018

Settings/OOBE: Network: Handle connect failures in UI

An unintended side effect of:
https://chromium-review.googlesource.com/875002

is that NetworkingPrivateDelegate::HandleConnectFailed no longer
behaves as expected.

Instead we need to:
* Set check_error_state = true when calling ConnectToNetwork in the
  networkingPrivate implementation.
* Clear any error state when Shill properties are set to ensure that
  a connnection attempt after configuration does not fail when
  check_error_state is true.
* Move configuration handling on error to the UI that calls startConnect.

ALso:
* Show the details dialog when connected networks are selected in OOBE.


This should provide a more robust / consistent experience in both oobe
and the Settings UI.

TBR=stevenjb@chromium.org

(cherry picked from commit e6889e929b2af432c31601a5652fd0473e58c3cb)

Bug:  805357 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0030fe5f6f6d054213cec812297829996a73bcfd
Reviewed-on: https://chromium-review.googlesource.com/884846
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533005}
Reviewed-on: https://chromium-review.googlesource.com/895054
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#209}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/extensions/api/networking_private/networking_private_ui_delegate_chromeos.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/extensions/api/networking_private/networking_private_ui_delegate_chromeos.h
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/chromeos/network/network_configuration_handler.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/b12b41d529bcc4664c72152ff74da3ff8a834f1d/extensions/browser/api/networking_private/networking_private_delegate.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf1f334ad0626be7e5478c3363a55614d1151b6

commit 5cf1f334ad0626be7e5478c3363a55614d1151b6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 31 19:11:20 2018

NetworkNotifier: Show config UI on error

TBR=stevenjb@chromium.org

(cherry picked from commit fcb7a3399779155b008ace9708359ea4ebf62fc0)

Bug:  805357 
Change-Id: Id3a6124a2fab1cfe40598d087aec86d82c567c70
Reviewed-on: https://chromium-review.googlesource.com/887635
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533029}
Reviewed-on: https://chromium-review.googlesource.com/895911
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#212}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/5cf1f334ad0626be7e5478c3363a55614d1151b6/chrome/browser/chromeos/net/shill_error.cc
[modify] https://crrev.com/5cf1f334ad0626be7e5478c3363a55614d1151b6/chrome/browser/chromeos/net/shill_error.h
[modify] https://crrev.com/5cf1f334ad0626be7e5478c3363a55614d1151b6/chrome/browser/ui/ash/network/network_state_notifier.cc

Comment 18 by steve...@chromium.org, Jan 31 2018

Status: Fixed (was: Started)
All merges are done.
Project Member

Comment 19 by sheriffbot@chromium.org, Jan 31 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 20 by nyerramilli@chromium.org, Feb 2 2018

Labels: Inhouse-HYD-Reported

Comment 21 by steve...@chromium.org, Feb 5 2018

Labels: -Merge-Approved-65 Merge-Merged
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0afa801a9d3187e9bb2d5517ef40d8863835a8a1

commit 0afa801a9d3187e9bb2d5517ef40d8863835a8a1
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Feb 08 19:08:38 2018

Fix network details dialog strings

These strings were not being loaded for the details dialog which also
uses them.

TBR=stevenjb@chromium.org

(cherry picked from commit fad3e236b9a3531074299c59929bc3b63ad6996b)

Bug:  805357 
Change-Id: I0ed1753b96461fc09e45e1df6ab665dae8bd3cb7
Reviewed-on: https://chromium-review.googlesource.com/897914
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533726}
Reviewed-on: https://chromium-review.googlesource.com/902444
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#382}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/0afa801a9d3187e9bb2d5517ef40d8863835a8a1/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
►

Sign in to add a comment