New issue
Advanced search Search tips

Issue 805340 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::BoxPainter::PaintMaskImages

Project Member Reported by ClusterFuzz, Jan 24 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4654747578793984

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000a0
Crash State:
  blink::BoxPainter::PaintMaskImages
  blink::TableCellPainter::PaintMask
  blink::LayoutTableCell::PaintMask
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=531437:531438

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4654747578793984

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 24 2018

Components: Blink>Layout Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 24 2018

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/05f80f7a4125ae48603ae5fbda1fe1b64a059673 ([SPv175] Use kSrcOver to paint inline mask).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Jan 24 2018

Labels: M-65 ReleaseBlock-Beta ClusterFuzz-Top-Crash
Testcase 4654747578793984 is a top crash on ClusterFuzz for linux platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: wangxianzhu@chromium.org
 Issue 805347  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b21a2f22aff789ca26cb3bc559a2ab43e3e90de

commit 3b21a2f22aff789ca26cb3bc559a2ab43e3e90de
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Jan 24 16:45:09 2018

Revert "[SPv175] Use kSrcOver to paint inline mask"

This reverts commit 05f80f7a4125ae48603ae5fbda1fe1b64a059673.

Reason for revert:  crbug.com/805340 

Bug:  805340 

Original change's description:
> [SPv175] Use kSrcOver to paint inline mask
> 
> Previously we may used kDstIn which composited the mask painting
> directly with the masked contents. However, for SPv175 we'll issue
> the compositing op in PaintChunkToCcLayer so we should use kDstIn
> during painting.
> 
> Bug:  771643 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I526fd06425d545a526f0a8413e74712ee1f4647f
> Reviewed-on: https://chromium-review.googlesource.com/882302
> Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531438}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org

Change-Id: I406a6018430506eeea91cde18e0aaf196315290b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  771643 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/884102
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531558}
[modify] https://crrev.com/3b21a2f22aff789ca26cb3bc559a2ab43e3e90de/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/8eb4ed812199b6a8c0ea677b5e6243eb54248f94/third_party/WebKit/LayoutTests/virtual/spv175/fast/borders/inline-mask-overlay-image-outset-expected.png
[modify] https://crrev.com/3b21a2f22aff789ca26cb3bc559a2ab43e3e90de/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/3b21a2f22aff789ca26cb3bc559a2ab43e3e90de/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
[modify] https://crrev.com/3b21a2f22aff789ca26cb3bc559a2ab43e3e90de/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/3b21a2f22aff789ca26cb3bc559a2ab43e3e90de/third_party/WebKit/Source/core/paint/PaintLayer.h

Project Member

Comment 6 by ClusterFuzz, Jan 24 2018

Labels: OS-Windows
Project Member

Comment 7 by ClusterFuzz, Jan 24 2018

Labels: OS-Mac
Project Member

Comment 8 by ClusterFuzz, Jan 25 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5931648872087552 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 10 by ClusterFuzz, Jan 25 2018

ClusterFuzz has detected this issue as fixed in range 531556:531559.

Detailed report: https://clusterfuzz.com/testcase?key=4654747578793984

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000a0
Crash State:
  blink::BoxPainter::PaintMaskImages
  blink::TableCellPainter::PaintMask
  blink::LayoutTableCell::PaintMask
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=531437:531438
Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=531556:531559

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4654747578793984

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -Merge-TBD -M-65
The break happened after m65 branch.

Sign in to add a comment