New issue
Advanced search Search tips

Issue 805319 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Get rid of KioskVirtualKeyboardTestSoundsManagerTestImpl in test

Project Member Reported by fqj@google.com, Jan 24 2018

Issue description


 Issue 429094  merged all non-real implementation of SessionManagerClient into FakeSesisionManagerClient.

This merge will let SessionManagerStubClient observers start to receive notifications. It triggers SoundsManager::Play during this observer emission.

AudioStreamHandler will use its stored pointer to AudioManager (stored during initialization, which stores the real one) instead of AudioManager::Get() AudioManager (which is the mock one created for test).

KioskVirtualKeyboardTestSoundsManagerTestImpl is created to workaround AudioStreamHandler intentially keeping copy of pointer to real AudioManager.


But a better solution could be:
1) move initialization of MockAudioManager into SetUp
2) modify AudioManager to let real AudioManager not overriding MockAudioManager if already initialized.


 

Comment 1 by f...@chromium.org, Jan 24 2018

Components: Internals
Labels: -OS-Linux OS-Chrome

Sign in to add a comment