Issue metadata
Sign in to add a comment
|
NetworkService with OOPIF: Parent or opener might be a remote frame in RFI::GetSubresourceLoaderFactories() |
||||||||||||||||||||||||
Issue descriptionhttp/tests/devtools/network/oopif-content.js crashing with: crash log for renderer (pid <unknown>): STDOUT: #CRASHED - renderer STDERR: [1:1:0122/134850.836529:FATAL:render_frame_impl.cc(6512)] Check failed: creator. STDERR: #0 0x00000311863c base::debug::StackTrace::StackTrace() STDERR: #1 0x000003137713 logging::LogMessage::~LogMessage() STDERR: #2 0x000006073038 content::RenderFrameImpl::GetSubresourceLoaderFactories() STDERR: #3 0x000006078c78 content::RenderFrameImpl::FrameURLLoaderFactory::CreateURLLoader() STDERR: #4 0x000005881f07 blink::FrameFetchContext::CreateURLLoader() STDERR: #5 0x0000027ad70a blink::ResourceLoader::Start() STDERR: #6 0x000002795c66 blink::ResourceFetcher::StartLoad() STDERR: #7 0x00000279458d blink::ResourceFetcher::RequestResource() STDERR: #8 0x000002793e34 blink::ResourceFetcher::RequestResource() STDERR: #9 0x00000277c8ee blink::RawResource::Fetch() STDERR: #10 0x00000560de76 blink::InspectorResourceContentLoader::Start() STDERR: #11 0x00000560eadc blink::InspectorResourceContentLoader::EnsureResourcesContentLoaded() STDERR: #12 0x000005592701 blink::InspectorCSSAgent::enable() STDERR: #13 0x000001c3722c blink::protocol::CSS::DispatcherImpl::enable() STDERR: #14 0x000001c279e1 blink::protocol::Accessibility::DispatcherImpl::dispatch() STDERR: #15 0x000001c7f3e1 blink::protocol::UberDispatcher::dispatch() STDERR: #16 0x000005611eb4 blink::InspectorSession::DispatchProtocolMessage() STDERR: #17 0x0000052e54a2 blink::WebDevToolsAgentImpl::Session::DispatchProtocolMessage() STDERR: #18 0x0000027237ae blink::mojom::blink::DevToolsSessionStubDispatch::Accept() STDERR: #19 0x00000330ec57 mojo::InterfaceEndpointClient::HandleValidatedMessage() STDERR: #20 0x0000033115d6 mojo::FilterChain::Accept() STDERR: #21 0x000003310122 mojo::InterfaceEndpointClient::HandleIncomingMessage() STDERR: #22 0x000003343472 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread() STDERR: #23 0x000003341231 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE3RunEPNS0_13BindStateBaseE STDERR: #24 0x00000311a63a base::debug::TaskAnnotator::RunTask() STDERR: #25 0x0000027e24cc blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() STDERR: #26 0x0000027e1a17 blink::scheduler::TaskQueueManager::DoWork() STDERR: #27 0x0000017f5828 _ZN4base8internal7InvokerINS0_9BindStateIMN7content17ResourceScheduler24ScheduledResourceRequestEFvNS3_12_GLOBAL__N_19StartModeEEJNS_7WeakPtrIS5_EES7_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE STDERR: #28 0x00000311a63a base::debug::TaskAnnotator::RunTask() STDERR: #29 0x0000027e8328 blink::scheduler::internal::ThreadControllerImpl::DoWork() STDERR: #30 0x0000017f5828 _ZN4base8internal7InvokerINS0_9BindStateIMN7content17ResourceScheduler24ScheduledResourceRequestEFvNS3_12_GLOBAL__N_19StartModeEEJNS_7WeakPtrIS5_EES7_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE STDERR: #31 0x00000311a63a base::debug::TaskAnnotator::RunTask() STDERR: #32 0x00000313ea56 base::internal::IncomingTaskQueue::RunTask() STDERR: #33 0x00000313ce87 base::MessageLoop::RunTask() STDERR: #34 0x00000313d2a4 base::MessageLoop::DeferOrRunPendingTask() STDERR: #35 0x00000313d568 base::MessageLoop::DoWork() STDERR: #36 0x000003141120 base::MessagePumpDefault::Run() STDERR: #37 0x00000313c6dc base::MessageLoop::Run() STDERR: #38 0x000003165406 base::RunLoop::Run() STDERR: #39 0x0000065f4c9b content::RendererMain() STDERR: #40 0x0000028618b3 content::RunZygote() STDERR: #41 0x0000028620fb content::RunNamedProcessTypeMain() STDERR: #42 0x000002863027 content::ContentMainRunnerImpl::Run() STDERR: #43 0x00000482cbd4 service_manager::Main() STDERR: #44 0x000001c1ca81 content::ContentMain() STDERR: #45 0x00000143a151 main STDERR: #46 0x7fe9fba3cf45 __libc_start_main STDERR: #47 0x00000143a02a _start STDERR:
,
Jan 24 2018
I am updating this part of code while merging URLLoaderFactoryBundle and ChildURLLoaderFactoryGetter. I changed this logic to: if creator is null, then use a default bundle, which only includes the direct network loader factory and (maybe) blob loader factory provided by renderer_blink_platform_impl. Please see https://chromium-review.googlesource.com/c/chromium/src/+/882606/4/content/renderer/render_frame_impl.cc#6489 Does this change make sense? (We could continue the discussion on that CL.)
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e10dc0198757b62a80bd8d32ce4dc88eacd109 commit 18e10dc0198757b62a80bd8d32ce4dc88eacd109 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Fri Jan 26 18:08:51 2018 NetworkService sheriff: update layout test expectation http/tests/devtools/network/oopif-targets.js failing since it's added in r531805 Looks like the same reason as the other oopif test (DCHECK(creator) crash in RFI::GetSubresourceLoaderFactories). TBR=yzshen@chromium.org NOTRY=true Bug: 805310 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9c2e957986ba3756e6d0c3f51a9135d426f601a5 Reviewed-on: https://chromium-review.googlesource.com/888227 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532015} [modify] https://crrev.com/18e10dc0198757b62a80bd8d32ce4dc88eacd109/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57acbdd7559afdc9b7fc3389a240ac6f54156eb9 commit 57acbdd7559afdc9b7fc3389a240ac6f54156eb9 Author: Chong Zhang <chongz@chromium.org> Date: Mon Feb 26 22:57:00 2018 NetworkService sheriff: update layout test expectation http/tests/devtools/oopif/oopif-cookies-refresh.js failing since it's added in r539268 http/tests/devtools/network/oopif-targets.js turned into flaky instead of crash. (The original DCHECK was changed) TBR=kinuko@chromium.org NOTRY=true Bug: 805310 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I92e5b76383a0b882459e0f4853269a12c1eb8de9 Reviewed-on: https://chromium-review.googlesource.com/938649 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539302} [modify] https://crrev.com/57acbdd7559afdc9b7fc3389a240ac6f54156eb9/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c897eb808ca8cba689bcc9ca2245ecf8cd44c7c commit 2c897eb808ca8cba689bcc9ca2245ecf8cd44c7c Author: Andrey Kosyakov <caseq@chromium.org> Date: Mon Mar 19 23:54:48 2018 Remove expectation entries for devtools tests passing with --enable-features=NetworkService TBR=jam@chromium.org, pfeldman@chromium.org Bug: 721408 , 805310 , 778542 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icdb98586e6e2ae53802c1e4d2f2fa3b66a6247fa Reviewed-on: https://chromium-review.googlesource.com/969329 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544214} [modify] https://crrev.com/2c897eb808ca8cba689bcc9ca2245ecf8cd44c7c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
May 17 2018
,
May 17 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 24 2018