New issue
Advanced search Search tips

Issue 805292 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

hittesting/image-with-clip-path.html is flaky

Project Member Reported by tasak@google.com, Jan 24 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e56bdf9bbe6577cefb0cdfb597151dbeae147e

commit 67e56bdf9bbe6577cefb0cdfb597151dbeae147e
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Wed Jan 24 05:44:34 2018

Gardening: mark hittesting/image-with-clip-path.html as flaky.

BUG= 805292 
TBR=joedow

Change-Id: Iddf224bb5fad3ab60fa3c63320a5843b3a916f77
Reviewed-on: https://chromium-review.googlesource.com/883062
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#531446}
[modify] https://crrev.com/67e56bdf9bbe6577cefb0cdfb597151dbeae147e/third_party/WebKit/LayoutTests/TestExpectations

Cc: rhalavati@google.com
 Issue 805386  has been merged into this issue.
Disabling the test in crrev.com/c/883363 as Sherrif.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a77280b208fa567f6d86e2f4ebf64479024c0f6f

commit a77280b208fa567f6d86e2f4ebf64479024c0f6f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Jan 24 12:19:08 2018

Mark flaky WebKitLayoutTest as Skip.

hittesting/image-with-clip-path.html occasionally crashes. It's marked
as 'Skip'.

Bug:  805292 
Change-Id: I1f94a1994ab56676db355db2c100990685eb0ef6
TBR: schenney
Reviewed-on: https://chromium-review.googlesource.com/883363
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531504}
[modify] https://crrev.com/a77280b208fa567f6d86e2f4ebf64479024c0f6f/third_party/WebKit/LayoutTests/TestExpectations

Cc: -rhalavati@google.com rhalavati@chromium.org
Labels: -Sheriff-Chromium
Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)
Hi Stephen,

Please take a look at this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5931d84f2f3947e0f39206bc3afc05d3ba51d26

commit d5931d84f2f3947e0f39206bc3afc05d3ba51d26
Author: Fredrik Söderquist <fs@opera.com>
Date: Thu Sep 06 12:10:29 2018

Unskip hittesting/image-with-clip-path.html

To have a chance of seeing what might be problem here (if it still
exists) we need some historical data, since there appear to be no
obvious issues with the test as such.

Bug:  805292 
Change-Id: Iccbb92e2a324533858ee42802eaa2fa7ebc2240c
Reviewed-on: https://chromium-review.googlesource.com/1209363
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589139}
[modify] https://crrev.com/d5931d84f2f3947e0f39206bc3afc05d3ba51d26/third_party/WebKit/LayoutTests/TestExpectations

This test has not flaked since it was re-enabled, so maybe we should consider removing the expectation.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdabf0ef9845a30a88ada470b4d9f4c388e58a60

commit cdabf0ef9845a30a88ada470b4d9f4c388e58a60
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Sep 17 10:27:51 2018

Update expectation for hittesting/image-with-clip-path.html

This test has not been flaking since it was re-enabled over a week ago.

TBR=schenney@chromium.org

Bug:  805292 
Change-Id: I27fed5ac7e66b937d63adfec6f11f320e2ab7437
Reviewed-on: https://chromium-review.googlesource.com/1225986
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#591632}
[modify] https://crrev.com/cdabf0ef9845a30a88ada470b4d9f4c388e58a60/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment