Issue metadata
Sign in to add a comment
|
Reload button is enabled in incognito in landscape mode. |
||||||||||||||||||||||
Issue descriptionApp Version: 66.0.3329.0 canary iOS Version: 11.2.2 Device : iPhone 7+,8+ Steps to reproduce : Scenario 1 : 1. Launch chrome in landscape mode. 2. Tap on Menu > Tap on New incognito tab. Observed results: Reload button is enabled in landscape mode. Expected results: Reload button should not be enabled in Incognito landing page Image : https://drive.google.com/file/d/1kINxTApF-jKS5NR6mEfjpaVRbsR5B5Hp/view?usp=sharing Scenario 2 : 1. Launch chrome in landscape mode. 2. Perform any search (say : iPhonex) 3. Tap on Menu Observed results: At step 2 : Share button and Reload buttons are present beside omnibox in landscape mode. At Step 3 : Share button and Reload buttons are displayed in Menu options Expected Results : Reload and share button should not be displayed in two places. Image: https://drive.google.com/file/d/1M-W0SOz1YnvWQ1ha9NDlmm9qGFFvqBqA/view?usp=sharing Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): No in M63 Bug reproducible on the current beta channel build (App Version, iOS Version): No in M64 and 65
,
Jan 24 2018
Yes issue can be reproduced in M65 beta.
,
Jan 24 2018
Thanks!
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f11507a8e16c4c684b0e4aa5dfbd315054e520ba commit f11507a8e16c4c684b0e4aa5dfbd315054e520ba Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jan 24 11:24:34 2018 Update CleanToolbar button visibility This CL updates the visibility of the button of the clean toolbar to take into account the specific of iPhone + in landscape. Bug: 805289 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib248a7c396a8aed325dbac3fc153f1220819b2bb Reviewed-on: https://chromium-review.googlesource.com/882327 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#531499} [modify] https://crrev.com/f11507a8e16c4c684b0e4aa5dfbd315054e520ba/ios/chrome/browser/ui/toolbar/clean/toolbar_button.mm [modify] https://crrev.com/f11507a8e16c4c684b0e4aa5dfbd315054e520ba/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.mm [modify] https://crrev.com/f11507a8e16c4c684b0e4aa5dfbd315054e520ba/ios/chrome/browser/ui/toolbar/clean/toolbar_component_options.h
,
Jan 24 2018
,
Jan 24 2018
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52fef2c79ff98d282672c5f598cd5d2368b416b8 commit 52fef2c79ff98d282672c5f598cd5d2368b416b8 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Jan 25 13:02:34 2018 Update CleanToolbar button visibility This CL updates the visibility of the button of the clean toolbar to take into account the specific of iPhone + in landscape. Bug: 805289 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib248a7c396a8aed325dbac3fc153f1220819b2bb Reviewed-on: https://chromium-review.googlesource.com/882327 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531499}(cherry picked from commit f11507a8e16c4c684b0e4aa5dfbd315054e520ba) Reviewed-on: https://chromium-review.googlesource.com/886581 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#90} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/52fef2c79ff98d282672c5f598cd5d2368b416b8/ios/chrome/browser/ui/toolbar/clean/toolbar_button.mm [modify] https://crrev.com/52fef2c79ff98d282672c5f598cd5d2368b416b8/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.mm [modify] https://crrev.com/52fef2c79ff98d282672c5f598cd5d2368b416b8/ios/chrome/browser/ui/toolbar/clean/toolbar_component_options.h
,
Jan 25 2018
Issue verified on Chrome Canary Version: Chrome Canary 66.0.3331.0 Device: iPhone 6+ iOS: 10.3.3 Reload button is not be enabled in Incognito landing page https://drive.google.com/open?id=13p5tBmQHz4DrCofGOgXxCImRJp3Q1lFz
,
Jan 31 2018
Verified on chrome beta version 65.0.3325.36 on iPhone 8 plus and iPhone 7 plus with iOS 11.2.5, following steps mentioned in comment #0. Refresh button is not displayed in incognito mode. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gambard@chromium.org
, Jan 24 2018