Issue metadata
Sign in to add a comment
|
Tabs cannot be dragged to another window
Reported by
cowb...@gmail.com,
Jan 24 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3329.1 Safari/537.36 Steps to reproduce the problem: 1. Open two Chrome windows 2. Attempt to drag the tab from one window to another (be sure to release the tab) What is the expected behavior? The tab merges into the list of tabs for the targeted window. What went wrong? The tab rapidly shakes from left to right and then closes itself before merging into the tabs for the targeted window. Did this work before? Yes Chrome version: 66.0.3329.1 Channel: canary OS Version: OS X 10.13.2 Flash Version:
,
Jan 24 2018
Confirmed. I'm guessing that this is from https://chromium-review.googlesource.com/852978.
,
Jan 24 2018
Issue 805596 has been merged into this issue.
,
Jan 24 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75530210896c576464104e17b8dbc29851baf26d commit 75530210896c576464104e17b8dbc29851baf26d Author: Jayson Adams <shrike@chromium.org> Date: Wed Jan 24 23:36:24 2018 [Mac] Fix tab dragging breakage after window controller rework. https://chromium-review.googlesource.com/c/chromium/src/+/852978 routes all Tab- and BrowserWindowController requests through a convenience method that queries the provided window and its parent. This change broke code that assumed the window controller search would not include the parent window or any other ancestors. Bug: 805282 Change-Id: Ib2ac4817b2582836f34b7fc3755b0e324bb49c13 Reviewed-on: https://chromium-review.googlesource.com/884661 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/master@{#531745} [modify] https://crrev.com/75530210896c576464104e17b8dbc29851baf26d/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/75530210896c576464104e17b8dbc29851baf26d/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm [modify] https://crrev.com/75530210896c576464104e17b8dbc29851baf26d/chrome/browser/ui/cocoa/tabs/tab_window_controller.h
,
Jan 24 2018
Issue 805318 has been merged into this issue.
,
Jan 25 2018
Tested this issue on Mac OS 10.13.1 on the latest Chrome Build 66.0.3331.0 by following the steps mentioned in the original comment. On dragging a tab from one windows to another, can observe the tab is merging well into the new window without any shake Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Jan 25 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by susanjun...@techmahindra.com
, Jan 24 2018