New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805266 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 810205

Blocking:
issue 665468



Sign in to add a comment

Files app UI: Refresh view when archive file unmounted by errors

Project Member Reported by yamaguchi@chromium.org, Jan 24 2018

Issue description

Chrome Version: 66.0.3330.0

Steps To Reproduce:
(1) Open a zip file. See the file is mounted and the contents is displayed.
(2) Remove the zip file.
(3) Go to the zip volume.
(4) try to open a file/directory in it.

Expected Result:
The mounted zip volume should disappear from the left pane of all Files app windows after step 2.

Actual Result:
It only happens after step 4.


How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
100%

 
Blocking: 665468
Labels: Hotlist-GoodFirstBug
Owner: sashab@chromium.org
Status: Started (was: Available)
Blockedon: 810205
When bug 810205 is fixed, the fix for this could be in file_operation_manager.js:

In FileOperationManager.prototype.serviceDeleteTask_, add the following code or similar:

          var deletedFile = task.entries[0];
          var volumeEntries = this.volumeManager_.volumeInfoList;
          for (var i = 0; i < volumeEntries.length; i++) {
            // Check if we deleted the archive file, or any ancestor directory.
            if (util.isSamePath(deletedFile.path, volumeEntries.entry(i).source_path) || util.isPathPrefixOf(volumeEntries.entry(i).source_path, deletedFile.path)) {
              // Unmount the volume here.
            }
          }

Comment 5 Deleted

Comment 6 Deleted

Comment 7 Deleted

Comment 8 by sashab@chromium.org, Feb 15 2018

Labels: -CrOSFilesApp-Zip CrOS-FilesApp-Zip

Comment 9 by sashab@chromium.org, Feb 15 2018

Labels: -Hotlist-GoodFirstBug
Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip
Labels: M-67
Adding this as P3 to M67 since it becomes trivial once issue 805266 is solved.
Labels: -M-67 M-68

Comment 13 by dats@chromium.org, Apr 18 2018

Cc: durga.behera@chromium.org ajha@chromium.org yamaguchi@chromium.org rponnada@chromium.org kinaba@chromium.org mtomasz@chromium.org
 Issue 453273  has been merged into this issue.

Comment 14 by sashab@google.com, May 24 2018

Labels: -M-68 M-69

Comment 15 by sashab@google.com, May 24 2018

Owner: noel@chromium.org
Hi Noel, assigning to you as new owner of Zip, I've done some work on these so we can catch up about them if needed.
Labels: -M-69
Status: Assigned (was: Started)
Cc: -kinaba@chromium.org noel@chromium.org
Owner: amistry@chromium.org
No, I just know how to spell zip, thanks for asking. 

amistry@ you wanna try one of these?  See #4, not sure whether it's a useful hint or not these days.

And send it back for re-assignment if you feel that way too.
Owner: noel@chromium.org
It's tricky to fix with the FSP and so many layers involved.

I think the repro steps are unlikely to happen in normal day-to-day usage. It's an edge case and I think this should be low priority.

Sign in to add a comment