New issue
Advanced search Search tips

Issue 805248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: reloading page with multiple / nested out-of-process iframes halts reload

Project Member Reported by pfeldman@chromium.org, Jan 24 2018

Issue description

- Find a page with multiple oopifs
- Open devtools, observe several dom trees in the elements
- Reload page

Actual: some of the iframes never finish loading.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8e335abf5558708b20d892d6fbc5c76f5a84c6a

commit a8e335abf5558708b20d892d6fbc5c76f5a84c6a
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Thu Jan 25 03:41:21 2018

DevTools: don't update all frames aggresively upon render frame swap.

We used to detach from targets aggressively because of the timing of the
UpdateFrames call. Current frame host was still non-cross-process and hence
was detached from. This change migrates from bulk-frame update to treating
render frame host swap in AutoAttachToFrame.

Bug:  805248 
Change-Id: Id6c8a665676167fea5048c23db20cfc8fafd86f1
Reviewed-on: https://chromium-review.googlesource.com/882167
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531805}
[modify] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/content/browser/devtools/protocol/target_auto_attacher.cc
[modify] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/content/browser/devtools/protocol/target_auto_attacher.h
[modify] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/content/browser/devtools/protocol/target_handler.cc
[modify] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/content/browser/devtools/render_frame_devtools_agent_host.h
[add] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets-expected.txt
[add] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets.js
[add] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/iframe.html
[add] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/inner-iframe.html
[add] https://crrev.com/a8e335abf5558708b20d892d6fbc5c76f5a84c6a/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/page.html

Labels: Merge-Request-65
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 30 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Jan 30 2018

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63b964362f5466780cb6a8ff35f4b503b37f09cc

commit 63b964362f5466780cb6a8ff35f4b503b37f09cc
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Wed Jan 31 18:54:35 2018

DevTools: don't update all frames aggresively upon render frame swap.

We used to detach from targets aggressively because of the timing of the
UpdateFrames call. Current frame host was still non-cross-process and hence
was detached from. This change migrates from bulk-frame update to treating
render frame host swap in AutoAttachToFrame.

TBR=pfeldman@chromium.org

(cherry picked from commit a8e335abf5558708b20d892d6fbc5c76f5a84c6a)

Bug:  805248 
Change-Id: Id6c8a665676167fea5048c23db20cfc8fafd86f1
Reviewed-on: https://chromium-review.googlesource.com/882167
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531805}
Reviewed-on: https://chromium-review.googlesource.com/895908
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#210}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/content/browser/devtools/protocol/target_auto_attacher.cc
[modify] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/content/browser/devtools/protocol/target_auto_attacher.h
[modify] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/content/browser/devtools/protocol/target_handler.cc
[modify] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/content/browser/devtools/render_frame_devtools_agent_host.h
[add] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets-expected.txt
[add] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-targets.js
[add] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/iframe.html
[add] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/inner-iframe.html
[add] https://crrev.com/63b964362f5466780cb6a8ff35f4b503b37f09cc/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/page.html

Status: Fixed (was: Assigned)
Cc: creis@chromium.org

Comment 8 by creis@chromium.org, Mar 14 2018

Components: Internals>Sandbox>SiteIsolation

Sign in to add a comment