New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805219 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 805218



Sign in to add a comment

Add metric for effective GATT connection success rate

Project Member Reported by khorimoto@chromium.org, Jan 24 2018

Issue description

Effective success rate, in this context, refers to the success rate of making a GATT connection including retry attempts.
 
Owner: khorimoto@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d87e25edb2924948b728832225c7097e5a8b9ef7

commit d87e25edb2924948b728832225c7097e5a8b9ef7
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Feb 01 01:55:04 2018

[CrOS Tether] Add metrics for GATT connection success/failures.

This CL adds two metrics:
  (1) Success rate for GATT connection attempts.
  (2) Effective success rate for one or multiple connection attempts,
      using retries if a previous connection failed (up to the maximum
      number of retries).

These metrics aid in our ability to analyze what our effective
connection stability is.

Bug:  805219 , 672263
Change-Id: I407c3af03eb86ccc80807395e1f18a5bff2b71a4
Reviewed-on: https://chromium-review.googlesource.com/894445
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533521}
[modify] https://crrev.com/d87e25edb2924948b728832225c7097e5a8b9ef7/chromeos/components/tether/message_transfer_operation.cc
[modify] https://crrev.com/d87e25edb2924948b728832225c7097e5a8b9ef7/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/d87e25edb2924948b728832225c7097e5a8b9ef7/tools/metrics/histograms/histograms.xml

Labels: M-65 Merge-Request-65
Pls apply appropriate OSs labels. Thank you.
Labels: OS-Chrome
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 2 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 2 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c1d13765451be5c321ad78a06cf39001b6427a

commit d5c1d13765451be5c321ad78a06cf39001b6427a
Author: Kyle Horimoto <khorimoto@google.com>
Date: Fri Feb 02 19:16:09 2018

[CrOS Tether] Add metrics for GATT connection success/failures.

This CL adds two metrics:
  (1) Success rate for GATT connection attempts.
  (2) Effective success rate for one or multiple connection attempts,
      using retries if a previous connection failed (up to the maximum
      number of retries).

These metrics aid in our ability to analyze what our effective
connection stability is.

TBR=khorimoto@google.com

(cherry picked from commit d87e25edb2924948b728832225c7097e5a8b9ef7)

Bug:  805219 , 672263
Change-Id: I407c3af03eb86ccc80807395e1f18a5bff2b71a4
Reviewed-on: https://chromium-review.googlesource.com/894445
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533521}
Reviewed-on: https://chromium-review.googlesource.com/899910
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#265}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/d5c1d13765451be5c321ad78a06cf39001b6427a/chromeos/components/tether/message_transfer_operation.cc
[modify] https://crrev.com/d5c1d13765451be5c321ad78a06cf39001b6427a/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/d5c1d13765451be5c321ad78a06cf39001b6427a/tools/metrics/histograms/histograms.xml

Sign in to add a comment