Please provide icons for the cells in the top level of settings.

Please also provide a spec for the size of the icon and the horizontal padding around the icon.

Developer builds have additional cells for "debug" menu items, like "view source" or "log js errors".  Could we have an icon for these as well?  Maybe a tools icon or something?

The icons are currently being proposed to UI Review. I will update the bug once approved. 

The size, position and padding of the icons are exactly similar as a favicon background of cells in collections that have a favicon. Does that help or do you want me to spec more? 



Dummy icons can be found here:
https://drive.google.com/corp/drive/u/0/folders/1IHQ4O-qEVRt6yVtEQbv9w4l4e3RU7Vol

Current Update:
UI Review has been OOO until today, hope that get an approval soon. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb0c1a26ff18ed88f6feed40f44d93c163be336

commit 5fb0c1a26ff18ed88f6feed40f44d93c163be336
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Jul 10 19:19:22 2018

[ios] Adds icons to SettingsDetailItem and SettingsSwitchItem.

Adds optional icons to the leading edge of these two cells. If one is
set, the remaining contents of the cells will be inset to make room for
the icon. The cells continue to display without an icon by default.

Updates the cell catalog to include example cells with icons.

BUG= 805214 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie43424a527950cf789ea27b38c4851fb0adf6f97
Reviewed-on: https://chromium-review.googlesource.com/1131316
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573851}
[modify] https://crrev.com/5fb0c1a26ff18ed88f6feed40f44d93c163be336/ios/chrome/browser/ui/settings/cells/settings_detail_item.h
[modify] https://crrev.com/5fb0c1a26ff18ed88f6feed40f44d93c163be336/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm
[modify] https://crrev.com/5fb0c1a26ff18ed88f6feed40f44d93c163be336/ios/chrome/browser/ui/settings/cells/settings_switch_item.h
[modify] https://crrev.com/5fb0c1a26ff18ed88f6feed40f44d93c163be336/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
[modify] https://crrev.com/5fb0c1a26ff18ed88f6feed40f44d93c163be336/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm

UI Review has verbally approved the icons, since Alex is OOO for another three days I would suggest implementing the updated icon set before getting a written approval. I don't expect any more changes.

I added an icon for debug menu items as requested.

The size, position and padding of the icons are exactly similar as a favicon background of cells in collections that have a favicon. Does that help or do you want me to spec more? 


The assets are here:
https://drive.google.com/corp/drive/u/0/folders/1IHQ4O-qEVRt6yVtEQbv9w4l4e3RU7Vol

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8

commit 5f5527a3ed5e88090ce316b8afac85c39cbb0ba8
Author: Rohit Rao <rohitrao@chromium.org>
Date: Thu Jul 12 10:00:36 2018

[ios] Adds icons and hides headers on the main Settings page.

Screenshot: https://drive.google.com/file/d/16aS0MP0LwdGOq8-IJgtIbq4ozXy44meT/view?usp=sharing

BUG= 805213 , 805214 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iccdd87d8f95fd80b51fcdcfa2caa691c7fcd78b4
Reviewed-on: https://chromium-review.googlesource.com/1133323
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574520}
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/BUILD.gn
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@3x.png
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm