New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Collections: Change Main settings screen cells to use the new fonts and size.

Project Member Reported by sczs@chromium.org, Jan 24 2018

Issue description

Change Main settings screen cells to use the new fonts and size. 

It should update the UI of all Main screen states e.g.:

non-signed-in user bringing up Settings, sign-in, then navigate down one level (e.g. change search engine), then back up, and dismiss by Done. This would touch 2 different layout of the main Settings screen for both signed-in and non-signed-in users and also verified minimal functionality.



 

Comment 1 by cma...@chromium.org, Jan 25 2018

Labels: Q2

Comment 2 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Owner: rohitrao@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28881e1570911f7fb1c11fc963f2592fc5ea77f6

commit 28881e1570911f7fb1c11fc963f2592fc5ea77f6
Author: Rohit Rao <rohitrao@chromium.org>
Date: Wed Jun 27 08:47:09 2018

[ios] Fork settings cells.

Creates separate text, detail, and switch cells for settings, as they will
require leading icons and different fonts from the non-Settings variants.

BUG= 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I465f9df05bc5cea20dbff8dfd21f2eacceb9057f
Reviewed-on: https://chromium-review.googlesource.com/1114605
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570700}
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/block_popups_egtest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/BUILD.gn
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/clear_browsing_data_item.h
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_cell.h
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_cell_unittest.mm
[add] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/settings_detail_item.h
[add] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/settings_detail_item.mm
[add] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/settings_switch_item.h
[add] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
[add] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/settings_text_item.h
[add] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/cells/settings_text_item.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/import_data_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller_unittest.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/test/earl_grey/chrome_actions.h
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/test/earl_grey/chrome_actions.mm
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/test/earl_grey/chrome_matchers.h
[modify] https://crrev.com/28881e1570911f7fb1c11fc963f2592fc5ea77f6/ios/chrome/test/earl_grey/chrome_matchers.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceae2654638194722e0f6f2b3ca23be6f6b4eb45

commit ceae2654638194722e0f6f2b3ca23be6f6b4eb45
Author: Rohit Rao <rohitrao@chromium.org>
Date: Wed Jun 27 13:44:55 2018

[ios] Revert back to a card style for settings.

The card style is now disabled behind a new IsSettingsUIRebootEnabled()
experimental flag.

These changes were inadvertently landed as part of
https://chromium-review.googlesource.com/c/chromium/src/+/1114605.

BUG= 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7c22b635199810bab3332443e8a9251c073ca245
Reviewed-on: https://chromium-review.googlesource.com/1116919
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570748}
[modify] https://crrev.com/ceae2654638194722e0f6f2b3ca23be6f6b4eb45/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/ceae2654638194722e0f6f2b3ca23be6f6b4eb45/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/ceae2654638194722e0f6f2b3ca23be6f6b4eb45/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d95c49d29e517d2a6b172d3f126b23ee84ca88

commit c5d95c49d29e517d2a6b172d3f126b23ee84ca88
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Jul 09 17:30:53 2018

[ios] Creates ImportDataMultilineDetailItem.

The ImportDataMultilineDetailCell was previously using
SettingsDetailItem as its model class, but items and cells should be 1:1
wherever possible.  This CL creates a new item class that's specific to
ImportDataMultilineDetailCell.

BUG= 805213 
TEST=None

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I56d45bda5022b14214b43b0567e81ff82d5eef25
Reviewed-on: https://chromium-review.googlesource.com/1128608
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573352}
[modify] https://crrev.com/c5d95c49d29e517d2a6b172d3f126b23ee84ca88/ios/chrome/browser/ui/settings/cells/BUILD.gn
[rename] https://crrev.com/c5d95c49d29e517d2a6b172d3f126b23ee84ca88/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.h
[rename] https://crrev.com/c5d95c49d29e517d2a6b172d3f126b23ee84ca88/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.mm
[rename] https://crrev.com/c5d95c49d29e517d2a6b172d3f126b23ee84ca88/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item_unittest.mm
[modify] https://crrev.com/c5d95c49d29e517d2a6b172d3f126b23ee84ca88/ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm
[modify] https://crrev.com/c5d95c49d29e517d2a6b172d3f126b23ee84ca88/ios/chrome/browser/ui/settings/import_data_collection_view_controller_unittest.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/764a493bfc5c4a8fe039ea67c418b6fb23fb0841

commit 764a493bfc5c4a8fe039ea67c418b6fb23fb0841
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Jul 09 18:33:05 2018

[ios] Adds a "cell style" property to cells that are shared with Settings.

Settings is moving to a different set of fonts and colors from other
collections. This CL adds a CollectionViewCellStyle property to shared cells.

BUG= 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8a38c07fcbee95aafb84cfcf4a4a3589e35bd4e3
Reviewed-on: https://chromium-review.googlesource.com/1129039
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573374}
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/autofill/cells/BUILD.gn
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/autofill/cells/autofill_edit_item.h
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/collection_view/cells/BUILD.gn
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.h
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.mm
[add] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/collection_view/cells/collection_view_cell_constants.h
[add] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/collection_view/cells/collection_view_cell_style.h
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.h
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.mm
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/browser/ui/settings/cells/BUILD.gn
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/common/ui_util/constraints_ui_util.h
[modify] https://crrev.com/764a493bfc5c4a8fe039ea67c418b6fb23fb0841/ios/chrome/common/ui_util/constraints_ui_util.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6283fa786a92c6d7a25a5f02dd3f62c852f83d77

commit 6283fa786a92c6d7a25a5f02dd3f62c852f83d77
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Jul 10 14:39:06 2018

[ios] Adds more cells to the Material Cell Catalog.

Adds cells that are used in Settings but weren't previously included in
the catalog.

BUG=754032, 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I72bfffe0b338073ba52f9283a9cbc1ec62d69816
Reviewed-on: https://chromium-review.googlesource.com/1129040
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573721}
[modify] https://crrev.com/6283fa786a92c6d7a25a5f02dd3f62c852f83d77/ios/chrome/app/startup/setup_debugging.mm
[modify] https://crrev.com/6283fa786a92c6d7a25a5f02dd3f62c852f83d77/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm

Labels: -small large
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/803f2064bd2285cd18cac2393399855b098dee1c

commit 803f2064bd2285cd18cac2393399855b098dee1c
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Jul 10 17:08:35 2018

[ios] Switches to the UIKit cell style in Settings.

Uses the cellStyle property on AutofillEditItem,
CollectionViewAccountItem, and CollectionViewFooterItem to adopt UIKit
styling when those cells are used in Settings.

BUG= 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5bd569fa0c6b497c61299728b3ff8b231b5d8534
Reviewed-on: https://chromium-review.googlesource.com/1131557
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573781}
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/803f2064bd2285cd18cac2393399855b098dee1c/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c51c39a96546bd07b49ba27b36931b8822f7395a

commit c51c39a96546bd07b49ba27b36931b8822f7395a
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Jul 10 18:29:58 2018

[ios] Updates settings cells with new fonts and text colors.

Cells are updated to use system fonts and text colors that match the
"UIKit" collection view style, conditionally when the UIRefresh
experiment is enabled.  Cells are also updated to work in both
self-sizing and fixed-size scenarios, by making the padding at the top
and bottom of the cell optional.  (Previously, the vertical padding was
required and would clip labels if the text size got too large.)

BUG= 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I39d4ea5e910abbcf8da8eae45572b0ab4688a0bf
Reviewed-on: https://chromium-review.googlesource.com/1131563
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573820}
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/account_signin_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/autofill_data_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/card_multiline_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/encryption_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/passphrase_error_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/password_details_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/settings_text_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/sync_switch_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/text_and_error_item.mm
[modify] https://crrev.com/c51c39a96546bd07b49ba27b36931b8822f7395a/ios/chrome/browser/ui/settings/cells/version_item.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e67975ffe8fb4f9e2146d8e27b8476e86e1c56c

commit 8e67975ffe8fb4f9e2146d8e27b8476e86e1c56c
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Jul 10 18:35:50 2018

[ios] Updates the styling of the CopiedToChrome settings cell.

Updates the cell to use new fonts and text colors when the UIRefresh
experiment is enabled. Fixes constraint errors that were causing
ambiguous layout in the cell. Adds horizontal padding around the sides
of the cell to visually separate the button from the trailing edge of
the cell.

BUG= 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaabc27c512b3a729891813372ac05326c4039e35
Reviewed-on: https://chromium-review.googlesource.com/1131561
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573826}
[modify] https://crrev.com/8e67975ffe8fb4f9e2146d8e27b8476e86e1c56c/ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.h
[modify] https://crrev.com/8e67975ffe8fb4f9e2146d8e27b8476e86e1c56c/ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.mm
[modify] https://crrev.com/8e67975ffe8fb4f9e2146d8e27b8476e86e1c56c/ios/chrome/browser/ui/settings/cells/copied_to_chrome_item_unittest.mm

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8

commit 5f5527a3ed5e88090ce316b8afac85c39cbb0ba8
Author: Rohit Rao <rohitrao@chromium.org>
Date: Thu Jul 12 10:00:36 2018

[ios] Adds icons and hides headers on the main Settings page.

Screenshot: https://drive.google.com/file/d/16aS0MP0LwdGOq8-IJgtIbq4ozXy44meT/view?usp=sharing

BUG= 805213 , 805214 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iccdd87d8f95fd80b51fcdcfa2caa691c7fcd78b4
Reviewed-on: https://chromium-review.googlesource.com/1133323
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574520}
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/BUILD.gn
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@3x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/Contents.json
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@2x.png
[add] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@3x.png
[modify] https://crrev.com/5f5527a3ed5e88090ce316b8afac85c39cbb0ba8/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a9df3cfa8649df168a1378a15b7a49e8753ced5

commit 3a9df3cfa8649df168a1378a15b7a49e8753ced5
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Jul 16 21:37:49 2018

[ios] Enables the new Settings UI by default.

BUG= 805213 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I347e8d51e721b776de1a3e484de21b48a8a27a15
Reviewed-on: https://chromium-review.googlesource.com/1138337
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575432}
[modify] https://crrev.com/3a9df3cfa8649df168a1378a15b7a49e8753ced5/ios/chrome/browser/experimental_flags.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 69.0.3494.0 Canary, iPhone X  iOS11.4, iPad Air  iOS11.4

Looks good.
https://drive.google.com/file/d/1hJccb130G-y9-iNWteFDatHG8ee43lsS/view

Sign in to add a comment