New issue
Advanced search Search tips

Issue 805209 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-04
OS: iOS
Pri: 1
Type: Task
Q2

Blocked on:
issue 805158

Blocking:
issue 805210
issue 805211



Sign in to add a comment

Collections: Migrate the Model so it works with a TableView instead of a CollectionView

Project Member Reported by sczs@chromium.org, Jan 24 2018

Issue description

Migrate the Model so it works with a TableView instead of a CollectionView
 

Comment 1 by sczs@chromium.org, Jan 24 2018

Blocking: 805210

Comment 2 by sczs@chromium.org, Jan 24 2018

Blocking: 805211

Comment 3 by cma...@chromium.org, Jan 25 2018

Labels: Q2

Comment 4 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 5 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-0
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by sczs@chromium.org, Apr 12 2018

Labels: -medium large

Comment 8 by sczs@chromium.org, Apr 12 2018

Cc: sczs@chromium.org
Owner: kkhorimoto@chromium.org

Comment 9 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-05-23
Status: Started (was: Assigned)
NextAction: 2018-06-06
The NextAction date has arrived: 2018-06-06
NextAction: 2018-06-20
The NextAction date has arrived: 2018-06-20
I  have several CLs in flight for this bug right now.  The most recent is crrev.com/c/1104941; you can see the other CLs in the dependency chain of this one.
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/537097c34134275a822c4f4edd9c0f39576ed8e9

commit 537097c34134275a822c4f4edd9c0f39576ed8e9
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jun 20 18:10:21 2018

[iOS] Add experimental_flags::IsReadingListUIReootEnabled()

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ida292ceb4968059c945edd3bbeb5ed5a0510a55f
Reviewed-on: https://chromium-review.googlesource.com/1104887
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568925}
[modify] https://crrev.com/537097c34134275a822c4f4edd9c0f39576ed8e9/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/537097c34134275a822c4f4edd9c0f39576ed8e9/ios/chrome/browser/experimental_flags.mm

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb283211a0e53bcc45271c46300edfa675d02d3

commit bfb283211a0e53bcc45271c46300edfa675d02d3
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Fri Jun 22 21:14:35 2018

[iOS] Created ReadingListContextMenuCoordinator.

This encapsulates the context menu functionality that will be shared
across the legacy and new implementation of the reading list UI.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie17832216d81a1b243ea45ba0cb7cb98c6805115
Reviewed-on: https://chromium-review.googlesource.com/1101914
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569777}
[modify] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/BUILD.gn
[add] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/context_menu/BUILD.gn
[add] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/context_menu/reading_list_context_menu_commands.h
[add] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/context_menu/reading_list_context_menu_coordinator.h
[add] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/context_menu/reading_list_context_menu_coordinator.mm
[add] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/context_menu/reading_list_context_menu_params.h
[add] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/context_menu/reading_list_context_menu_params.mm
[modify] https://crrev.com/bfb283211a0e53bcc45271c46300edfa675d02d3/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d8b06e49e0262145480b6719e92e8a726259eaf

commit 1d8b06e49e0262145480b6719e92e8a726259eaf
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Jun 25 19:18:23 2018

[iOS] Move ReadingListUIDistillationStatus to a separate file.

This is used for both the collection view and table view implementaitons
of the Reading List UI, so needs to be moved to a shared location.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia01403e6d318b4ea331ed85ba622c4ce8ce041cf
Reviewed-on: https://chromium-review.googlesource.com/1102119
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570126}
[modify] https://crrev.com/1d8b06e49e0262145480b6719e92e8a726259eaf/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/1d8b06e49e0262145480b6719e92e8a726259eaf/ios/chrome/browser/ui/reading_list/reading_list_collection_view_cell.h
[add] https://crrev.com/1d8b06e49e0262145480b6719e92e8a726259eaf/ios/chrome/browser/ui/reading_list/reading_list_ui_distillation_status.h

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbcb779630eae3419b2aa6cc0109a127e7fc42b2

commit bbcb779630eae3419b2aa6cc0109a127e7fc42b2
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Jun 25 20:28:57 2018

[iOS] Rename ReadingListCollectionViewAccessibilityDelegate.

This has been renamed to ReadingListListViewAccessibilityDelegate, and
its interface has been updated to use ListItems rather than
CollectionViewItems so the protocol can be shared between
implementations.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ief145a21be03ae1bfeb23419e57875be8128c1d6
Reviewed-on: https://chromium-review.googlesource.com/1102125
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570159}
[modify] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
[modify] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
[delete] https://crrev.com/c4b10123eaea5c53f3db3fa8f4e4108d9fcf87f5/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item_accessibility_delegate.h
[modify] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/reading_list_data_source.h
[add] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/reading_list_list_view_item_accessibility_delegate.h
[modify] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
[modify] https://crrev.com/bbcb779630eae3419b2aa6cc0109a127e7fc42b2/ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48977ea678de176b2c49b619162553774503b4ad

commit 48977ea678de176b2c49b619162553774503b4ad
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jun 27 03:52:22 2018

[iOS] Update TableViewURLItem/Cell for Reading List.

This CL adds the ability to specify supplemental text for the URL label
and an optional badge view to display over the favicon view.

Bug:  805209 ,  852429 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I609fe777feda0242a3748902e739e07fe43590ad
Reviewed-on: https://chromium-review.googlesource.com/1104891
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570655}
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/BUILD.gn
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/Contents.json
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/table_view_cell_check_mark.png
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/table_view_cell_check_mark@2x.png
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/table_view_cell_check_mark@3x.png
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/table_view_url_item.h
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/table_view_url_item_unittest.mm

Comment 21 by marq@chromium.org, Jun 27 2018

NextAction: 2018-07-04
Moving open tasks to the current sprint.

Comment 22 by marq@chromium.org, Jun 27 2018

Labels: Pri-1
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15b5ec030be84d33353ff90a9abc44544199a68

commit d15b5ec030be84d33353ff90a9abc44544199a68
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Jun 28 18:48:57 2018

[iOS] Create ReadingListToolbarButtonManager.

This class is responsible for deciding what toolbar buttons should be
displayed for the UITableView-based ReadingList implementation.

Bug:  805209 ,  805211 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic619f746d4ecd52a700f57efc959c587c4976803
Reviewed-on: https://chromium-review.googlesource.com/1106970
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571211}
[modify] https://crrev.com/d15b5ec030be84d33353ff90a9abc44544199a68/ios/chrome/browser/ui/reading_list/BUILD.gn
[add] https://crrev.com/d15b5ec030be84d33353ff90a9abc44544199a68/ios/chrome/browser/ui/reading_list/reading_list_toolbar_button_commands.h
[add] https://crrev.com/d15b5ec030be84d33353ff90a9abc44544199a68/ios/chrome/browser/ui/reading_list/reading_list_toolbar_button_manager.h
[add] https://crrev.com/d15b5ec030be84d33353ff90a9abc44544199a68/ios/chrome/browser/ui/reading_list/reading_list_toolbar_button_manager.mm

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8

commit db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Jun 28 23:17:18 2018

[iOS] Created ReadingListTableViewItem.

This is the TableView equivalent of ReadingListCollectionViewItem.
This CL also consolidates logic shared between the table and
collection version of these items into helper functions called by
the mediator.  In addition, the shared logic calculating custom
accessibility actions for cells has been moved to a helper object
owned by the table/collection views.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If6aed9d4ead9b167c8700e0db0c6c4dac5b6f132
Reviewed-on: https://chromium-review.googlesource.com/1104892
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571320}
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_collection_view_cell.h
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_collection_view_cell.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_data_source.h
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[add] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_list_item.h
[add] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_list_view_item_custom_action_factory.h
[add] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_list_view_item_custom_action_factory.mm
[add] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_list_view_item_util.h
[add] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_list_view_item_util.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
[modify] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm
[add] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_table_view_item.h
[add] https://crrev.com/db4eae9d8e0d0290f92e6854f20c2a10d3b8cac8/ios/chrome/browser/ui/reading_list/reading_list_table_view_item.mm

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e49de80b6aa4ddffb4af0e6f98618747a1b8773

commit 8e49de80b6aa4ddffb4af0e6f98618747a1b8773
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Jul 02 19:14:07 2018

[iOS] Update ReadingListMediator to support UITableViews.

This CL updates ReadingListMediator to support both UICollectionViews
and UITableViews.  Additionally, ReadingListDataSource and
ReadingListDataSink have been updated to use ReadingListListItems
rather than CollectionViewItems.

ReadingListMediator now takes a ReadingListListItemFactory, which
handles supplying the correct subclass of ListItem to the data sink.
This item factory will take ownership of the custom a11y action factory
as well.

Additionally, this CL moves ReadingListCollectionViewController to its
own file, and renames ReadingListListViewItem* classes to remove the
"View" in their names.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4b22768212a03b661a8b60913948eed6116de461
Reviewed-on: https://chromium-review.googlesource.com/1104896
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571960}
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_coordinator.h
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_data_sink.h
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_data_source.h
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item.h
[add] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_accessibility_delegate.h
[add] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_custom_action_factory.h
[rename] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_custom_action_factory.mm
[add] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_factory.h
[add] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_factory.mm
[add] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_factory_unittest.mm
[rename] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_util.h
[rename] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_item_util.mm
[add] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_list_view_controller_delegate.h
[delete] https://crrev.com/a6f0dbf74599a22d703662a6399f37df5eca50c6/ios/chrome/browser/ui/reading_list/reading_list_list_view_item_accessibility_delegate.h
[delete] https://crrev.com/a6f0dbf74599a22d703662a6399f37df5eca50c6/ios/chrome/browser/ui/reading_list/reading_list_list_view_item_custom_action_factory.h
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_mediator.h
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_table_view_item.mm
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h
[modify] https://crrev.com/8e49de80b6aa4ddffb4af0e6f98618747a1b8773/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2209beb42500ff6f524cfad18cb037a17823abf

commit b2209beb42500ff6f524cfad18cb037a17823abf
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Jul 02 19:57:36 2018

[iOS] Created ReadingListTableViewController.

This class is largely based on ReadingListCollectionViewController.
Rather than using a custom view for the toolbar, this class uses
ReadingListToolbarButtonManager to create toolbar items to display.

In addition, this CL adds a batch update selector to
ChromeTableViewController that optionally uses the iOS11 batch
functionality.

This CL also renamed ReadingListEmptyCollectionBackground to
EmptyReadingListBackgroundView since it's used by both table- and
collection-based implementations.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id22a71d99748eacc5e6f6bf116a147e9cb39429b
Reviewed-on: https://chromium-review.googlesource.com/1110597
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571978}
[modify] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/BUILD.gn
[add] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.h
[rename] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.mm
[modify] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
[modify] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[delete] https://crrev.com/2fcc6147752fbb6221bbf8e9ab756d87fa85eca6/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.h
[add] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_list_item_updater.h
[add] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_list_view_controller_audience.h
[add] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.h
[add] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
[modify] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
[modify] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h
[modify] https://crrev.com/b2209beb42500ff6f524cfad18cb037a17823abf/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec

commit 84e64dcd1bd0a851d5a396a5cdbfec053deed3ec
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Jul 03 07:43:49 2018

[iOS] Rename legacy reading list classes.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1e536359e9a0ebad3a13382afd04969d4cfa6244
Reviewed-on: https://chromium-review.googlesource.com/1110756
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572138}
[modify] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/BUILD.gn
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_coordinator.h
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_coordinator.mm
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_coordinator_unittest.mm
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_toolbar.h
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_toolbar.mm
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_toolbar_button.h
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_toolbar_button.mm
[add] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_view_controller.h
[rename] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/legacy_reading_list_view_controller.mm
[modify] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
[modify] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/84e64dcd1bd0a851d5a396a5cdbfec053deed3ec/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[delete] https://crrev.com/6db6bb14d75637ca994218de6e542e0b086a9b3d/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74bafc2d34898a1d593ef9b9e9dc6278f9ef1033

commit 74bafc2d34898a1d593ef9b9e9dc6278f9ef1033
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Jul 03 09:32:10 2018

[iOS] Create ReadingListCoordinator.

This CL creates ReadingListCoordinator, which uses UITableViews and
replaces the old UICollectionView-based implementation.

Bug:  805209 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I59acbe85cb389c69462bb72ddb7858acb1249c55
Reviewed-on: https://chromium-review.googlesource.com/1104941
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572157}
[modify] https://crrev.com/74bafc2d34898a1d593ef9b9e9dc6278f9ef1033/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/74bafc2d34898a1d593ef9b9e9dc6278f9ef1033/ios/chrome/browser/ui/reading_list/BUILD.gn
[add] https://crrev.com/74bafc2d34898a1d593ef9b9e9dc6278f9ef1033/ios/chrome/browser/ui/reading_list/reading_list_coordinator.h
[add] https://crrev.com/74bafc2d34898a1d593ef9b9e9dc6278f9ef1033/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm

The NextAction date has arrived: 2018-07-04
Status: Fixed (was: Started)
Updating the state so it reflects on tracking.

Sign in to add a comment