New issue
Advanced search Search tips

Issue 805207 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

use base::Optional instead of ImageView::ImageSizeSet

Project Member Reported by newcomer@chromium.org, Jan 24 2018

Issue description

Components: UI>Browser
Labels: mp-triage
Labels: Hotlist-GoodFirstBug
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79de99d68bb8bb066362743c635ec14b9bc2e87

commit e79de99d68bb8bb066362743c635ec14b9bc2e87
Author: qi1988.yang <qi1988.yang@samsung.com>
Date: Mon Mar 12 08:05:17 2018

Use base::Optional instead of ImageView::image_size_set_

As close as possible to the C++17 standard, use std::Optional.

Bug:  805207 

Signed-off-by: qi1988.yang <qi1988.yang@samsung.com>
Change-Id: I88560f320ad38b986eb84a73e488eb4968ea1660
Reviewed-on: https://chromium-review.googlesource.com/956652
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542441}
[modify] https://crrev.com/e79de99d68bb8bb066362743c635ec14b9bc2e87/ui/views/controls/image_view.cc
[modify] https://crrev.com/e79de99d68bb8bb066362743c635ec14b9bc2e87/ui/views/controls/image_view.h

Status: Fixed (was: Unconfirmed)

Sign in to add a comment