New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805204 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

kOverrideUseSoftwareGLForTests doesn't really force Chrome to run with the software GL

Project Member Reported by zmo@chromium.org, Jan 24 2018

Issue description

This only fakes vendor_id / device_id in GPUInfo, but without specifying kUseGL, GPU process still runs with whatever default GL implementation on the platform.

I tried to force it to SwiftShader on Linux, but some tests failed due to this. There is likely a behavioral difference that we need to amend SwiftShader to match.
 

Comment 1 by zmo@chromium.org, Jan 24 2018

I will provide a test CL to trigger the tests failure I mentioned above

Comment 2 by zmo@chromium.org, Jan 24 2018

Cc: -sugoi@chromium.org
Owner: sugoi@chromium.org
Status: Assigned (was: Available)
This CL should trigger the failing tests:

https://chromium-review.googlesource.com/c/chromium/src/+/882614

Alexis, can you take a look at these Win/Linux failures and maybe fix them, so we could switch over to SwiftShader?

Comment 3 by zmo@chromium.org, Jan 24 2018

Labels: OS-Linux OS-Windows

Comment 4 by zmo@chromium.org, Jan 24 2018

Cc: sugoi@chromium.org
Owner: zmo@chromium.org
Correction: kOverrideUseSoftwareGLForTests is hooked up on the GPU process in gl_factory.cc.

However, the behaviors are still different from passing in kUseGL=software_renderer.

I suspect the difference is caused by ComputeGpuFeatureInfo, where kUseGL make change a few decisions.

Sign in to add a comment